Bug#181872: Patch

2003-04-18 Thread Gerfried Fuchs
* Andrew Shugg <[EMAIL PROTECTED]> [2003-04-18 02:10]: > Josip Rodin said: >> You've clearly outvoted me on this, but I maintain that it will be me who >> will have to explain it if someone files a bug about it. A bug about broken package descriptions? Joy, you are not responsible for broken pac

Bug#181872: Patch

2003-04-17 Thread Andrew Shugg
Josip Rodin said: > On Wed, Apr 16, 2003 at 05:31:17PM +0200, Gerfried Fuchs wrote: > > Joy, do you really insist on changing the _content_ of the package > > descriptions which are text/plain, to make them show _different_ > > informations than the various package management tools do?? That is a

Bug#181872: Patch

2003-04-17 Thread Josip Rodin
On Wed, Apr 16, 2003 at 05:31:17PM +0200, Gerfried Fuchs wrote: > Joy, do you really insist on changing the _content_ of the package > descriptions which are text/plain, to make them show _different_ > informations than the various package management tools do?? That is a > bad thing and I guess y

Bug#181872: Patch

2003-04-16 Thread Andrew Shugg
Denis Barbier said: > On Wed, Apr 16, 2003 at 10:18:27PM +0800, Andrew Shugg wrote: > [...] > > To clarify what I outlined in #186740, if you were to start with this > > sort of string: > > > > &foo blah & > > > > you would end up with this in the HTML: > > > > &foo blah & >

Bug#181872: Patch

2003-04-16 Thread Colin Watson
On Wed, Apr 16, 2003 at 10:18:27PM +0800, Andrew Shugg wrote: > Denis Barbier said: > > Nope, ampersnads must be escaped, period. > > Example: > > Description: escape HTML special characters in plain text > >EscapeHTML converts all &, < and > characters into &, < and > >>. > > > > There

Bug#181872: Patch

2003-04-16 Thread Denis Barbier
On Wed, Apr 16, 2003 at 10:18:27PM +0800, Andrew Shugg wrote: [...] > To clarify what I outlined in #186740, if you were to start with this > sort of string: > > &foo blah & > > you would end up with this in the HTML: > > &foo blah & ^ No, it should be & sinc

Bug#181872: Patch

2003-04-16 Thread Gerfried Fuchs
* Andrew Shugg <[EMAIL PROTECTED]> [2003-04-16 22:18]: > To clarify what I outlined in #186740, if you were to start with this > sort of string: > > &foo blah & > > you would end up with this in the HTML: > > &foo blah & > > which would be rendered in the browser (ie entities decoded

Bug#181872: Patch

2003-04-16 Thread Andrew Shugg
Denis Barbier said: > On Tue, Apr 15, 2003 at 06:56:23PM +0200, Frank Lichtenheld wrote: > > I think, the solution presented by Andrew Shugg in #186740 is the > > right way to go. > > Nope, ampersnads must be escaped, period. > Example: > Description: escape HTML special characters in plain text

Bug#181872: Patch

2003-04-16 Thread Denis Barbier
On Tue, Apr 15, 2003 at 06:56:23PM +0200, Frank Lichtenheld wrote: > On Tue, Apr 15, 2003 at 05:53:47PM +0200, Josip Rodin wrote: > > On Tue, Apr 15, 2003 at 04:39:23PM +0200, Denis Barbier wrote: > > > No, within plain text one writes http://foo.org/?a=1&b=2, escaping is only > > > performed for s

Bug#181872: Patch

2003-04-16 Thread Josip Rodin
On Tue, Apr 15, 2003 at 06:56:23PM +0200, Frank Lichtenheld wrote: > > > No, within plain text one writes http://foo.org/?a=1&b=2, escaping is only > > > performed for some other formats (SGML and co). > > > So unless descriptions are going to be considered as HTML text, this fix > > > is meaningfu

Bug#181872: Patch

2003-04-15 Thread Frank Lichtenheld
On Tue, Apr 15, 2003 at 05:53:47PM +0200, Josip Rodin wrote: > On Tue, Apr 15, 2003 at 04:39:23PM +0200, Denis Barbier wrote: > > No, within plain text one writes http://foo.org/?a=1&b=2, escaping is only > > performed for some other formats (SGML and co). > > So unless descriptions are going to be

Bug#181872: Patch

2003-04-15 Thread Josip Rodin
On Tue, Apr 15, 2003 at 04:39:23PM +0200, Denis Barbier wrote: > > > > > + $long_desc =~ s/\&/\&\;/go; > > > > > > > > That sounds like a fix for another bug, and it doesn't look like it > > > > would > > > > actually handle the read &s in descriptions... > > > > > > You're right,

Bug#181872: Patch

2003-04-15 Thread Denis Barbier
On Thu, Mar 13, 2003 at 07:58:05PM +0100, Josip Rodin wrote: [...] > > > > + $long_desc =~ s/\&/\&\;/go; > > > > > > That sounds like a fix for another bug, and it doesn't look like it would > > > actually handle the read &s in descriptions... > > > > You're right, that this line (a

Bug#181872: Patch

2003-03-17 Thread Gerfried Fuchs
* Frank Lichtenheld <[EMAIL PROTECTED]> [2003-03-14 15:16]: > On Thu, Mar 13, 2003 at 10:12:14PM +0100, Josip Rodin wrote: >> Well, I think in principle it's much better to just match until the first >> closing bracket since IME such things are less prone to errors. Of course, >> if someone found U

Bug#181872: Patch

2003-03-14 Thread Frank Lichtenheld
On Thu, Mar 13, 2003 at 10:12:14PM +0100, Josip Rodin wrote: > On Thu, Mar 13, 2003 at 09:27:28PM +0100, Frank Lichtenheld wrote: > > Ok. Let's elaborate a little. Sorry if it's too long. > > Oh, I understood perfectly what you said, I just meant to say that I thought > the original code preserved

Bug#181872: Patch

2003-03-13 Thread Josip Rodin
On Thu, Mar 13, 2003 at 09:27:28PM +0100, Frank Lichtenheld wrote: > > > > The right fix would be simply > > > > $long_desc =~ s,<(?:URL:\s*)?(http://[^>]+)\s*>,\<\;$1\>\;,go; > > > > > > > > Right? > > > > > > Yours would do also. The main difference in result is that you delete > > > the 'URL:'

Bug#181872: Patch

2003-03-13 Thread Frank Lichtenheld
On Thu, Mar 13, 2003 at 07:58:05PM +0100, Josip Rodin wrote: > On Thu, Mar 13, 2003 at 06:46:35PM +0100, Frank Lichtenheld wrote: > > > The right fix would be simply > > > $long_desc =~ s,<(?:URL:\s*)?(http://[^>]+)\s*>,\<\;$1\>\;,go; > > > > > > Right? > > > > Yours would do also. The main diffe

Bug#181872: Patch

2003-03-13 Thread Josip Rodin
On Thu, Mar 13, 2003 at 06:46:35PM +0100, Frank Lichtenheld wrote: > > > --- pages.pl30 Jan 2003 14:43:59 - 1.9 > > > +++ pages.pl13 Mar 2003 14:30:56 - > > > - $long_desc =~ > > > s,<((URL:)?http://[\S~-]+?/?)>,\<\;$1\>\;,go; > > > + $long_desc =~

Bug#181872: Patch

2003-03-13 Thread Frank Lichtenheld
On Thu, Mar 13, 2003 at 06:27:15PM +0100, Josip Rodin wrote: > On Thu, Mar 13, 2003 at 03:42:54PM +0100, Frank Lichtenheld wrote: > > tags 181872 + patch > > thanks > > > > [Problem of 'http://scummvm.sf.net/compatibility.php>' > > being converted to > > ' > href="http://scummvm.sf.net/compatibil

Bug#181872: Patch

2003-03-13 Thread Josip Rodin
On Thu, Mar 13, 2003 at 03:42:54PM +0100, Frank Lichtenheld wrote: > tags 181872 + patch > thanks > > [Problem of 'http://scummvm.sf.net/compatibility.php>' > being converted to > ' href="http://scummvm.sf.net/compatibility.php>">http://scummvm.sf.net/compatibility.php>'] > > The following patch

Bug#181872: Patch

2003-03-13 Thread Frank Lichtenheld
tags 181872 + patch thanks [Problem of 'http://scummvm.sf.net/compatibility.php>' being converted to 'http://scummvm.sf.net/compatibility.php>">http://scummvm.sf.net/compatibility.php>'] The following patch should fix the problem. It allows whitespaces beetween "http://";. I've also added some m