Bug#541160: #541160 xterm: heap corruption when changing window size

This one is hard to reproduce (here). valgrind is not showing me any problems as I resize the screen in various ways. There are several special cases in the resizing logic, depending on resource-settings, as well as the amount of text that has been scrolled off onto the saved-lines buffer. More

Bug#541160: #541160 xterm: heap corruption when changing window size

On 2009-08-12 17:15:25 -0400, Thomas Dickey wrote: > This one is hard to reproduce (here). valgrind is not showing me any > problems as I resize the screen in various ways. > > There are several special cases in the resizing logic, depending on > resource-settings, as well as the amount of text t

Bug#541160: #541160 xterm: heap corruption when changing window size

On Wed, 12 Aug 2009, Vincent Lefevre wrote: On 2009-08-12 17:15:25 -0400, Thomas Dickey wrote: This one is hard to reproduce (here). valgrind is not showing me any problems as I resize the screen in various ways. There are several special cases in the resizing logic, depending on resource-set

Bug#541160: #541160 xterm: heap corruption when changing window size

On 2009-08-12 17:40:10 -0400, Thomas Dickey wrote: > On Wed, 12 Aug 2009, Vincent Lefevre wrote: > >I can reproduce the crash every time with the example given in > >bug 541236 (see step 4). In case this depends on the window manager, > >I use fvwm. > > still no But the stack traces look usef

Bug#541160: #541160 xterm: heap corruption when changing window size

On Thu, 13 Aug 2009, Vincent Lefevre wrote: On 2009-08-12 17:40:10 -0400, Thomas Dickey wrote: On Wed, 12 Aug 2009, Vincent Lefevre wrote: I can reproduce the crash every time with the example given in bug 541236 (see step 4). In case this depends on the window manager, I use fvwm. still no.

Bug#541160: #541160 xterm: heap corruption when changing window size

Hi Thomas, > This one is hard to reproduce (here). valgrind is not showing me any > problems as I resize the screen in various ways. > > There are several special cases in the resizing logic, depending on > resource-settings, as well as the amount of text that has been scrolled > off onto the sa

Bug#541160: #541160 xterm: heap corruption when changing window size

On Thu, Aug 13, 2009 at 02:17:55 +0200, Jan Christoph Nordholz wrote: > I'll do a few valgrind runs myself and report back. > I got a crash (glibc abort in free()) once, can't seem to reproduce now. valgrind reports these issues though: ==864== Invalid write of size 1 ==864==at 0x402766C: me

Bug#541160: #541160 xterm: heap corruption when changing window size

On Thu, 13 Aug 2009, Jan Christoph Nordholz wrote: Hi Thomas, This one is hard to reproduce (here). valgrind is not showing me any problems as I resize the screen in various ways. There are several special cases in the resizing logic, depending on resource-settings, as well as the amount of

Bug#541160: #541160 xterm: heap corruption when changing window size

On Thu, Aug 13, 2009 at 02:17:55AM +0200, Jan Christoph Nordholz wrote: > Hi Thomas, > > > This one is hard to reproduce (here). valgrind is not showing me any > > problems as I resize the screen in various ways. > > > > There are several special cases in the resizing logic, depending on > > res

Bug#541160: #541160 xterm: heap corruption when changing window size

On 2009-08-13 02:17:55 +0200, Jan Christoph Nordholz wrote: > I'll do a few valgrind runs myself and report back. I've just done a test with valgrind. Here's the output: ==22673== Memcheck, a memory error detector. ==22673== Copyright (C) 2002-2008, and GNU GPL'd, by Julian Seward et al. ==22673=

Bug#541160: #541160 xterm: heap corruption when changing window size

Hi Thomas, > Here's a fix for the positioning problem that I've been seeing (attached). thank you very much, the malloc corruption is gone now, too. Regards, Jan signature.asc Description: Digital signature

Bug#541160: #541160 xterm: heap corruption when changing window size

On Thu, 13 Aug 2009, Jan Christoph Nordholz wrote: Hi Thomas, Here's a fix for the positioning problem that I've been seeing (attached). thank you very much, the malloc corruption is gone now, too. thanks (I can see how the addressing-error might happen, but am puzzled that I could not tr

Bug#541160: #541160 xterm: heap corruption when changing window size

On Thu, 13 Aug 2009, Julien Cristau wrote: On Thu, Aug 13, 2009 at 02:17:55 +0200, Jan Christoph Nordholz wrote: I'll do a few valgrind runs myself and report back. I got a crash (glibc abort in free()) once, can't seem to reproduce now. valgrind reports these issues though: I'm puzzled th

Bug#541160: #541160 xterm: heap corruption when changing window size

hmm. It's supposed to work. However, for background: most of the changes from 244 are restructuring changes (actually, making structs for the index of line-data). So before, I had something like unsigned char *a; unsigned char *b; unsigned char *c; unsigned char

Bug#541160: #541160 xterm: heap corruption when changing window size

On a different (non-Debian) bug report, it seems that the underlying cause is misaligned data, which would affect either type (fifo-lines or not). Now that I know where to look, I'll work on a fix... -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net signature.asc Desc

Bug#541160: #541160 xterm: heap corruption when changing window size

Here's the current changes I've made for the other bug report, including a fix for misalignment. It would be nice to see if this fixes #541160 also. thanks -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net xterm-245a.patch.gz Description: Binary data signature.asc

Bug#541160: #541160 xterm: heap corruption when changing window size

On 2009-08-14 06:38:54 -0400, Thomas Dickey wrote: > Here's the current changes I've made for the other bug report, > including a fix for misalignment. It would be nice to see if > this fixes #541160 also. I've included patch 245 and this patch in xterm-244/debian/patches and added these patches

Bug#541160: #541160 xterm: heap corruption when changing window size

On 2009-08-14 15:08:09 +0200, Vincent Lefevre wrote: > I've included patch 245 and this patch in xterm-244/debian/patches > and added these patches to "series", compiled the package with > "dpkg-buildpackage -b -uc", installed the new version with "dpkg -i", > then started xterm. > > "xterm -versi

Bug#541160: #541160 xterm: heap corruption when changing window size

Perhaps you could reproduce the problem with xterm -e "gunzip -c Xterm.log.gz; sleep 60" and the attached compressed log file. * Double-clicking on a "aaa...aaa" (*except* one of the first 5) selects the previous "bbb...bbb" too. * Decreasing the number of lines of the window makes xterm se

Bug#541160: #541160 xterm: heap corruption when changing window size

On 2009-08-14 16:15:00 +0200, Vincent Lefevre wrote: > Perhaps you could reproduce the problem with > > xterm -e "gunzip -c Xterm.log.gz; sleep 60" > > and the attached compressed log file. > > * Double-clicking on a "aaa...aaa" (*except* one of the first 5) > selects the previous "bbb...bbb

Bug#541160: #541160 xterm: heap corruption when changing window size

On Fri, Aug 14, 2009 at 04:15:00PM +0200, Vincent Lefevre wrote: > Perhaps you could reproduce the problem with > > xterm -e "gunzip -c Xterm.log.gz; sleep 60" xterm -geom 80x60 -e "gunzip -c Xterm.log.gz; sleep 60" With this combination, I can see the highlighting you're describing (will

Bug#541160: #541160 xterm: heap corruption when changing window size

On 2009-08-14 17:14:04 -0400, Thomas Dickey wrote: > On Fri, Aug 14, 2009 at 04:15:00PM +0200, Vincent Lefevre wrote: > > * Decreasing the number of lines of the window makes xterm segfault. > > ...but still no segfault (but perhaps it will be part of the same bug). Perhaps valgrind can detect th

Bug#541160: #541160 xterm: heap corruption when changing window size

On Sat, 15 Aug 2009, Vincent Lefevre wrote: On 2009-08-14 17:14:04 -0400, Thomas Dickey wrote: On Fri, Aug 14, 2009 at 04:15:00PM +0200, Vincent Lefevre wrote: * Decreasing the number of lines of the window makes xterm segfault. ...but still no segfault (but perhaps it will be part of the sa

Bug#541160: #541160 xterm: heap corruption when changing window size

On 2009-08-14 18:27:53 -0400, Thomas Dickey wrote: > I did try that - found nothing (except of course memory leaks). > I assume there's something different about the way I'm building > xterm... Did you try with the same options as Debian? -- Vincent Lefèvre - Web: 100%

Bug#541160: #541160 xterm: heap corruption when changing window size

On Sat, 15 Aug 2009, Vincent Lefevre wrote: On 2009-08-14 18:27:53 -0400, Thomas Dickey wrote: I did try that - found nothing (except of course memory leaks). I assume there's something different about the way I'm building xterm... Did you try with the same options as Debian? initially, yes

Bug#541160: #541160 xterm: heap corruption when changing window size

On Sat, 15 Aug 2009, Vincent Lefevre wrote: On 2009-08-14 17:14:04 -0400, Thomas Dickey wrote: On Fri, Aug 14, 2009 at 04:15:00PM +0200, Vincent Lefevre wrote: * Decreasing the number of lines of the window makes xterm segfault. ...but still no segfault (but perhaps it will be part of the sa

Bug#541160: #541160 xterm: heap corruption when changing window size

fixed in patch #246 -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net signature.asc Description: Digital signature