[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-02-07 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470850 ] Knut Anders Hatlen commented on DERBY-2191: --- Committed grow.diff with revision 504460. Cleanup of

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-02-06 Thread Dyre Tjeldvoll (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470538 ] Dyre Tjeldvoll commented on DERBY-2191: --- I think grow.diff should be committed. Cleanup of FormatableBitSet

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-02-01 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469402 ] Knut Anders Hatlen commented on DERBY-2191: --- Thanks Dyre! Committed shrink.v2 with revision 502185.

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-31 Thread Dyre Tjeldvoll (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469012 ] Dyre Tjeldvoll commented on DERBY-2191: --- I think a single method makes a lot of sense, and I would seriously

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-31 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469059 ] Knut Anders Hatlen commented on DERBY-2191: --- A couple of tiny comments to shrink.v1: 1) Javadoc for

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-30 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468528 ] Knut Anders Hatlen commented on DERBY-2191: --- numbitsset.v2 also looks good. I verified that the algorithm

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-30 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468573 ] Knut Anders Hatlen commented on DERBY-2191: --- Committed numbitstest.diff with revision 501368. Cleanup of

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-30 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468708 ] Bryan Pendleton commented on DERBY-2191: there is an asymmetry between grow(int) and shrink(int) Would it

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-29 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468230 ] Knut Anders Hatlen commented on DERBY-2191: --- I have looked at anysetbit.v1 and numbitsset.v1. I think the

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-29 Thread JIRA
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468242 ] Øystein Grøvlen commented on DERBY-2191: The javadoc for anySetBit says that it will return the bit number

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-29 Thread Dyre Tjeldvoll (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468263 ] Dyre Tjeldvoll commented on DERBY-2191: --- I agree that the javadoc comment for anySetBit should be improved,

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-29 Thread JIRA
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468277 ] Øystein Grøvlen commented on DERBY-2191: Dyre Tjeldvoll commented on DERBY-2191:

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-29 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468335 ] Knut Anders Hatlen commented on DERBY-2191: --- anysetbit.v2 looks good and the tests passed. Committed

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-26 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467750 ] Knut Anders Hatlen commented on DERBY-2191: --- Thank you for addressing my comments! bitopt.v2 looks good.

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-25 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467385 ] Knut Anders Hatlen commented on DERBY-2191: --- I think the rewrite of numBitsInLastByte() made the code

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-22 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466413 ] Knut Anders Hatlen commented on DERBY-2191: --- Thanks Dyre, bitops.v2 looks good! I only have one tiny

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-22 Thread Dyre Tjeldvoll (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466476 ] Dyre Tjeldvoll commented on DERBY-2191: --- Attached bitops.v3 which removes the unnecessary check for

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-22 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466545 ] Knut Anders Hatlen commented on DERBY-2191: --- bitops.v3 looks good the tests passed. Fixed a copy/paste

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-19 Thread Dyre Tjeldvoll (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466007 ] Dyre Tjeldvoll commented on DERBY-2191: --- Attached another patch (bitops.v1) which changes the bitset operator

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-19 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466020 ] Knut Anders Hatlen commented on DERBY-2191: --- This sounds like a very good change. Would it be good to call

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-19 Thread Dyre Tjeldvoll (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466044 ] Dyre Tjeldvoll commented on DERBY-2191: --- Actually I did run derbyall and suites.All with such ASSERTS in my

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-19 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466057 ] Knut Anders Hatlen commented on DERBY-2191: --- When I think about it, I don't think should matter what the

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-18 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465726 ] Knut Anders Hatlen commented on DERBY-2191: --- Committed cleanup2191.diff with revision 497003. Committed

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-17 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465418 ] Knut Anders Hatlen commented on DERBY-2191: --- When I looked at the previous patches, I noticed some other

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-17 Thread Dyre Tjeldvoll (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465425 ] Dyre Tjeldvoll commented on DERBY-2191: --- I have looked at Knut's patch and I think those changes are good and

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-17 Thread Dyre Tjeldvoll (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465449 ] Dyre Tjeldvoll commented on DERBY-2191: --- I've attached boundarycheck.v1 which adds argument checking to isSet,

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-16 Thread Dyre Tjeldvoll (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465197 ] Dyre Tjeldvoll commented on DERBY-2191: --- I'm looking at how boundary checking could be improved in this class,

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-16 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465266 ] Knut Anders Hatlen commented on DERBY-2191: --- If we have a check for the position, I think we should test

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-15 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464807 ] Knut Anders Hatlen commented on DERBY-2191: --- I have committed fbstst.v1.diff to trunk with revision

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-12 Thread Dyre Tjeldvoll (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464134 ] Dyre Tjeldvoll commented on DERBY-2191: --- I've attached a patch (fbstst.v1) that adds (a modified)

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-12 Thread Dyre Tjeldvoll (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464306 ] Dyre Tjeldvoll commented on DERBY-2191: --- I can confirm that the following methods aren't used and can be

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-09 Thread Dyre Tjeldvoll (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463216 ] Dyre Tjeldvoll commented on DERBY-2191: --- Thank you for looking at the results :) Some answers to your

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-08 Thread Dyre Tjeldvoll (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463039 ] Dyre Tjeldvoll commented on DERBY-2191: --- Here is a brief list of bugs/issues that was found while writing

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-08 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463156 ] Knut Anders Hatlen commented on DERBY-2191: --- Hi Dyre, Thanks for writing the test and posting the issues!

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2007-01-05 Thread Dyre Tjeldvoll (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462523 ] Dyre Tjeldvoll commented on DERBY-2191: --- While looking at this class I noticed that some methods and parts of

[jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet

2006-12-20 Thread Knut Anders Hatlen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2191?page=comments#action_12459900 ] Knut Anders Hatlen commented on DERBY-2191: --- Thanks Dyre. The patch looks good. Committed revision 489053. Cleanup of FormatableBitSet