[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470850
]
Knut Anders Hatlen commented on DERBY-2191:
---
Committed grow.diff with revision 504460.
Cleanup of
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470538
]
Dyre Tjeldvoll commented on DERBY-2191:
---
I think grow.diff should be committed.
Cleanup of FormatableBitSet
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469402
]
Knut Anders Hatlen commented on DERBY-2191:
---
Thanks Dyre! Committed shrink.v2 with revision 502185.
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469012
]
Dyre Tjeldvoll commented on DERBY-2191:
---
I think a single method makes a lot of sense, and I would seriously
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469059
]
Knut Anders Hatlen commented on DERBY-2191:
---
A couple of tiny comments to shrink.v1:
1) Javadoc for
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468528
]
Knut Anders Hatlen commented on DERBY-2191:
---
numbitsset.v2 also looks good. I verified that the algorithm
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468573
]
Knut Anders Hatlen commented on DERBY-2191:
---
Committed numbitstest.diff with revision 501368.
Cleanup of
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468708
]
Bryan Pendleton commented on DERBY-2191:
there is an asymmetry between grow(int) and shrink(int)
Would it
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468230
]
Knut Anders Hatlen commented on DERBY-2191:
---
I have looked at anysetbit.v1 and numbitsset.v1. I think the
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468242
]
Øystein Grøvlen commented on DERBY-2191:
The javadoc for anySetBit says that it will return the bit number
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468263
]
Dyre Tjeldvoll commented on DERBY-2191:
---
I agree that the javadoc comment for anySetBit should be improved,
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468277
]
Øystein Grøvlen commented on DERBY-2191:
Dyre Tjeldvoll commented on DERBY-2191:
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468335
]
Knut Anders Hatlen commented on DERBY-2191:
---
anysetbit.v2 looks good and the tests passed. Committed
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467750
]
Knut Anders Hatlen commented on DERBY-2191:
---
Thank you for addressing my comments! bitopt.v2 looks good.
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467385
]
Knut Anders Hatlen commented on DERBY-2191:
---
I think the rewrite of numBitsInLastByte() made the code
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466413
]
Knut Anders Hatlen commented on DERBY-2191:
---
Thanks Dyre, bitops.v2 looks good! I only have one tiny
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466476
]
Dyre Tjeldvoll commented on DERBY-2191:
---
Attached bitops.v3 which removes the unnecessary check for
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466545
]
Knut Anders Hatlen commented on DERBY-2191:
---
bitops.v3 looks good the tests passed. Fixed a copy/paste
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466007
]
Dyre Tjeldvoll commented on DERBY-2191:
---
Attached another patch (bitops.v1) which changes the bitset operator
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466020
]
Knut Anders Hatlen commented on DERBY-2191:
---
This sounds like a very good change. Would it be good to call
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466044
]
Dyre Tjeldvoll commented on DERBY-2191:
---
Actually I did run derbyall and suites.All with such ASSERTS in my
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466057
]
Knut Anders Hatlen commented on DERBY-2191:
---
When I think about it, I don't think should matter what the
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465726
]
Knut Anders Hatlen commented on DERBY-2191:
---
Committed cleanup2191.diff with revision 497003.
Committed
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465418
]
Knut Anders Hatlen commented on DERBY-2191:
---
When I looked at the previous patches, I noticed some other
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465425
]
Dyre Tjeldvoll commented on DERBY-2191:
---
I have looked at Knut's patch and I think those changes are good and
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465449
]
Dyre Tjeldvoll commented on DERBY-2191:
---
I've attached boundarycheck.v1 which adds argument checking to isSet,
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465197
]
Dyre Tjeldvoll commented on DERBY-2191:
---
I'm looking at how boundary checking could be improved in this class,
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465266
]
Knut Anders Hatlen commented on DERBY-2191:
---
If we have a check for the position, I think we should test
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464807
]
Knut Anders Hatlen commented on DERBY-2191:
---
I have committed fbstst.v1.diff to trunk with revision
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464134
]
Dyre Tjeldvoll commented on DERBY-2191:
---
I've attached a patch (fbstst.v1) that adds (a modified)
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464306
]
Dyre Tjeldvoll commented on DERBY-2191:
---
I can confirm that the following methods aren't used and can be
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463216
]
Dyre Tjeldvoll commented on DERBY-2191:
---
Thank you for looking at the results :)
Some answers to your
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463039
]
Dyre Tjeldvoll commented on DERBY-2191:
---
Here is a brief list of bugs/issues that was found while writing
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463156
]
Knut Anders Hatlen commented on DERBY-2191:
---
Hi Dyre,
Thanks for writing the test and posting the issues!
[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462523
]
Dyre Tjeldvoll commented on DERBY-2191:
---
While looking at this class I noticed that some methods and parts of
[
http://issues.apache.org/jira/browse/DERBY-2191?page=comments#action_12459900 ]
Knut Anders Hatlen commented on DERBY-2191:
---
Thanks Dyre. The patch looks good. Committed revision 489053.
Cleanup of FormatableBitSet
36 matches
Mail list logo