@Acelists
This Launchpad defect was raised on IMAP in the first place. Bugzilla 66763 is
a different thing.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't del
(In reply to :aceman from comment #144)
> See comment 142. If you see the problem on IMAP, please open a new bug. We
> knowingly fixed it only for POP3/Local accounts in this bug.
Ok, will do...
--
You received this bug notification because you are a member of Desktop
Packages, which is subscrib
I Don't know if this is the same old bug again (or something completely
new), but today I noticed that my TB 31.2.0 under RHEL6.6 (64-bit)
didn't delete an IMAP folder (In Exchange) if a folder with the same
name already existed in the Trash. It just silently didn't delete it,
until I renamed the s
See comment 142. If you see the problem on IMAP, please open a new bug.
We knowingly fixed it only for POP3/Local accounts in this bug.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs
** Changed in: thunderbird
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash already contains
Other types of accounts (other than "local" ones), e.g. IMAP need
testing and if they don't work then they need a bug.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Bug 125864 is open, Trash does not maintain deleted folder's hierarchy
location
Is anything else left that needs a new bug report?
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214
Yes, I am currently not working on the remaining parts. You can close
this for ease of tracking in which TB version this went.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
should we not do the rest in a followup bug? ref: [leave open after
checkin]
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash already c
*** Bug 998862 has been marked as a duplicate of this bug. ***
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash already contains a folde
*** Bug 987608 has been marked as a duplicate of this bug. ***
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash already contains a folde
https://hg.mozilla.org/comm-central/rev/3320c766cf5b
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash already contains a folder of the s
Why don't You allow double/multiple entries, may be
- add the delete timestamp
- add the different parent folders
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can
Created attachment 8390810
patch v7 - local folders
Thanks, converted the function to bool.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if
Comment on attachment 8390075
patch v6 - local folders
Review of attachment 8390075:
-
::: mailnews/base/util/nsMsgDBFolder.cpp
@@ +3843,5 @@
>
> +nsresult
> +nsMsgDBFolder::ConfirmAutoFolderRename(nsIMsgWindow *msgWindow,
> +
Created attachment 8390075
patch v6 - local folders
Oh, looks like this got all the reviews. Marking for superreview if one
is needed for the changed idl.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bug
Comment on attachment 8377817
patch v5
Review of attachment 8377817:
-
I'm good with:
A subfolder with the name '%$1S' already exists in the folder '%2$S'.
Would you like to move this folder using the new name '%3$S'?
(So sans the
(In reply to :aceman from comment #100)
> (In reply to :Irving Reid from comment #90)
> > (In reply to :aceman from comment #89)
> > > Can't bug 765926 cover maildir by itself?
> > As far as I know, maildir is mostly untested aside from what's discussed in
> > bug 765926. I don't know whether the l
(In reply to aceman from comment #125)
> I knew octal literals are deprecated so somehow I extended that to hex too.
> Thanks.
The only reason old-style octal literals are deprecated is because it's
too easy to confuse them with decimal literals e.g. 160 - 060 != 100.
Hex literals and new-style oc
Comment on attachment 8377817
patch v5
>+ rv = bundle->FormatStringFromName(MOZ_UTF16("confirmDuplicateFolderRename"),
>+formatStrings, 3,
>getter_Copies(confirmString));
If you'd used MOZ_ARRAY_LENGTH(formatStrings) it would have saved you the
trouble of cha
Comment on attachment 8377817
patch v5
Review of attachment 8377817:
-
Josiah, please see the discussion about the wording of the message and
decide on ui-r :)
--
You received this bug notification because you are a member of Deskt
Comment on attachment 8377817
patch v5
Review of attachment 8377817:
-
(In reply to n...@parkwaycc.co.uk from comment #124)
> (In reply to aceman from comment #123)
> > (In reply to comment #122)
> > > (From update of attachment 8374
(In reply to aceman from comment #123)
> (In reply to comment #122)
> > (From update of attachment 8374439)
> Is this issue really that important that we make tens of comments in such a
> long thread? It is not a perf critical path.
I'm after readability here, not perf, in particular I don't like
Created attachment 8377817
patch v5
> > > >+ try {
> > > >+root.copyFolderLocal(folderDeleted3, true, null, null);
> > > >+do_throw("copyFolderLocal() should have failed here due to user
> > > >prompt!");
> > > I'm not sure why you're trying to throw from inside this try block, but I
> >
(In reply to n...@parkwaycc.co.uk from comment #122)
> Comment on attachment 8374439
> WIP patch 4
>
> >+bool containsChild = true;
> >+uint32_t i;
> >+for (i = 1; ; i++) {
> >+ newFolderName.Assign(folderName);
> >+ if (i > 1) {
> >+// This could be localizable but T
Comment on attachment 8374439
WIP patch 4
>+bool containsChild = true;
>+uint32_t i;
>+for (i = 1; ; i++) {
>+ newFolderName.Assign(folderName);
>+ if (i > 1) {
>+// This could be localizable but Toolkit is fine without it, see
>+// mozilla/toolkit/content/con
(In reply to :Irving Reid from comment #120)
> Does this message come up with folder copies and moves, or only with moves?
> If it's only move, I suggest changing the wording to:
>
> A folder named %1%S already exists in %2$S. Do you wish to move the folder
> to %2$S / %3$S?
In the change to nsLo
Comment on attachment 8374439
WIP patch 4
Review of attachment 8374439:
-
::: mail/locales/en-US/chrome/messenger/messenger.properties
@@ +58,5 @@
> sendingUnsent=Sending Unsent Messages
>
> folderExists=A folder with that name a
Created attachment 8374439
WIP patch 4
Thanks, addressed all comments and added a new test segment to check for
the prompt when moving duplicate folder outside Trash.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
*** Bug 305728 has been marked as a duplicate of this bug. ***
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash already contains a folde
Comment on attachment 8371072
WIP patch 3
Review of attachment 8371072:
-
Nice test.
::: mailnews/local/src/nsLocalMailFolder.cpp
@@ +1723,5 @@
> return NS_MSG_ERROR_COPY_FOLDER_ABORTED;
> }
>}
> +
> + nsAutoStrin
(In reply to Ulf Zibis from comment #114)
> (In reply to Josiah Bruner [:JosiahOne] from comment #111)
> > No. The idea here is very similar to the common "priming read" concept
> > taught in introductory CS courses.
> In advanced CS practice I learned: No code duplicates, because if there
> comes
(In reply to n...@parkwaycc.co.uk from comment #107)
> Comment on attachment 8371072
> WIP patch 3
>
> >+newFolderName.Assign(folderName);
> >+bool containsChild = true;
> >+uint32_t i = 1;
> >+while (containsChild) {
> >+ rv = ContainsChildNamed(newFolderName, &containsChild)
(In reply to Ulf Zibis from comment #108)
> (In reply to n...@parkwaycc.co.uk from comment #107)
>
> Hi, why not using for statements:
>
> > >+newFolderName.Assign(folderName);
> > >+bool containsChild = true;
> > >+for (uint32_t i=2; ; i++) {
> > >+ rv = ContainsChildNamed(newFo
No. The idea here is very similar to the common "priming read" concept
taught in introductory CS courses. Following such a pattern the code
here should be:
newFolderName.Assign(folderName);
bool containsChild = true;
int counter = 2;
//Priming Read
rv = ContainsChildNamed(newFolderName, &contains
(In reply to n...@parkwaycc.co.uk from comment #107)
Hi, why not using for statements:
> >+newFolderName.Assign(folderName);
> >+bool containsChild = true;
> >+for (uint32_t i=2; ; i++) {
> >+ rv = ContainsChildNamed(newFolderName, &containsChild);
> >+ NS_ENSURE_SUCCESS(rv,
Little sophisticated:
>+newFolderName.Assign(folderName);
>+for (uint32_t i=2, containsChild; ; i++) {
>+ rv = ContainsChildNamed(newFolderName, &containsChild);
>+ NS_ENSURE_SUCCESS(rv, rv);
>+ if (!containsChild)
>+break;
>+ // This could be localizable but To
IMHO:
1. while(condition) is only appropriate, if the condition is determined outside
the loop.
2. define variables only in the scope, where they are used.
3. for(...) is appropriate if there is a counting variable, which is only used
inside the loop
4. If you look closer, in your code snippet yo
Comment on attachment 8371072
WIP patch 3
>+ nsAutoString newFolderName(EmptyString());
[Strings default to empty...]
>+while (containsChild) {
>+ rv = ContainsChildNamed(newFolderName, &containsChild);
>+ NS_ENSURE_SUCCESS(rv, rv);
>+ if (!containsChild)
>+break;
[Wei
Comment on attachment 8371072
WIP patch 3
>+newFolderName.Assign(folderName);
>+bool containsChild = true;
>+uint32_t i = 1;
>+while (containsChild) {
>+ rv = ContainsChildNamed(newFolderName, &containsChild);
>+ NS_ENSURE_SUCCESS(rv, rv);
>+ if (!containsChild)
>+
Err. Except in that while statement there should be a:
"counter++"
line right before we read new data.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete
(In reply to Josiah Bruner [:JosiahOne] from comment #111)
> No. The idea here is very similar to the common "priming read" concept
> taught in introductory CS courses.
In advanced CS practice I learned: No code duplicates, because if there comes a
change along, one of the duplicates could be over
(In reply to Mark Banner (:standard8) from comment #102)
> Quick Q: Has someone tested what happens in the undo case? Does the folder
> get named to what it was previously.
Not sure what I am doing wrong but I get no option to Undo after
drag-and-dropping a folder. Undo is disabled in Edit menu. I
(In reply to Mark Banner (:standard8) from comment #102)
> Quick Q: Has someone tested what happens in the undo case? Does the folder
> get named to what it was previously.
I'll check that :)
We'd like to know from you if you have any idea about comment 88, 90 and
100.
--
You received this bug
(In reply to :Irving Reid from comment #90)
> (In reply to :aceman from comment #89)
> > Can't bug 765926 cover maildir by itself?
> As far as I know, maildir is mostly untested aside from what's discussed in
> bug 765926. I don't know whether the long term plan is to run the entire
> suite twice,
Comment on attachment 8370331
WIP patch 2
Review of attachment 8370331:
-
I'm OK with this approach. I'd like to see test cases for both a single
folder and a nested folder - for example:
make folder A
move A to trash
make new A
mov
(In reply to aceman from comment #81)
> Neil is this still a wrong place to do it and can you propose a better one
> that David Bienvenu was talking about?
Well, as I see it there are two options:
1. Make moving a folder automatically rename if the destination already exists,
but allow copies to c
(In reply to :aceman from comment #93)
> (In reply to n...@parkwaycc.co.uk from comment #92)
> > Well, as I see it there are two options:
> > 1. Make moving a folder automatically rename if the destination already
> > exists, but allow copies to continue to merge the folders. (This was a
> > lifesa
(In reply to n...@parkwaycc.co.uk from comment #92)
> Well, as I see it there are two options:
> 1. Make moving a folder automatically rename if the destination already
> exists, but allow copies to continue to merge the folders. (This was a
> lifesaver for me when I was moving mail between two acc
Created attachment 8371072
WIP patch 3
This adds the requested test (as xpcshell so Seamonkey gets it too).
Also covers all the feedback from Neil, Irving, Josiah and Ulf.
When moving a folder outside Trash, it asks about the rename. It does not ask
when moving to Trash = deleting. I can't distin
Comment on attachment 8371072
WIP patch 3
Quick Q: Has someone tested what happens in the undo case? Does the
folder get named to what it was previously.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs
(In reply to :Irving Reid from comment #88)
> I'm OK with this approach. I'd like to see test cases for both a single
> folder and a nested folder - for example:
>
I'll try.
> We don't need to test all those combinations for every message store type,
> but we should at least test the copyFolder(.
(In reply to Josiah Bruner [:JosiahOne] from comment #82)
> So this seems like a fine approach to me. I think that we should call each
> folder "folder(x)" instead of "folder-x", as it more clearly indicates
> duplicates though. People may already have folders called Name-Subname or
> the like, so
Comment on attachment 8370331
WIP patch 2
>+ PRUint32 i = 2;
>+ nsAutoString newFolderNameUnderTrash(folderName);
>+ while (1) {
>+rv = CheckIfFolderExists(newFolderNameUnderTrash, this, NULL);
>+if (rv == NS_MSG_FOLDER_EXISTS) {
>+ newFolderNameUnderTrash.Assign(folderName);
>+
(In reply to Mark Banner (:standard8) from comment #102)
> Quick Q: Has someone tested what happens in the undo case? Does the folder
> get named to what it was previously.
Great Q !
I too had this Q in my synapses last night before falling into dreams.
--
You received this bug notification beca
(In reply to aceman from comment #89)
> (In reply to Irving Reid from comment #88)
> > I don't think this needs to be localizable.
> I think it should be localizable if it is not complicated.
It doesn't need to be localisable (compare uniqueFile from contentAreaUtils.js).
--
You received this bug
(In reply to :aceman from comment #99)
> Josiah does not propose to differ. The last patch does rename to (x).
Great!
> I think user should never move to Trash as temporary measure.
Well, You'll never know, what user does, ...and there is the other reason
mentioned above. Additionally it looks mo
(In reply to aceman from comment #95)
> In nsMsgLocalMailFolder::CopyFolder it seems when we are moving folder then
> it calls CopyFolderLocal (which I am touching). If we are copying then it
> calls CopyFolderAcrossServer (which I do not touch). So if
> CopyFolderAcrossServer merges, then all is f
(In reply to :aceman from comment #89)
> > We don't need to test all those combinations for every message store type,
> > but we should at least test the copyFolder(...aNewName) parameter works once
> > on each store type.
> Store type as in mbox and maildir? Do we actually have tests differentiat
(In reply to Ulf Zibis from comment #97)
> (In reply to Josiah Bruner [:JosiahOne] from comment #82)
> > So this seems like a fine approach to me. I think that we should call each
> > folder "folder(x)" instead of "folder-x", as it more clearly indicates
> > duplicates though. People may already ha
(In reply to Ulf Zibis from comment #86)
> (In reply to :aceman from comment #84)
> > I wouldn't try to implement merging in this bug (it is much harder).
>
> What's the problem, moving a (bunch of) message(s) to another folder is
> already implemented and the suggested dialogue is well known from
Yeah, for trash moving automatically is fine.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash already contains a folder of the same
n
(In reply to :aceman from comment #84)
> I wouldn't try to implement merging in this bug (it is much harder).
What's the problem, moving a (bunch of) message(s) to another folder is
already implemented and the suggested dialogue is well known from file
managers. I just mean adding, not merging wit
To avoid future bug reports I would suggest changing the existing Dialogue to:
A folder with name "Child" is already existing in folder "Parent". Do you want
to rename it to "Child(2)" or fill it's content into existing folder "Child"?
[Yes] [No] [Cancel]
--
You received this bug notification be
I wouldn't try to implement merging in this bug (it is much harder). But
I think I could make that dialog with Yes/Cancel options meaning
Rename/Cancel. For Trash, the rename would happen without question. If
UI guys like that :)
--
You received this bug notification because you are a member of D
Created attachment 8370331
WIP patch 2
This is an updated version that implements the atomic move of the folder
to the final destination, as requested.
The search for a new free folder name is not inside the block where we
check if this move is to the Trash folder. That means this automatic
renam
Comment on attachment 8370331
WIP patch 2
Review of attachment 8370331:
-
So this seems like a fine approach to me. I think that we should call
each folder "folder(x)" instead of "folder-x", as it more clearly
indicates duplicates th
*** Bug 967521 has been marked as a duplicate of this bug. ***
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash already contains a folde
The fact that this still hasn't been resolved in the public release
after almost 15 years is, quite frankly, disgusting.
These kind of amateurish bugs and the utter inability of anyone to fix
them years, or in this case, DECADES later is exactly why nobody takes
open-source software seriously.
Re
I agree with David's remark in comment 70, that we should not rename the
folder before copying - we should just copy it directly into the new
name. I don't think we need to do anything complicated to deal with
duplicate names; appending a number is probably enough.
I don't have any insight into wh
(In reply to :aceman from comment #71)
> Thanks David. If you find the right place I can look at it again. Otherwise
> it is again beyond me.
ref comment 70
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://b
The folder name is not a problem. There are technical issues with the
implementation so we are waiting on David Bienvenu.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title
It might be better use aliases for folders (and files) in the trash I think.
And add a file with pair of data: alias:real_name.
I meen like this:
In the TB window:
Trash
Folder
Folder
File1
Folder
File2
File1
On the FS:
Trash
UfatVuHy
tynkEejRyp
3jofmamOo
HajbymFo
faydfehacs
Maybe you could rename Folder-1 back to Folder, if Folder would be
deleted from trash.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash
can You please fix it with Your favorite solution !
this issue is already very very old without any progress.
reported Jan-2001
and if there is time it can be udated later ?
: if already exists in trash it could also be moved to
- trash/1/foldername
- trash/2/foldername
so name must not be touc
Comment on attachment 609152
proof of concept patch
This seems like reasonable behaviour to me. I agree with Magnus that
I'ld prefer it to end in "-1", "-2", etc… (Sorry, Ulf. :)
(As a side note, OS X, when you delete the same thing twice, names the
second "filename.txt" as "filename 14:59:27 .
Thanks David. If you find the right place I can look at it again.
Otherwise it is again beyond me.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a fold
Comment on attachment 609152
proof of concept patch
thx for the patch - I think we really want to do this, but there are
issues with the patch.
I don't like the rename of the src folder before the move - that might
fail as well, if the name exists in the source folder's directory. I'd
prefer to m
** Changed in: thunderbird
Status: Confirmed => In Progress
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash already contains a f
(In reply to :aceman from comment #67)
> For those interested, Outlook 2007 renames the folder to 'Folder1' (no
> space) if 'Folder' is already existing. At least in the SK language version.
I would say: "Bug" in MS's corporate Identity ;-)
Imagine, someone just has Folder1. It would result in Fol
Yes, that does really happen :) Delete 'Folder', 'Folder', and
'Folder1'.
I do not want that but I do not care much. I implement whatever the UI
guys decide. I just provide options :)
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thund
For those interested, Outlook 2007 renames the folder to 'Folder1' (no
space) if 'Folder' is already existing. At least in the SK language
version.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launch
(In reply to :aceman from comment #65)
> (In reply to Magnus Melin from comment #64)
> > I'd too (like comment 8) prefer a folder-N, not folderN naming scheme.
>
> The dash in comment 8 can be probably added trivially if we decide on it.
> The main point from comment 8 is that the original patch t
> - it doesn't have the alert dialog informing the user the folder was
renamed.
That doesn't sound to me like something we'd want.
I'd too (like comment 8) prefer a folder-N, not folderN naming scheme.
--
You received this bug notification because you are a member of Desktop
Packages, which is
(In reply to Magnus Melin from comment #64)
> > - it doesn't have the alert dialog informing the user the folder was
> > renamed.
> That doesn't sound to me like something we'd want.
It would be easier without it, but let's ask bwinton too.
> I'd too (like comment 8) prefer a folder-N, not folde
Created attachment 609152
proof of concept patch
I managed to strip the patch down and update it for the current architecture.
I need feedback from David Bienvenu if this is a good direction and reaction to
the points below.
What it does:
- it does work to fix the problem as reported.
- if the f
It seems the file has changed too much. I have no idea where to put this
code. The flow is too different now.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't de
*** Bug 712912 has been marked as a duplicate of this bug. ***
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash already contains a folde
Would comment 52 be an acceptable solution for everyone?
It seems the old patch is attempting to do that.
I could try to pick it up.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/21
(In reply to :aceman from comment #59)
> Would comment 52 be an acceptable solution for everyone?
> It seems the old patch is attempting to do that.
> I could try to pick it up.
Yes, that's fine, similar to what windows file system explorer does.
That would be great if you could fix this!
--
You
*** Bug 708625 has been marked as a duplicate of this bug. ***
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash already contains a folde
91 matches
Mail list logo
