Re: Review Request 14972: ACCUMULO-1009 - add use of SSL for thrift comms

2013-11-05 Thread keith
> On Nov. 1, 2013, 9:37 p.m., Christopher Tubbs wrote: > > core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java, > > line 194 > > > > > > Can we make this method signature, and others like it, tak

Re: Review Request 8559: Add Accumulo support to Sqoop

2013-11-05 Thread Philip Grim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8559/ --- (Updated Nov. 5, 2013, 9:11 p.m.) Review request for accumulo, Sqoop and Jarek C

Re: Review Request 8559: Add Accumulo support to Sqoop

2013-11-05 Thread Sean Busbey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8559/#review28223 --- looks good. src/java/org/apache/sqoop/accumulo/ToStringMutationTran

Re: Review Request 8559: Add Accumulo support to Sqoop

2013-11-05 Thread Philip Grim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8559/ --- (Updated Nov. 5, 2013, 8:13 p.m.) Review request for accumulo, Sqoop and Jarek C

Re: Review Request 8559: Add Accumulo support to Sqoop

2013-11-05 Thread Philip Grim
> On Nov. 5, 2013, 6:11 a.m., Sean Busbey wrote: > > src/test/org/apache/sqoop/accumulo/AccumuloTestCase.java, lines 156-163 > > > > > > This will make sure we only attempt setupCluster once concurrently, but > > it wo

Re: Review Request 14972: ACCUMULO-1009 - add use of SSL for thrift comms

2013-11-05 Thread Michael Berman
> On Nov. 1, 2013, 9:37 p.m., Christopher Tubbs wrote: > > core/src/test/java/org/apache/accumulo/core/conf/ClientConfigurationTest.java, > > line 38 > > > > > > Should test expected config before and after serializati

Re: Review Request 14972: ACCUMULO-1009 - add use of SSL for thrift comms

2013-11-05 Thread Michael Berman
> On Nov. 1, 2013, 9:37 p.m., Christopher Tubbs wrote: > > core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java, lines > > 170-171 > > > > > > I believe that jcommander has a built-in way of getting propert

Re: Review Request 15210: ACCUMULO-1658 Review

2013-11-05 Thread Ryan Fishel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15210/ --- (Updated Nov. 5, 2013, 6:28 p.m.) Review request for accumulo. Changes --

Re: MultipleInputs with AccumuloInputFormat

2013-11-05 Thread Josh Elser
Heh, ok. I'm currently working through a bit of a prototype to see how it works. I'm not a mapred/mapreduce expert, but I *think* I have an approach that will work. Keep an eye out for a Jira -- would love feedback. On 11/5/13, 12:13 PM, Kevin Faro wrote: I recently looked into that and came

Re: MultipleInputs with AccumuloInputFormat

2013-11-05 Thread Kevin Faro
I recently looked into that and came to the same realization. I ended up writing a new input format that did the cartesian product of two tables. But to do that I had to store values for the left configuration and right configuration and then copy over whichever config settings I wanted to use fo

Re: 1.5.1?

2013-11-05 Thread Josh Elser
Cool. Let's keep that in mind then as we test 1.6.0. As we get into the actual testing phase, I'll try to get my computer provisioned up to run at least 2 tservers and see if I can get some testing done concurrently. Maybe some bugs will shake out the other way (1.5.1->1.6.0) as well. On 11/

Re: 1.5.1?

2013-11-05 Thread Keith Turner
On Tue, Nov 5, 2013 at 8:44 AM, John Vines wrote: > I agree with Mr. Busbey > Me too. In past 1.X.0 release testing we have found a few bugs that exist in earlier release that are worth fixing. > > Sent from my phone, please pardon the typos and brevity. > On Nov 5, 2013 1:16 AM, "Sean Busbey

MultipleInputs with AccumuloInputFormat

2013-11-05 Thread Josh Elser
In executing some MapReduce over Accumulo with the AccumuloInputFormat, I came to the realization that AIF fundamentally doesn't work with concepts like MultipleInputs in Hadoop (http://hadoop.apache.org/docs/current/api/org/apache/hadoop/mapreduce/lib/input/MultipleInputs.html). Given that you

Re: 1.5.1?

2013-11-05 Thread John Vines
I agree with Mr. Busbey Sent from my phone, please pardon the typos and brevity. On Nov 5, 2013 1:16 AM, "Sean Busbey" wrote: > On Mon, Nov 4, 2013 at 11:03 PM, Josh Elser wrote: > > > I've perused over the closed tickets a couple of times now. Nothing huge > > has jumped out at me, but, given