Re: Contribute Examples/Exercises

2014-11-14 Thread Keith Turner
On Wed, Nov 12, 2014 at 4:52 PM, Corey Nolet wrote: > Josh, > > > My worry with a contrib module is that, historically, code which goes > moves to a contrib is just one step away from the grave. > > You do have a good point. My hope was that this could be the beginning of > our changing history s

Re: Contribute Examples/Exercises

2014-11-14 Thread Mike Drob
+1 On Fri, Nov 14, 2014 at 10:16 AM, Keith Turner wrote: > On Wed, Nov 12, 2014 at 4:52 PM, Corey Nolet wrote: > > > Josh, > > > > > My worry with a contrib module is that, historically, code which goes > > moves to a contrib is just one step away from the grave. > > > > You do have a good poin

Re: Contribute Examples/Exercises

2014-11-14 Thread David Medinets
+1 On Nov 14, 2014 11:18 AM, "Keith Turner" wrote: > On Wed, Nov 12, 2014 at 4:52 PM, Corey Nolet wrote: > > > Josh, > > > > > My worry with a contrib module is that, historically, code which goes > > moves to a contrib is just one step away from the grave. > > > > You do have a good point. My h

Re: Contribute Examples/Exercises

2014-11-14 Thread Josh Elser
Since there's an opinion to create an examples repo instead of keeping them in the base project, I'm -0 as long we CI set up so that they don't go silently into the night as I previously state as a concern. Some general questions for actually doing this: do we schedule the move of the classes

Re: Contribute Examples/Exercises

2014-11-14 Thread Mike Drob
+1 to setting up a Jenkins Job. On Fri, Nov 14, 2014 at 12:14 PM, Josh Elser wrote: > Since there's an opinion to create an examples repo instead of keeping > them in the base project, I'm -0 as long we CI set up so that they don't go > silently into the night as I previously state as a concern.

Re: Contribute Examples/Exercises

2014-11-14 Thread Corey Nolet
Mike & David, Are you +1 for contributing the examples or +1 for moving the examples out into separate repos? On Fri, Nov 14, 2014 at 12:52 PM, David Medinets wrote: > +1 > On Nov 14, 2014 11:18 AM, "Keith Turner" wrote: > > > On Wed, Nov 12, 2014 at 4:52 PM, Corey Nolet wrote: > > > > > Josh

Re: Contribute Examples/Exercises

2014-11-14 Thread Keith Turner
We can try using git fitler-branch to create the repo and preserve history. On Fri, Nov 14, 2014 at 1:14 PM, Josh Elser wrote: > Since there's an opinion to create an examples repo instead of keeping > them in the base project, I'm -0 as long we CI set up so that they don't go > silently into th

Re: Contribute Examples/Exercises

2014-11-14 Thread Mike Drob
I am +1 for setting up a Jenkins Job, which implies a separate repository, I think. On Fri, Nov 14, 2014 at 12:19 PM, Corey Nolet wrote: > Mike & David, > > Are you +1 for contributing the examples or +1 for moving the examples out > into separate repos? > > On Fri, Nov 14, 2014 at 12:52 PM, Dav

Re: Contribute Examples/Exercises

2014-11-14 Thread Mike Drob
Having done this in the past, I have a hard time suggesting this approach. As a single module, the code probably won't compile for most of the history that we preserve, so it's not like we'd be able to efficiently bisect or take advantage of the history. On Fri, Nov 14, 2014 at 12:29 PM, Keith Tur

Re: Contribute Examples/Exercises

2014-11-14 Thread Keith Turner
On Fri, Nov 14, 2014 at 1:57 PM, Mike Drob wrote: > Having done this in the past, I have a hard time suggesting this approach. > never tried it. Was there anything else you did not like about it (other than being useless for bisect)? The history would still be in accumulo repo. > As a single

Re: Contribute Examples/Exercises

2014-11-14 Thread Josh Elser
Wasn't the whole discussion about making existing and future examples contribs? (Which itself implies its own repo) Did I miss something? On Nov 14, 2014 10:56 AM, "Mike Drob" wrote: > I am +1 for setting up a Jenkins Job, which implies a separate repository, > I think. > > On Fri, Nov 14, 2014