Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/56#issuecomment-161166719
So it doesn't look like I just ignored Christopher -- we were talking in
IRC about his recommendations. He opened up joshelser/accumulo#1, but said he
can just merge
Github user asfgit closed the pull request at:
https://github.com/apache/accumulo/pull/56
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46361599
--- Diff: proxy/src/main/java/org/apache/accumulo/proxy/Proxy.java ---
@@ -135,7 +136,8 @@ public static TServer createProxyServer(Class api,
Class implemen
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46360216
--- Diff: proxy/src/main/java/org/apache/accumulo/proxy/Proxy.java ---
@@ -135,7 +136,8 @@ public static TServer createProxyServer(Class api,
Class implemen
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46359623
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java ---
@@ -3159,7 +3159,8 @@ private void
returnMasterConnection(MasterCl
Gotcha. Billie just noted in IRC that, when Accumulo has custom RPC code
a long time ago, Keith's experiment showed Thrift 500x faster. That's
probably how we got started.
Since then, I think it's just been a good solution that works well in
the end (development work can be hard). The lack of
I'm not suggesting that we replace Thrift (nor am I signing up to do it), just
asking for the basis of the decision and if its time to revisit. I'm totally ok
with a 'no' answer.
- Original Message -
From: "Josh Elser"
To: dev@accumulo.apache.org
Sent: Tuesday, December 1, 2015 2:36
At a glance, it looks like this doesn't provide any transport, just the
marshaling of data. I really don't want to own that logic (for example,
I've seen the thousands of lines of code in HBase just for setting up
their RPC server).
John R. Frank wrote:
It might be worth considering CBOR htt
To play devil's advocate: I'm not sure if it's quite that simple. For
example, Avro has been around since 2009, but I don't think it'd be fair
to consider Avro circa 2009 to Avro circa 2015.
David Medinets wrote:
What new protocols have been introduced since the Thrift decisions? Can
someone p
IMO, Thrift provides a lot out of the box, and, all things considered,
reduces our complexity greatly. For example:
* THsHaServer is great for our execution model
* We can inherit things like SSL and SASL (Kerberos)
* An _implemented_ RPC service (stuff like Hadoop RPC and Protobuf just
provide
(replying to myself since this was a common sentiment)
I want to be clear that I am most definitely _not_ advocating that we
rip out Thrift. I am still extremely far removed from that decision.
My question was more how can we make Thrift work better for us, than
look for a replacement.
Josh
Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/56#issuecomment-161070257
Ok, lots of good stuff contained in 22751b7a.
* Lots of comments
* Lots of unit tests for RpcWrapper (includes some moving around in
RpcWrapper to ease te
It might be worth considering CBOR http://cbor.io/
jrf
What new protocols have been introduced since the Thrift decisions? Can
someone provide pros and cons for that limited set of protocols?
On Tue, Dec 1, 2015 at 1:02 PM, wrote:
>
> What was it about Thrift that drove us to use it? Was it the bindings for
> multiple languages? Should this decision
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46318304
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public class
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46318262
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public cl
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46318211
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public class
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46317875
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public cl
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46317613
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public class
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46317646
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public cl
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46317550
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public cl
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46317203
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public cl
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46316775
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public cl
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46314927
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public class
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46314596
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public class
What was it about Thrift that drove us to use it? Was it the bindings for
multiple languages? Should this decision be revisited?
- Original Message -
From: "Josh Elser"
To: "dev"
Sent: Tuesday, December 1, 2015 12:49:26 PM
Subject: State of our RPCs
Hi --
My adventures in Thri
Hi --
My adventures in Thrift as a part of ACCUMULO-4065 are finally coming to
a close, it seems. The briefest summary I can give is that our hack to
work around an 0.9.0->0.9.1 compatibility issue ended up creating a bug
in a very obtuse case (when a server answering a oneway Thrift call
thr
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46310515
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public class
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46310448
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public class
Github user keith-turner commented on the pull request:
https://github.com/apache/accumulo/pull/56#issuecomment-161025777
> WDYT?
I just made two more comments. Other than those I am finished looking at
the changes.
---
If your project is set up for it, you can reply to thi
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46302133
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public cl
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46302099
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public cl
Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/56#issuecomment-161022208
I need to add some unit tests for the new code added to RpcWrapper, but
then I think this is ready to go.
WDYT?
---
If your project is set up for it, you ca
Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/56#issuecomment-161022097
tl;dr Yes, the connection is unusable by the client, but the Accumulo code
should retry that implicitly.
Expanded: After running my hacked-together `fastHalt`
Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/56#issuecomment-161019262
> I think it will all work out ok, but I was just curious what would
happen in practice.
Ahh, I understand now. Your assessment seems accurate. Let me try to
Github user keith-turner commented on the pull request:
https://github.com/apache/accumulo/pull/56#issuecomment-161013553
> Now? Or with these changes?
With these changes.
Based on reading @ctubbsii [comment on
THRIFT-1805](https://issues.apache.org/jira/browse/THRI
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46295564
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public cl
Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/56#issuecomment-161006801
> Wonder what happens if a one-way throws a runtime exception and then the
connection is put back into the pool
Now? Or with these changes? With these changes
Github user keith-turner commented on the pull request:
https://github.com/apache/accumulo/pull/56#issuecomment-161006310
Wonder what happens if a one-way throws a runtime exception and then the
connection is put back into the pool. My expectation is that a closing
connection would
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46294283
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public class
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46292326
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public cl
Github user keith-turner commented on the pull request:
https://github.com/apache/accumulo/pull/56#issuecomment-161001917
I think it would be useful to add some comments to the code pointing to
ACCUMULO-4065 (and maybe THRIFT-1805 ACCUMULO-2950). Looking at this code by
itself someon
Github user keith-turner commented on the pull request:
https://github.com/apache/accumulo/pull/54#issuecomment-160989204
For reference. The code @joshelser was talking about [Thrift 0.9.1
ProcessFunction line
45](https://github.com/apache/thrift/blob/0.9.1/lib/java/src/org/apache/
43 matches
Mail list logo
