Re: [DISCUSS] Time for a 1.8.0 release?

2016-05-24 Thread Christopher
On Sun, May 22, 2016 at 9:42 PM Michael Wall wrote: > After last weeks discussion with Josh, Christopher and others at the > Accumulo Working Day, I am going to shepherd the 1.8 release. First step > is to create a release candidate? Before I do that, are there any tickets > that need to get in

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

2016-05-24 Thread joshelser
Github user joshelser commented on the pull request: https://github.com/apache/accumulo/pull/100#issuecomment-221417030 Wonderful, thanks for running it through its paces. On May 24, 2016 1:43 PM, "Keith Turner" wrote: > @joshelser I ran some

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

2016-05-24 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/100#discussion_r64483814 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/KeyShortener.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software F

Re: Jira/GitHub spam reduction thoughts

2016-05-24 Thread Christopher
On Tue, May 24, 2016 at 10:46 AM Billie Rinaldi wrote: > On Mon, May 23, 2016 at 9:43 PM, Christopher wrote: > > > Okay, so after all that work I did on > > https://issues.apache.org/jira/browse/INFRA-11675 , we were able to get > > the > > duplicate messages on the notifications list to stop, w

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

2016-05-24 Thread keith-turner
Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/100#issuecomment-221384261 @joshelser I ran some performance test and did not really see a difference. Below I compacted the file I have been testing with 3 times using the changes in thi

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

2016-05-24 Thread keith-turner
Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/100#discussion_r64441677 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/KeyShortener.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Softwar

[GitHub] accumulo pull request: ACCUMULO-4310 - User manual should mention ...

2016-05-24 Thread keith-turner
Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/99#issuecomment-221299073 @mikewalch what branch did you intend this to go in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

Re: Jira/GitHub spam reduction thoughts

2016-05-24 Thread Billie Rinaldi
On Mon, May 23, 2016 at 9:43 PM, Christopher wrote: > Okay, so after all that work I did on > https://issues.apache.org/jira/browse/INFRA-11675 , we were able to get > the > duplicate messages on the notifications list to stop, which came from > comments on GitHub pull requests which also trigger

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

2016-05-24 Thread keith-turner
Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/100#discussion_r64400847 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java --- @@ -386,13 +392,23 @@ public void flushIfNeeded() throws IOException {

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

2016-05-24 Thread keith-turner
Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/100#discussion_r64400366 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java --- @@ -89,6 +90,10 @@ private RFile() {} static final int RINDEX_VE

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

2016-05-24 Thread keith-turner
Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/100#issuecomment-221287151 > but overall it looks good. I assume you didn't see any performance degradation with this change? I was thinking about that, but did not test it. Wante

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

2016-05-24 Thread keith-turner
Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/100#issuecomment-221286131 > @keith-turner this is merging into master but I assume you want this in 1.8. Will this be back ported to 1.7 and 1.6 also? I meant to make the PR agains

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

2016-05-24 Thread mjwall
Github user mjwall commented on the pull request: https://github.com/apache/accumulo/pull/100#issuecomment-221248395 @keith-turner this is merging into master but I assume you want this in 1.8. Will this be back ported to 1.7 and 1.6 also? --- If your project is set up for it, you c