[GitHub] accumulo issue #255: ACCUMULO-4365: Fix trace test in ShellServerIT

2017-05-02 Thread billierinaldi
Github user billierinaldi commented on the issue: https://github.com/apache/accumulo/pull/255 I figure there are two possibilities, 1) the sendMutations span isn't always created, which would be bad, or 2) the span is created, but it's dropped sometimes because it's of length 0ms. It

[GitHub] accumulo issue #255: ACCUMULO-4365: Fix trace test in ShellServerIT

2017-05-02 Thread milleruntime
Github user milleruntime commented on the issue: https://github.com/apache/accumulo/pull/255 Thanks @billierinaldi good idea with the tracer.span.min.ms parameter. I will give a try see what we get! --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] accumulo issue #255: ACCUMULO-4365: Fix trace test in ShellServerIT

2017-05-02 Thread milleruntime
Github user milleruntime commented on the issue: https://github.com/apache/accumulo/pull/255 I think we got it! Looking good with 22c9481 I will run the IT a few more times just to make sure this is squashed. --- If your project is set up for it, you can reply to this email

[GitHub] accumulo issue #254: [ACCUMULO-4506] Add a timeout to the replication task

2017-05-02 Thread adamjshook
Github user adamjshook commented on the issue: https://github.com/apache/accumulo/pull/254 @joshelser Back at you. I think I managed to scrape together a test that I am happy with. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] accumulo pull request #254: [ACCUMULO-4506] Add a timeout to the replication...

2017-05-02 Thread adamjshook
Github user adamjshook commented on a diff in the pull request: https://github.com/apache/accumulo/pull/254#discussion_r114381575 --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java --- @@ -416,6 +444,12 @@ protected Status rep

[GitHub] accumulo pull request #254: [ACCUMULO-4506] Add a timeout to the replication...

2017-05-02 Thread keith-turner
Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/254#discussion_r114387450 --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java --- @@ -416,6 +444,12 @@ protected Status r

[GitHub] accumulo pull request #254: [ACCUMULO-4506] Add a timeout to the replication...

2017-05-02 Thread adamjshook
Github user adamjshook commented on a diff in the pull request: https://github.com/apache/accumulo/pull/254#discussion_r114387702 --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java --- @@ -416,6 +444,12 @@ protected Status rep

[GitHub] accumulo issue #255: ACCUMULO-4365: Fix trace test in ShellServerIT

2017-05-02 Thread milleruntime
Github user milleruntime commented on the issue: https://github.com/apache/accumulo/pull/255 With the span min set to 0, I am consistently seeing the Test pass and the output: 0+2268 master@0.0.0.0 org.apache.accumulo.core.client.impl.TabletServerBatchWriter$Muta

[GitHub] accumulo pull request #254: [ACCUMULO-4506] Add a timeout to the replication...

2017-05-02 Thread adamjshook
Github user adamjshook commented on a diff in the pull request: https://github.com/apache/accumulo/pull/254#discussion_r114392548 --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java --- @@ -416,6 +444,12 @@ protected Status rep

[GitHub] accumulo issue #255: ACCUMULO-4365: Fix trace test in ShellServerIT

2017-05-02 Thread milleruntime
Github user milleruntime commented on the issue: https://github.com/apache/accumulo/pull/255 Merged into 1.7, 1.8 and master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] accumulo pull request #255: ACCUMULO-4365: Fix trace test in ShellServerIT

2017-05-02 Thread milleruntime
Github user milleruntime closed the pull request at: https://github.com/apache/accumulo/pull/255 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature