Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/273#discussion_r124147278
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/security/tokens/KerberosToken.java
---
@@ -51,11 +52,11 @@
* The user that
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/273#discussion_r124146860
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/security/tokens/KerberosToken.java
---
@@ -51,11 +52,11 @@
* The user that
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/273#discussion_r124146716
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/security/tokens/KerberosToken.java
---
@@ -51,11 +52,11 @@
* The user that
Github user asfgit closed the pull request at:
https://github.com/apache/accumulo/pull/273
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/272
Haven't looked at the content of the PR yet, but one initial observation:
please follow git log message formatting conventions separating title/subject
from body. Here's [one summary][1] of those
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/273#discussion_r124141590
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/security/tokens/KerberosToken.java
---
@@ -51,11 +52,11 @@
* The user that
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/273
The two new test are nice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/273
Will wait on travis as well as my local `mvn clean verify
-Dit.test='KerberosIT,KerberosProxyIT'` to come back.
---
If your project is set up for it, you can reply to this email and have your
re
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/273#discussion_r124122964
--- Diff:
test/src/test/java/org/apache/accumulo/test/functional/KerberosProxyIT.java ---
@@ -463,6 +477,56 @@ public void testMismatchPrincipals() th
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/273
> I notice this change was targeted to 1.7. Is there any impact from this
change on using 1.7.3 server with 1.7.4 client and visa versa?
There is obviously the change in implementation th
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/273#discussion_r124119086
--- Diff:
test/src/test/java/org/apache/accumulo/test/functional/KerberosProxyIT.java ---
@@ -463,6 +477,56 @@ public void testMismatchPrincipals() throw
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/273#discussion_r124118903
--- Diff:
test/src/test/java/org/apache/accumulo/test/functional/KerberosProxyIT.java ---
@@ -463,6 +477,56 @@ public void testMismatchPrincipals() throw
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/273#discussion_r124118094
--- Diff:
test/src/test/java/org/apache/accumulo/test/functional/KerberosProxyIT.java ---
@@ -463,6 +477,56 @@ public void testMismatchPrincipals() th
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/273#discussion_r124117442
--- Diff:
test/src/test/java/org/apache/accumulo/test/functional/KerberosProxyIT.java ---
@@ -463,6 +477,56 @@ public void testMismatchPrincipals() th
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/273#discussion_r124114509
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/security/tokens/KerberosToken.java
---
@@ -70,18 +71,12 @@ public KerberosToken(String prin
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/273#discussion_r124113747
--- Diff: core/src/main/java/org/apache/accumulo/core/rpc/ThriftUtil.java
---
@@ -282,21 +283,39 @@ public static TTransport
createClientTransport(HostA
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/273
I notice this change was targeted to 1.7. Is there any impact from this
change on using 1.7.3 server with 1.7.4 client and visa versa?
---
If your project is set up for it, you can reply to
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/273#discussion_r124110937
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/security/tokens/KerberosToken.java
---
@@ -70,18 +71,12 @@ public KerberosToken(String p
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/273#discussion_r124108676
--- Diff: core/src/main/java/org/apache/accumulo/core/rpc/ThriftUtil.java
---
@@ -282,21 +283,39 @@ public static TTransport
createClientTransport(Ho
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/273
I'd appreciate a review of these changes (instead of just merging) since
they are security related.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
GitHub user joshelser opened a pull request:
https://github.com/apache/accumulo/pull/273
ACCUMULO-4665 Use UGI with real Kerberos credentials
UGI supports the notion of users without credentials being
"proxied" (riding on top of) another user which does have
credentials. This
Github user dlmarion commented on the issue:
https://github.com/apache/accumulo/pull/272
Latest commit causing build to fail with test failure at:
HostRegexTableLoadBalancerReconfigurationTest.testConfigurationChanges:83
expected:<5> but was:<0>
---
If your project is set up
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/271
Ok sounds good. I was just thinking ahead since TServersServlet.java is
removed in that PR. It shouldn't be a problem finding a spot for your new
stuff though... it should actually be easier
Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/272#discussion_r124015943
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
---
@@ -66,6 +71,9 @@
* It's possibl
Github user ivakegg commented on the issue:
https://github.com/apache/accumulo/pull/271
@milleruntime Yes, I would like this feature to persist. I expect this
would be merged into the master when complete. If that is before the Monitor
PR gets merge, then the person to merge the Mon
25 matches
Mail list logo
