[GitHub] accumulo pull request #293: ACCUMULO-4669 Use windowed statistics in RFile

2017-08-18 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/293#discussion_r134035312 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RollingStats.java --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #293: ACCUMULO-4669 Use windowed statistics in RFile

2017-08-18 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/293#discussion_r134035002 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java --- @@ -403,7 +402,8 @@ public void flushIfNeeded() throws IOException

[GitHub] accumulo issue #291: ACCUMULO-4693: Add instance-specific ProcessName to Had...

2017-08-08 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/291 > Thoughts, @mikewalch ? In Accumulo 2.0, the system property `app` is no longer set. Instead, a system property `accumulo.application` is set in [accumulo-env.sh](https://github.

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-12 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r127045543 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126764150 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126762674 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126726827 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126729802 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126726174 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo issue #276: ACCUMULO-4673 Review proxy docs & example code

2017-07-03 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/276 Corresponding PR to add example code & docs to website repo: https://github.com/apache/accumulo-website/pull/17 --- If your project is set up for it, you can reply to this email and have

[GitHub] accumulo pull request #276: ACCUMULO-4673 Review proxy docs & example code

2017-07-03 Thread mikewalch
GitHub user mikewalch opened a pull request: https://github.com/apache/accumulo/pull/276 ACCUMULO-4673 Review proxy docs & example code * Deleted proxy docs & example code as they were moved to documentation in accumulo-website repo * proxy.thrift now lives in l

[GitHub] accumulo pull request #266: ACCUMULO-4648 - Update voting text in build.sh s...

2017-06-13 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/266#discussion_r121774635 --- Diff: assemble/build.sh --- @@ -138,8 +138,8 @@ Please vote one of: [ ] -1 - Because..., I do not accept... ... these artifacts

[GitHub] accumulo pull request #266: ACCUMULO-4648 - Update voting text in build.sh s...

2017-06-13 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/266#discussion_r121774582 --- Diff: assemble/build.sh --- @@ -138,8 +138,8 @@ Please vote one of: [ ] -1 - Because..., I do not accept... ... these artifacts

[GitHub] accumulo pull request #266: ACCUMULO-4648 - Update voting text in build.sh s...

2017-06-06 Thread mikewalch
GitHub user mikewalch opened a pull request: https://github.com/apache/accumulo/pull/266 ACCUMULO-4648 - Update voting text in build.sh script Update to form email for voting. If approved, will make this in 1.7, 1.8, and master. You can merge this pull request into a Git

[GitHub] accumulo issue #265: ACCUMULO-4647 - start of contributor guide

2017-06-06 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/265 +1 Updates look good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

2017-06-06 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/265#discussion_r120377137 --- Diff: pom.xml --- @@ -832,6 +832,7 @@ nbproject/** nb-configuration.xml nbactions.xml

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

2017-06-06 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/265#discussion_r120364815 --- Diff: CONTRIBUTING.md --- @@ -0,0 +1,25 @@ +# Contributors Guide + + If you believe that you have found a bug, please search

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

2017-06-06 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/265#discussion_r120360809 --- Diff: CONTRIBUTING.md --- @@ -0,0 +1,25 @@ +# Contributors Guide + + If you believe that you have found a bug, please search

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

2017-06-06 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/265#discussion_r120364297 --- Diff: CONTRIBUTING.md --- @@ -0,0 +1,25 @@ +# Contributors Guide + + If you believe that you have found a bug, please search

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

2017-06-06 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/265#discussion_r120366191 --- Diff: CONTRIBUTING.md --- @@ -0,0 +1,25 @@ +# Contributors Guide + + If you believe that you have found a bug, please search

[GitHub] accumulo pull request #264: ACCUMULO-4646 Updates to INSTALL.md

2017-06-02 Thread mikewalch
GitHub user mikewalch opened a pull request: https://github.com/apache/accumulo/pull/264 ACCUMULO-4646 Updates to INSTALL.md As a background for this PR, the text in INSTALL.md now exists on in Accumulo documentation on project website at. https://accumulo.apache.org/docs

[GitHub] accumulo issue #259: ACCUMULO-4630 Move user manual to Accumulo website

2017-05-22 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/259 I closed it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] accumulo pull request #259: ACCUMULO-4630 Move user manual to Accumulo websi...

2017-05-19 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/259#discussion_r117531617 --- Diff: pom.xml --- @@ -257,13 +256,6 @@ org.apache.accumulo -accumulo-docs --- End diff

[GitHub] accumulo pull request #259: ACCUMULO-4630 Move user manual to Accumulo websi...

2017-05-19 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/259#discussion_r117531534 --- Diff: core/pom.xml --- @@ -259,6 +259,41 @@ + +org.codehaus.mojo +exec

[GitHub] accumulo pull request #259: ACCUMULO-4630 Move user manual to Accumulo websi...

2017-05-18 Thread mikewalch
GitHub user mikewalch opened a pull request: https://github.com/apache/accumulo/pull/259 ACCUMULO-4630 Move user manual to Accumulo website * removed user manual asciidoc and moved it to accumulo-website repo * binary tarball no longer contains user manual * moved

[GitHub] accumulo issue #249: ACCUMULO-4624 Decrease level in user manual TOC

2017-04-18 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/249 This is a small change but one that others might not want so I am putting it up for review. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] accumulo pull request #249: ACCUMULO-4624 Decrease level in user manual TOC

2017-04-18 Thread mikewalch
GitHub user mikewalch opened a pull request: https://github.com/apache/accumulo/pull/249 ACCUMULO-4624 Decrease level in user manual TOC * Decreased levels from 4 to 2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mikewalch

[GitHub] accumulo pull request #245: ACCUMULO-4620 Consolidate all Maven modules into...

2017-04-12 Thread mikewalch
Github user mikewalch closed the pull request at: https://github.com/apache/accumulo/pull/245 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] accumulo pull request #246: ACCUMULO-4620 Consolidate all Maven modules into...

2017-04-12 Thread mikewalch
Github user mikewalch closed the pull request at: https://github.com/apache/accumulo/pull/246 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] accumulo issue #246: ACCUMULO-4620 Consolidate all Maven modules into one di...

2017-04-12 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/246 Closing this PR as it should only be applied to master branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] accumulo pull request #245: ACCUMULO-4620 Consolidate all Maven modules into...

2017-04-12 Thread mikewalch
GitHub user mikewalch reopened a pull request: https://github.com/apache/accumulo/pull/245 ACCUMULO-4620 Consolidate all Maven modules into one directory (1.8) This PR is for master. I am going to create PRs for 1.8 & 1.7 branches to make merging easier in the future. You

[GitHub] accumulo pull request #245: ACCUMULO-4620 Consolidate all Maven modules into...

2017-04-12 Thread mikewalch
Github user mikewalch closed the pull request at: https://github.com/apache/accumulo/pull/245 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] accumulo issue #245: ACCUMULO-4620 Consolidate all Maven modules into one di...

2017-04-12 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/245 @ctubbsii, I will close this PR and only have the master PR open. I wasn't sure about doing this change in the 1.8 & 1.7 branches but I opened as I thought it may make merging fixes to ma

[GitHub] accumulo pull request #246: ACCUMULO-4620 Consolidate all Maven modules into...

2017-04-07 Thread mikewalch
GitHub user mikewalch opened a pull request: https://github.com/apache/accumulo/pull/246 ACCUMULO-4620 Consolidate all Maven modules into one directory You can merge this pull request into a Git repository by running: $ git pull https://github.com/mikewalch/accumulo modules

[GitHub] accumulo pull request #245: ACCUMULO-4620 Consolidate all Maven modules into...

2017-04-07 Thread mikewalch
GitHub user mikewalch opened a pull request: https://github.com/apache/accumulo/pull/245 ACCUMULO-4620 Consolidate all Maven modules into one directory This PR is for master. I am going to create PRs for 1.8 & 1.7 branches to make merging easier in the future. You can m

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-07 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110189876 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/view/Indexes.java --- @@ -0,0 +1,383 @@ +/* + * Licensed to the Apache

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-07 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110258980 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/view/Indexes.java --- @@ -0,0 +1,383 @@ +/* + * Licensed to the Apache

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-07 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110252701 --- Diff: assemble/pom.xml --- @@ -195,6 +235,86 @@ true + org.freemarker + freemarker

[GitHub] accumulo pull request #240: ACCUMULO-4618 Updates from additional code revie...

2017-04-07 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/240#discussion_r110412136 --- Diff: maven-plugin/pom.xml --- @@ -68,6 +68,7 @@ xml-apis xml-apis + provided --- End diff

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-05 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110019365 --- Diff: server/monitor/src/main/resources/templates/overview.ftl --- @@ -0,0 +1,90 @@ +<#-- + Licensed to the Apache Software Foundation (

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-05 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110013733 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/BasicServlet.java --- @@ -1,285 +0,0 @@ -/* - * Licensed

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-05 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110014843 --- Diff: server/monitor/src/main/resources/templates/index.ftl --- @@ -0,0 +1,72 @@ + + + +${title} - Accumulo ${version

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-05 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110012789 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java --- @@ -461,25 +452,9 @@ public void run(String hostname

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-05 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110015222 --- Diff: server/monitor/src/main/resources/resources/vis.js --- @@ -0,0 +1,506 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] accumulo issue #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-05 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/242 I started reviewing this. I was able to build a tarball and run Accumulo locally with the new monitor. However, it looks like the integration tests are failing due to missing/extra

[GitHub] accumulo pull request #240: ACCUMULO-4618 Updates from additional code revie...

2017-04-05 Thread mikewalch
GitHub user mikewalch opened a pull request: https://github.com/apache/accumulo/pull/240 ACCUMULO-4618 Updates from additional code review * Now using only one httpclient jar * Marked xml-apis jar as provided * Added slf4j-log4j12 to several modules with test scope You can

[GitHub] accumulo pull request #239: ACCUMULO-4618 Enforce dependency analysis during...

2017-04-05 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/239#discussion_r109942704 --- Diff: fate/pom.xml --- @@ -35,10 +35,6 @@ commons-lang - log4j - log4j --- End diff

[GitHub] accumulo pull request #239: ACCUMULO-4618 Enforce dependency analysis during...

2017-04-05 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/239#discussion_r109939194 --- Diff: server/monitor/pom.xml --- @@ -105,23 +113,13 @@ slf4j-api - org.eclipse.jetty - jetty-http

[GitHub] accumulo pull request #239: ACCUMULO-4618 Enforce dependency analysis during...

2017-04-05 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/239#discussion_r109938253 --- Diff: pom.xml --- @@ -422,7 +423,7 @@ org.apache.httpcomponents httpclient -4.3.1

[GitHub] accumulo pull request #239: ACCUMULO-4618 Enforce dependency analysis during...

2017-04-05 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/239#discussion_r109929494 --- Diff: maven-plugin/pom.xml --- @@ -66,9 +66,8 @@ maven-plugin-annotations - junit - junit

[GitHub] accumulo pull request #239: ACCUMULO-4618 Enforce dependency analysis during...

2017-04-04 Thread mikewalch
GitHub user mikewalch opened a pull request: https://github.com/apache/accumulo/pull/239 ACCUMULO-4618 Enforce dependency analysis during build * Build will fail if module has missing or unused dependency * Plugin is conifigured to ignore certain depedencies in main pom.xml

[GitHub] accumulo pull request #236: ACCUMULO-4614 AccumuloClassLoader should load ac...

2017-03-29 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/236#discussion_r108681934 --- Diff: start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java --- @@ -44,21 +44,21 @@ public class

[GitHub] accumulo pull request #236: ACCUMULO-4614 AccumuloClassLoader should load ac...

2017-03-28 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/236#discussion_r108550201 --- Diff: start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java --- @@ -44,21 +44,21 @@ public class

[GitHub] accumulo pull request #236: ACCUMULO-4614 AccumuloClassLoader should load ac...

2017-03-28 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/236#discussion_r108543513 --- Diff: start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java --- @@ -44,21 +44,21 @@ public class

[GitHub] accumulo pull request #236: ACCUMULO-4614 AccumuloClassLoader should load ac...

2017-03-28 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/236#discussion_r108534597 --- Diff: start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java --- @@ -44,21 +44,21 @@ public class

[GitHub] accumulo pull request #236: ACCUMULO-4614 AccumuloClassLoader should load ac...

2017-03-28 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/236#discussion_r108517849 --- Diff: start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java --- @@ -44,21 +44,21 @@ public class

[GitHub] accumulo pull request #236: ACCUMULO-4614 AccumuloClassLoader should load ac...

2017-03-28 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/236#discussion_r108482950 --- Diff: start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java --- @@ -44,21 +44,21 @@ public class

[GitHub] accumulo pull request #236: ACCUMULO-4614 AccumuloClassLoader should load ac...

2017-03-28 Thread mikewalch
GitHub user mikewalch opened a pull request: https://github.com/apache/accumulo/pull/236 ACCUMULO-4614 AccumuloClassLoader should load accumulo-site.xml from … …classpath * Removed use of ACCUMULO_CONF_DIR env variable * Updated accumulo command to no longer require

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-24 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107951433 --- Diff: core/src/test/java/org/apache/accumulo/core/conf/AccumuloConfigurationTest.java --- @@ -25,16 +25,17 @@ @Test public void

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-24 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107951460 --- Diff: core/src/test/java/org/apache/accumulo/core/conf/AccumuloConfigurationTest.java --- @@ -49,12 +50,12 @@ public void testGetTimeInMillis

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-24 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107943447 --- Diff: INSTALL.md --- @@ -36,62 +36,49 @@ to manage Accumulo: These scripts will be used in the remaining instructions to configure and run

[GitHub] accumulo issue #235: ACCUMULO-4612 - Simplify Accumulo memory configuration

2017-03-24 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/235 I would like to merge today if there are no objections. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-24 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107920669 --- Diff: assemble/bin/accumulo --- @@ -80,9 +65,6 @@ function main() { JAVA=($ACCUMULO_JAVA_PREFIX $JAVA) --- End diff -- I am ok

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-23 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107759896 --- Diff: core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java --- @@ -209,13 +209,19 @@ static public long getMemoryInBytes

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-23 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107721029 --- Diff: core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java --- @@ -209,13 +209,19 @@ static public long getMemoryInBytes

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-23 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107717380 --- Diff: INSTALL.md --- @@ -36,62 +36,49 @@ to manage Accumulo: These scripts will be used in the remaining instructions to configure and run

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-23 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107715725 --- Diff: docs/src/main/asciidoc/chapters/administration.txt --- @@ -404,6 +399,51 @@ and BatchScanner passing in the name of the context, app1

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-23 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107690518 --- Diff: core/src/main/java/org/apache/accumulo/core/conf/Property.java --- @@ -253,13 +252,13 @@ + " max number of concurrent writer

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-23 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107690464 --- Diff: core/src/main/java/org/apache/accumulo/core/conf/Property.java --- @@ -170,10 +170,9 @@ // general properties GENERAL_PREFIX

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-23 Thread mikewalch
GitHub user mikewalch opened a pull request: https://github.com/apache/accumulo/pull/235 ACCUMULO-4612 - Simplify Accumulo memory configuration * Tablet server memory setttings now default to a percentage of Java heap space given to process. Default settings will work

[GitHub] accumulo issue #233: ACCUMULO-4604 Improve 'accumulo classpath' command

2017-03-21 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/233 I am going to merge today if there are no objections --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] accumulo pull request #233: ACCUMULO-4604 Improve 'accumulo classpath' comma...

2017-03-20 Thread mikewalch
GitHub user mikewalch opened a pull request: https://github.com/apache/accumulo/pull/233 ACCUMULO-4604 Improve 'accumulo classpath' command * Default output is now colon seperated jars on one line * Added '-d' option to print old human readable format * Improved usage

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-13 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 I ran more ITs. `BadDeleteMarkersCreatedIT` and `CleanWallIT` worked for me. However, I ran all standalone ITs and several tests timed out (for reference, one was was `SessionBlockVerifyIT

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-10 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 @joshelser, I will look into the test failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-10 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 > Maybe 'client.cmd.prefix' and 'server.cmd.prefix' instead? I updated the property names in bf9dfb4 --- If your project is set up for it, you can reply to this email and have y

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-10 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 While I removed use of `sudo` and the 'user' property from the standalone IT properties, they can still be set using a new 'client.prefix' and 'server.prefix' which replaces the the 'client.env

[GitHub] accumulo pull request #228: ACCUMULO-4596 Improvements to standalone cluster...

2017-03-10 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/228#discussion_r105409269 --- Diff: assemble/bin/accumulo --- @@ -39,7 +39,7 @@ function main() { # Set up variables needed by accumulo-env.sh export bin="$(

[GitHub] accumulo issue #231: ACCUMULO-4596 Remove env variable from general.dynamic....

2017-03-09 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/231 @ctubbsii, I took a look at commons configuration 2 and agree that we should probably move to that first and then changedthe default for `general.dynamic.classpaths` to be based off a system

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-08 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 > accumulo.it.cluster.standalone.client.env="ACCUMULO_CONF_DIR=/etc/accumulo-client" accumulo.it.cluster.standalone.server.env="ACCUMULO_CONF_DIR=/etc/accumulo-se

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-08 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 @joshelser, I pushed another commit 12c260c0135e2c8 that should resolve your concerns. I added changes to the accumulo scripts to support `ACCUMULO_CONF_DIR` for backwards compatibility. I

[GitHub] accumulo pull request #228: ACCUMULO-4596 Improvements to standalone cluster...

2017-03-08 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/228#discussion_r105017334 --- Diff: minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneClusterControl.java --- @@ -149,9 +141,8 @@ String getJarFromClass

[GitHub] accumulo pull request #228: ACCUMULO-4596 Improvements to standalone cluster...

2017-03-08 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/228#discussion_r105010895 --- Diff: minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneClusterControl.java --- @@ -149,9 +141,8 @@ String getJarFromClass

[GitHub] accumulo pull request #228: ACCUMULO-4596 Improvements to standalone cluster...

2017-03-08 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/228#discussion_r104996774 --- Diff: minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneClusterControl.java --- @@ -149,9 +141,8 @@ String getJarFromClass

[GitHub] accumulo issue #230: Accumulo-4599 Simplify how accumulo script adds jars to...

2017-03-08 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/230 I am going to merge today if there are no objections. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] accumulo pull request #231: ACCUMULO-4596 Remove env variable from general.d...

2017-03-08 Thread mikewalch
GitHub user mikewalch opened a pull request: https://github.com/apache/accumulo/pull/231 ACCUMULO-4596 Remove env variable from general.dynamic.classpaths * Removed default value for general.dynamic.classpaths which used ACCUMULO_HOME env variale * Create system property

[GitHub] accumulo pull request #230: Accumulo-4599 Simplify how accumulo script adds ...

2017-03-08 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/230#discussion_r104965493 --- Diff: assemble/bin/accumulo --- @@ -59,43 +59,22 @@ function main() { export ACCUMULO_CONF_DIR="$conf" # Veri

[GitHub] accumulo pull request #230: Accumulo-4599 Simplify how accumulo script adds ...

2017-03-08 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/230#discussion_r104952630 --- Diff: assemble/bin/accumulo --- @@ -59,43 +59,22 @@ function main() { export ACCUMULO_CONF_DIR="$conf" # Veri

[GitHub] accumulo pull request #230: Accumulo-4599 Simplify how accumulo script adds ...

2017-03-08 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/230#discussion_r104950540 --- Diff: assemble/bin/accumulo --- @@ -59,43 +59,22 @@ function main() { export ACCUMULO_CONF_DIR="$conf" # Veri

[GitHub] accumulo pull request #230: Accumulo-4599 Simplify how accumulo script adds ...

2017-03-07 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/230#discussion_r104793591 --- Diff: assemble/bin/accumulo --- @@ -59,43 +59,22 @@ function main() { export ACCUMULO_CONF_DIR="$conf" # Veri

[GitHub] accumulo pull request #230: Accumulo-4599 Simplify how accumulo script adds ...

2017-03-07 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/230#discussion_r104759592 --- Diff: assemble/bin/accumulo --- @@ -59,43 +59,22 @@ function main() { export ACCUMULO_CONF_DIR="$conf" # Veri

[GitHub] accumulo pull request #230: Accumulo-4599 Simplify how accumulo script adds ...

2017-03-07 Thread mikewalch
GitHub user mikewalch opened a pull request: https://github.com/apache/accumulo/pull/230 Accumulo-4599 Simplify how accumulo script adds jars to classpath * Removed ACCUMULO_XTRAJARS variable * Include '-add' option in accumulo script usage You can merge this pull request

[GitHub] accumulo pull request #228: ACCUMULO-4596 Improvements to standalone cluster...

2017-03-07 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/228#discussion_r104678751 --- Diff: TESTING.md --- @@ -117,8 +117,8 @@ The following properties can be used to configure a standalone cluster

[GitHub] accumulo pull request #228: ACCUMULO-4596 Improvements to standalone cluster...

2017-03-07 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/228#discussion_r104678703 --- Diff: TESTING.md --- @@ -117,8 +117,8 @@ The following properties can be used to configure a standalone cluster

[GitHub] accumulo pull request #228: ACCUMULO-4596 Improvements to standalone cluster...

2017-03-07 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/228#discussion_r104678440 --- Diff: minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneClusterControl.java --- @@ -123,11 +114,12 @@ public int exec

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-07 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 @joshelser, let me know if my changes now work for you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] accumulo pull request #228: ACCUMULO-4596 Improvements to standalone cluster...

2017-03-06 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/228#discussion_r104537251 --- Diff: minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneClusterControl.java --- @@ -149,9 +141,8 @@ String getJarFromClass

[GitHub] accumulo pull request #228: ACCUMULO-4596 Improvements to standalone cluster...

2017-03-06 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/228#discussion_r104535648 --- Diff: minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneAccumuloCluster.java --- @@ -57,7 +57,7 @@ private

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-06 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 I tested these changes by running `ReadWriteIT` against and a local cluster started by uno. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] accumulo pull request #228: ACCUMULO-4596 Improvements to standalone cluster...

2017-03-06 Thread mikewalch
GitHub user mikewalch opened a pull request: https://github.com/apache/accumulo/pull/228 ACCUMULO-4596 Improvements to standalone cluster testing * Limited use of bash env variables in standalone cluster testing * Fixed standalone cluster testing sow that it work with Accumulo

[GitHub] accumulo pull request #227: ACCUMULO-4596 Stopped using ACCUMULO_HOME for na...

2017-03-06 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/227#discussion_r104456123 --- Diff: assemble/bin/accumulo-util --- @@ -571,20 +570,17 @@ function load_jars_hdfs() { "$HADOOP_PREFIX/bin/hadoop&qu

  1   2   3   >