GitHub user milleruntime opened a pull request:
https://github.com/apache/accumulo/pull/294
Accumulo 3652 sl4j refactoring
Closes #32
Rebase'd original commit from PR #32 onto master. Then fixed any places
where an exception was obscured by using the sl4j Logger method
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/32
I rebased @thormanrd 's branch against latest master here:
https://github.com/milleruntime/accumulo/tree/accumulo-3652
@thormanrd would you be able to merge my branch into yours if I
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/289#discussion_r133748947
--- Diff: pom.xml ---
@@ -167,6 +167,11 @@
1.48
+com.fasterxml
+classmate
--- End
Github user milleruntime closed the pull request at:
https://github.com/apache/accumulo/pull/292
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/292#discussion_r133695596
--- Diff:
core/src/test/java/org/apache/accumulo/core/client/impl/NamespaceTest.java ---
@@ -17,38 +17,73 @@
package
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/292#discussion_r133695113
--- Diff:
core/src/test/java/org/apache/accumulo/core/client/impl/NamespaceTest.java ---
@@ -17,38 +17,73 @@
package
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/292#discussion_r133530036
--- Diff:
server/master/src/main/java/org/apache/accumulo/master/tableOps/Utils.java ---
@@ -59,21 +57,16 @@ static void checkTableDoesNotExist
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/292#discussion_r133528726
--- Diff:
core/src/test/java/org/apache/accumulo/core/client/impl/NamespaceTest.java ---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/292#discussion_r133506281
--- Diff:
core/src/test/java/org/apache/accumulo/core/client/impl/NamespaceTest.java ---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/292#discussion_r133503470
--- Diff:
core/src/test/java/org/apache/accumulo/core/client/impl/NamespaceTest.java ---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/292
> This whole thing might be easier to implement with
CacheBuilder.weakValues() from Guava. Eviction seems to occur if value
disappears. I think this will do what we want, and it sho
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/292#discussion_r133225358
--- Diff:
core/src/test/java/org/apache/accumulo/core/client/impl/TableTest.java ---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/292#discussion_r133002554
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/Table.java ---
@@ -16,24 +16,59 @@
*/
package
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/292#discussion_r133002408
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/Table.java ---
@@ -16,24 +16,59 @@
*/
package
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/292#discussion_r132999867
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/Table.java ---
@@ -16,24 +16,59 @@
*/
package
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/292#discussion_r132972878
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/Table.java ---
@@ -16,24 +16,59 @@
*/
package
GitHub user milleruntime opened a pull request:
https://github.com/apache/accumulo/pull/292
ACCUMULO-4681 Created Table & Namespace WeakReference map
Moved the de-dupe ID code out of KeyExtent to Table and Namespace. Created
"of" static methods to access ID
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/289#discussion_r132199113
--- Diff:
server/monitor/src/main/java/org/apache/accumulo/monitor/rest/trace/TracesResource.java
---
@@ -77,12 +81,12 @@
* Generates
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/289
> @milleruntime What's your feeling on using javax.validation.constraints
right in the method signature?
I am on the fence with using external validation. One one hand, it does
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/289#discussion_r131425860
--- Diff:
server/monitor/src/main/java/org/apache/accumulo/monitor/rest/trace/TracesResource.java
---
@@ -176,12 +193,15 @@ public Void run
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/289#discussion_r131426801
--- Diff:
server/monitor/src/main/java/org/apache/accumulo/monitor/rest/trace/TracesResource.java
---
@@ -258,8 +278,8 @@ protected Range
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/289#discussion_r131427513
--- Diff:
server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tservers/TabletServerResource.java
---
@@ -141,28 +146,27 @@ public
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/289#discussion_r131424909
--- Diff:
server/monitor/src/main/java/org/apache/accumulo/monitor/rest/trace/TracesResource.java
---
@@ -84,6 +86,10 @@
@GET
public
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/289#discussion_r131425948
--- Diff:
server/monitor/src/main/java/org/apache/accumulo/monitor/rest/trace/TracesResource.java
---
@@ -119,16 +125,27 @@ public Void run
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/285
Back ported changes to 1.7 and merged up. This PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/285
I can merge this into master and then apply the changes to 1.7 and 1.8.
@glitch I don't think you are listed yet under Contributors. Would you
like to be added to the list
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/286
> there is no obligation of review before commit.
Right, that's why I was wondering why you bothered with the PR.
I see your comments on JIRA, thanks.
---
If your proj
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/286
Just curious but why open a PR for only a few hours? Even if the change is
minor, seems like hardly enough time for review.
---
If your project is set up for it, you can reply to this email
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/280
No its not in this PR. I don't know if you or @lstav wanted it to be a
REST endpoint but this just has the version added to Thrift and a getVersion to
tserver.
---
If your project is set
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/280
Looks good. This is the minimum we need for now and can revisit the other
changes later. I can merge this since its already been discussed and reviewed
elsewhere.
---
If your project
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/200
Discussed this some today offline with the team and there seems to be
resistance to creating new API methods for this change. @lstav you could pull
out the changes for getting the version
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r127793774
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java ---
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/279
I believe I have addressed all concerns. @joshelser if you aren't opposed
to the Table and Namespace wrapper classes, I will merge this PR.
---
If your project is set up for it, you can
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r127239847
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/Namespaces.java ---
@@ -100,50 +106,150 @@ private static ZooCache getZooCache
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r127068208
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
---
@@ -70,15 +70,15 @@
public abstract
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r127068016
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/Table.java ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r127067656
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/Table.java ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r127058627
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/Namespace.java ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r126772637
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/Table.java ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r126760182
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/Table.java ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r126758011
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
---
@@ -70,15 +70,15 @@
public abstract
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r126757222
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/Namespace.java ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r126754662
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/Table.java ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r126753848
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/Table.java ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r126748404
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java ---
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r126746264
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/Namespaces.java ---
@@ -100,50 +106,150 @@ private static ZooCache getZooCache
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r126745260
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java ---
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r126734863
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/Namespaces.java ---
@@ -100,50 +106,150 @@ private static ZooCache getZooCache
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r126551778
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java ---
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r126531695
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/TableOfflineException.java
---
@@ -26,7 +27,7 @@ private static String getTableName
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r126531488
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/Namespaces.java ---
@@ -72,10 +78,10 @@ public String invalidMessage(String
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r126505403
--- Diff:
server/master/src/main/java/org/apache/accumulo/master/tableOps/WriteExportFiles.java
---
@@ -144,16 +145,15 @@ public static void
GitHub user milleruntime opened a pull request:
https://github.com/apache/accumulo/pull/279
ACCUMULO-3238 Table.ID Namespace.ID Refactor
* Replaced all occurrences of tableId and namespaceId Strings
that aren't a part of the user facing API with type safe
Table.ID
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/275
@ivakegg I recently created a performance test suite using JMH to measure
the work I did with iterators:
https://github.com/milleruntime/accumulo-benchmark
It is pretty specific but could
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/271
Ok sounds good. I was just thinking ahead since TServersServlet.java is
removed in that PR. It shouldn't be a problem finding a spot for your new
stuff though... it should actually
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/271
@ivakegg Are you planning on merging this forward to master? We have yet
to merge the new Monitor so I am wondering what would be the best technique to
make sure this doesn't get lost
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/267
These changes ran successfully yesterday with Sunny ITs on my laptop.
Since it looks like Jenkins is still borked, I will just go ahead with pushing
these changes today.
---
If your
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/267#discussion_r121169020
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java
---
@@ -162,7 +163,16 @@ public long
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/267#discussion_r121167952
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/conf/TableConfWatcher.java
---
@@ -33,11 +33,13 @@
private static final Logger
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/267#discussion_r121002215
--- Diff:
server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java ---
@@ -169,23 +170,25 @@ public void span(RemoteSpan s) throws
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/267#discussion_r120997737
--- Diff:
server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java ---
@@ -169,23 +170,25 @@ public void span(RemoteSpan s) throws
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/267#discussion_r120996472
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java
---
@@ -162,7 +163,16 @@ public long
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/267#discussion_r120996306
--- Diff:
server/gc/src/test/java/org/apache/accumulo/gc/SimpleGarbageCollectorTest.java
---
@@ -71,7 +71,7 @@ public void setUp() {
opts
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/266
+1 I think this wording is reasonable. I do remember a debate on deadline
of voting occurring last year so others might have opinions on the matter.
---
If your project is set up
GitHub user milleruntime opened a pull request:
https://github.com/apache/accumulo/pull/267
ACCUMULO-4642 Changes to remove ServerConfiguration.getInstance()
A first step in the bigger refactoring effort for
[ACCUMULO-4050](https://issues.apache.org/jira/browse/ACCUMULO-4050
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/264
Looks good +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/260#discussion_r119157139
--- Diff:
test/src/main/java/org/apache/accumulo/test/functional/YieldingIterator.java ---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/242
@ctubbsii @joshelser let me know what you think of
41a8b5a06085c444dfdafa5f4192f1ada05f724b
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/242
One problem with ThriftServerBindsBeforeZooKeeperLockIT (independent of
these changes) is that a failure or error will result in the test running
indefinitely. Only when things go
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/242
I am not sure what the second while loop is checking for in
testMonitorService but its expecting a standby monitor. If its just testing
for a standby monitor think its safe to remove
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/242
Ok the reason I was asking was because of this check in
ThriftServerBindsBeforeZooKeeperLockIT
`// This is our "assertion", but we want to re-check it if it's not what
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/242
While looking into the failing IT, ThriftServerBindsBeforeZooKeeperLockIT,
I noticed BasicServlet (which was deleted) had functionality of a standby
Monitor as part of HighlyAvailableService
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/257
I merged the changes with the 1.8 branch and created benchmarks for them as
well. Ran those benchmarks on my laptop and got similar results. Full test
results can be seen
[here](https
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/257
Results from my Linux laptop:
Test: MyBenchmark.seekAllSystemIters10 showed 61.0% increase in ops/s
Test: MyBenchmark.seekAllSystemIters1000 showed 66.6% increase in ops/s
Test
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/257
I took a look again at the changes to ColumnQualifierFilter and I think
they are still a positive change. I think the slowdown with
seekTestWithCQFilter10 is due to the overhead of the setup
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/257
Refactored the benchmark suite to build different version. Here are the
new results:
Test: MyBenchmark.seekAllSystemIters10 showed 89.8% increase in ops/s
Test
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/257
Scratch that... the tests weren't great. Doing some tweaking and then will
run again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/257
I modified the benchmark tests to work with 1.7 and ran against my branch
and 1.7. A few individual tests showed a decrease. Here were the results:
Test
GitHub user milleruntime opened a pull request:
https://github.com/apache/accumulo/pull/257
ACCUMULO-4636 system iterator improvements for 1.7
Back ported some of the improvements from ACCUMULO-3079 and PR #244 to 1.7
(and will also merge with 1.8). These improvements just include
Github user milleruntime closed the pull request at:
https://github.com/apache/accumulo/pull/255
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/255
Merged into 1.7, 1.8 and master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/255
With the span min set to 0, I am consistently seeing the Test pass and the
output:
0+2268 master@0.0.0.0
org.apache.accumulo.core.client.impl.TabletServerBatchWriter
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/255
I think we got it! Looking good with 22c9481
I will run the IT a few more times just to make sure this is squashed.
---
If your project is set up for it, you can reply to this email
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/255
Thanks @billierinaldi good idea with the tracer.span.min.ms parameter. I
will give a try see what we get!
---
If your project is set up for it, you can reply to this email and have your
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/255
Created a quick attempt at a static parent span to pass to the threads in
7444888ff8582bc31d0c61444103cc4dc9ff362a
Doesn't seem to work though whomp whomp
---
If your project
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/255
> If we can create spans by explicitly passing the parent (constructor or
static method)
I'm not quite sure exactly what you mean... instead of this:
`Span span = Trace.st
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/255
Or because we change the name of the thread (wtf??) in
TabletServerBatchWriter.SendTask.send()
https://github.com/apache/accumulo/blob/master/core/src/main/java/org/apache/accumulo/core
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/255
Could it be because we have the traces in 2 separate thread pools and
htrace gets confused:
In org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
BinMutations
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/255
Now why is it rooted correctly when run manually in the shell
sh...@canx2um-78286w.infosec.tycho.ncsc.mil close
46+8015 sh...@canx2um-78286w.infosec.tycho.ncsc.mil
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/255
FAILURE running with Maven:
Trace started at 2017/04/28 11:06:53.041
Time Start Service@Location Name
2251+0 sh...@canx2um-78286w.infosec.tycho.ncsc.mil
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/255
SUCCESS running with Maven:
Trace started at 2017/04/28 11:01:58.382
Time Start Service@Location Name
2375+0 sh...@canx2um-78286w.infosec.tycho.ncsc.mil
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/255
Shell trace output:
Trace started at 2017/04/28 10:49:35.021
Time Start Service@Location Name
25863+0 sh...@canx2um-78286w.infosec.tycho.ncsc.mil shell:root
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/255
> Do you have more specifics as to why this is?
No, only experience with getting different traces and your and Shawn
Walkers comments on [PR94](https://github.com/apache/accumulo/p
GitHub user milleruntime opened a pull request:
https://github.com/apache/accumulo/pull/255
ACCUMULO-4365: Fix trace test in ShellServerIT
This test has been frustrating for some time now... After spending some
time looking into a potential bug (possibly one similar to ACCUMULO
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/244
For the skeptics out there, I understand that when you take into
consideration all the other factors of a cluster, low level system iterators
only make up a small percentage of system
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/244
> What's up with the benchmarks showing the *1000 tests being about 200x
slower than the *10 tests when they are only scanning over 100x the data? Any
insights?
The tests na
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/244
Updated test results on Linux. Dropping the lowest and highest gains, we
average at about an 80% gain across the 8 tests.
[JMH
Benchmarks](https://github.com/milleruntime/jmh-test/blob
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/244
I think we have a good bunch of improvements here, that I would like to
merge today. If there is any more feedback please let me know. I can open
separate tickets for the other ideas
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/244
My attempt at proper java doc for the new server iterators in 12a0bcf
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r113061466
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java ---
@@ -683,13 +683,6 @@ public void setInterruptFlag
1 - 100 of 284 matches
Mail list logo
