[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user keith-turner closed the pull request at: https://github.com/apache/accumulo/pull/100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/100#issuecomment-24851 I squashed this and merged it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user joshelser commented on the pull request: https://github.com/apache/accumulo/pull/100#issuecomment-221417030 Wonderful, thanks for running it through its paces. On May 24, 2016 1:43 PM, "Keith Turner" wrote: > @joshelser I ran some

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/100#discussion_r64483814 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/KeyShortener.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software F

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/100#issuecomment-221384261 @joshelser I ran some performance test and did not really see a difference. Below I compacted the file I have been testing with 3 times using the changes in thi

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/100#discussion_r64441677 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/KeyShortener.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Softwar

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/100#discussion_r64400847 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java --- @@ -386,13 +392,23 @@ public void flushIfNeeded() throws IOException {

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/100#discussion_r64400366 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java --- @@ -89,6 +90,10 @@ private RFile() {} static final int RINDEX_VE

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/100#issuecomment-221287151 > but overall it looks good. I assume you didn't see any performance degradation with this change? I was thinking about that, but did not test it. Wante

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/100#issuecomment-221286131 > @keith-turner this is merging into master but I assume you want this in 1.8. Will this be back ported to 1.7 and 1.6 also? I meant to make the PR agains

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user mjwall commented on the pull request: https://github.com/apache/accumulo/pull/100#issuecomment-221248395 @keith-turner this is merging into master but I assume you want this in 1.8. Will this be back ported to 1.7 and 1.6 also? --- If your project is set up for it, you c

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user joshelser commented on the pull request: https://github.com/apache/accumulo/pull/100#issuecomment-221162021 Left some nit-picky comments on `KeyShortener`, but overall it looks good. I assume you didn't see any performance degradation with this change? :+1: --- I

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/100#discussion_r64325850 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/KeyShortener.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software F

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/100#discussion_r64325773 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java --- @@ -89,6 +90,10 @@ private RFile() {} static final int RINDEX_VER_8

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/100#discussion_r64325460 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/KeyShortener.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software F

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/100#discussion_r64325038 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/KeyShortener.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software F

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/100#discussion_r64324981 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/KeyShortener.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software F

[GitHub] accumulo pull request: ACCUMULO-1124 Shorten keys in index and use...

GitHub user keith-turner opened a pull request: https://github.com/apache/accumulo/pull/100 ACCUMULO-1124 Shorten keys in index and uses statistics to choose bet… …ter keys You can merge this pull request into a Git repository by running: $ git pull https://github.com/keith