Github user asfgit closed the pull request at:
https://github.com/apache/accumulo/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/29#issuecomment-102491443
@keith-turner @ctubbsii any thoughts on MiniAccumuloRunner changes? I think
we're happy with everything else.
---
If your project is set up for it, you can reply to
Github user ctubbsii commented on the pull request:
https://github.com/apache/accumulo/pull/29#issuecomment-102496224
@joshelser You mean with regard to the public API? I don't see any semver
violations there. It doesn't even appear to change any public API at all. It
just adds an
Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/29#issuecomment-102496610
You mean with regard to the public API
Yeah, that's what I was asking about. I think it was something that Keith
had brought up before. I just wanted to
Github user tanadeau commented on the pull request:
https://github.com/apache/accumulo/pull/29#issuecomment-102496748
Speaking of 1.8, I need to change the `@since` on the
`setExistingZookeepers` to 1.8.0 from 1.7.0.
---
If your project is set up for it, you can reply to this email
Github user tanadeau commented on the pull request:
https://github.com/apache/accumulo/pull/29#issuecomment-102499874
The `@since` is now at 1.8.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r30433933
--- Diff:
minicluster/src/test/java/org/apache/accumulo/minicluster/MiniAccumuloClusterExistingZooKeepersTest.java
---
@@ -0,0 +1,91 @@
+/*
+ *
Github user tanadeau commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r30231160
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java
---
@@ -313,6 +321,19 @@ public
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r30271336
--- Diff:
minicluster/src/test/java/org/apache/accumulo/minicluster/MiniAccumuloClusterExistingZooKeepersTest.java
---
@@ -0,0 +1,91 @@
+/*
+ *
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r30268106
--- Diff: .gitignore ---
@@ -23,3 +23,4 @@
/.pydevproject
/.idea
/*.iml
+*.swp
--- End diff --
Ah, probably best to exclude
Github user tanadeau commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r30272385
--- Diff:
minicluster/src/test/java/org/apache/accumulo/minicluster/MiniAccumuloClusterExistingZooKeepersTest.java
---
@@ -0,0 +1,91 @@
+/*
+ *
Github user ctubbsii commented on the pull request:
https://github.com/apache/accumulo/pull/29#issuecomment-101803898
Overall, this looks good to me. I'm particularly interested in seeing if it
could be useful to use with our test harness and
Github user tanadeau commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r30266403
--- Diff: .gitignore ---
@@ -23,3 +23,4 @@
/.pydevproject
/.idea
/*.iml
+*.swp
--- End diff --
To ignore vim lock files
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r30268333
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloRunner.java
---
@@ -93,6 +94,7 @@ private static void printProperties() {
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r30269047
--- Diff: pom.xml ---
@@ -119,6 +119,8 @@
accumulo.release.version${project.version}/accumulo.release.version
!-- bouncycastle version for
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r30266262
--- Diff: .gitignore ---
@@ -23,3 +23,4 @@
/.pydevproject
/.idea
/*.iml
+*.swp
--- End diff --
What's this for?
---
If
Github user tanadeau commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r30279997
--- Diff:
minicluster/src/test/java/org/apache/accumulo/minicluster/MiniAccumuloClusterExistingZooKeepersTest.java
---
@@ -0,0 +1,91 @@
+/*
+ *
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r30257611
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java
---
@@ -313,6 +321,19 @@ public
Github user tanadeau commented on the pull request:
https://github.com/apache/accumulo/pull/29#issuecomment-101419071
My use case didn't end up needing any new public APIs so, per earlier
discussion, I'm going to move the code from the public API classes to the *Impl
classes.
---
Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/29#issuecomment-101423939
Cool beans, thanks for the update @tanadeau. Will watch for new changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user tanadeau commented on the pull request:
https://github.com/apache/accumulo/pull/29#issuecomment-101438449
I think this PR should be good to go unless there are more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r30200397
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloRunner.java
---
@@ -75,6 +75,7 @@
private static final String
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r30200417
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java
---
@@ -313,6 +321,19 @@ public
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28801819
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28803912
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28800662
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java
---
@@ -313,6 +321,19 @@ public
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28803038
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
Github user tanadeau commented on the pull request:
https://github.com/apache/accumulo/pull/29#issuecomment-94825331
I added tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user tanadeau commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28777305
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28789378
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28789973
--- Diff:
minicluster/src/test/java/org/apache/accumulo/minicluster/MiniAccumuloClusterExistingZooKeepersTest.java
---
@@ -0,0 +1,100 @@
+/*
+ *
Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/29#issuecomment-94845930
Cool, this is looking good @tanadeau. Thanks for the prompt updates!
We still need to address whether or not this should go into MAC or MACImpl
though. I'm
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28791592
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28789572
--- Diff:
minicluster/src/test/java/org/apache/accumulo/minicluster/MiniAccumuloClusterExistingZooKeepersTest.java
---
@@ -0,0 +1,100 @@
+/*
+ *
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28789624
--- Diff:
minicluster/src/test/java/org/apache/accumulo/minicluster/MiniAccumuloClusterExistingZooKeepersTest.java
---
@@ -0,0 +1,100 @@
+/*
+ *
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28789662
--- Diff:
minicluster/src/test/java/org/apache/accumulo/minicluster/MiniAccumuloClusterExistingZooKeepersTest.java
---
@@ -0,0 +1,100 @@
+/*
+ *
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28789943
--- Diff:
minicluster/src/test/java/org/apache/accumulo/minicluster/MiniAccumuloClusterExistingZooKeepersTest.java
---
@@ -0,0 +1,100 @@
+/*
+ *
Github user tanadeau commented on the pull request:
https://github.com/apache/accumulo/pull/29#issuecomment-94843575
Addressed test comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tanadeau commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28790916
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28818441
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
Github user keith-turner commented on the pull request:
https://github.com/apache/accumulo/pull/29#issuecomment-94870883
I'm not convinced that this feature is something that will be directly
beneficial to end users.
It would not be beneficial for
Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/29#issuecomment-94579191
Overall, this looks nice. Thanks! Could you possibly add an integration
test that verifies that you can use the new methods to start up a
MiniAccumuloCluster
Github user tanadeau commented on the pull request:
https://github.com/apache/accumulo/pull/29#issuecomment-94579312
That makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user tanadeau commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28733796
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28733986
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28734323
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28732817
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28733538
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
GitHub user tanadeau opened a pull request:
https://github.com/apache/accumulo/pull/29
ACCUMULO-3000: Added config option and impl to use existing ZooKeeper
This creates a new MAC config option `existingZooKeepers` that can be
optionally set to a ZK connection string (e.g.,
Github user tanadeau commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28733135
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28750135
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28747812
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28750186
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28750299
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig
54 matches
Mail list logo
