Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2015-01-09 Thread keith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29502/#review67526 --- Ship it! Ship It! - kturner On Jan. 9, 2015, 3:11 a.m., Corey

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2015-01-08 Thread Corey Nolet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29502/ --- (Updated Jan. 9, 2015, 3:11 a.m.) Review request for accumulo, Christopher

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2015-01-07 Thread Corey Nolet
On Jan. 1, 2015, 12:36 a.m., kturner wrote: core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReader.java, line 78 https://reviews.apache.org/r/29502/diff/2/?file=804700#file804700line78 was putting @Override on same line as method decleration intentional?

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2015-01-07 Thread keith
On Jan. 1, 2015, 12:36 a.m., kturner wrote: core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReader.java, line 78 https://reviews.apache.org/r/29502/diff/2/?file=804700#file804700line78 was putting @Override on same line as method decleration intentional?

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2015-01-06 Thread keith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29502/#review66908 --- test/src/test/java/org/apache/accumulo/test/ScanIteratorIT.java

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2015-01-06 Thread Corey Nolet
On Jan. 5, 2015, 9:09 p.m., Christopher Tubbs wrote: core/src/test/java/org/apache/accumulo/core/iterators/FirstEntryInRowIteratorTest.java, line 63 https://reviews.apache.org/r/29502/diff/2/?file=804705#file804705line63 Should this be Authorizations.EMPTY? Or should it have a

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2015-01-06 Thread Corey Nolet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29502/ --- (Updated Jan. 6, 2015, 3:44 p.m.) Review request for accumulo, Christopher

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2015-01-06 Thread Corey Nolet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29502/ --- (Updated Jan. 6, 2015, 3:54 p.m.) Review request for accumulo, Christopher

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2015-01-06 Thread Christopher Tubbs
On Jan. 5, 2015, 4:09 p.m., Christopher Tubbs wrote: core/src/test/java/org/apache/accumulo/core/iterators/FirstEntryInRowIteratorTest.java, line 63 https://reviews.apache.org/r/29502/diff/2/?file=804705#file804705line63 Should this be Authorizations.EMPTY? Or should it have a

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2015-01-05 Thread Christopher Tubbs
On Dec. 31, 2014, 7:36 p.m., kturner wrote: core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReader.java, line 78 https://reviews.apache.org/r/29502/diff/2/?file=804700#file804700line78 was putting @Override on same line as method decleration intentional?

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2015-01-05 Thread Christopher Tubbs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29502/#review66725 ---

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2015-01-05 Thread Christopher Tubbs
On Jan. 5, 2015, 4:09 p.m., Christopher Tubbs wrote: core/src/test/java/org/apache/accumulo/core/iterators/FirstEntryInRowIteratorTest.java, line 63 https://reviews.apache.org/r/29502/diff/2/?file=804705#file804705line63 Should this be Authorizations.EMPTY? Or should it have a

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2014-12-31 Thread Corey Nolet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29502/ --- (Updated Dec. 31, 2014, 1:46 p.m.) Review request for accumulo, Christopher

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2014-12-31 Thread Corey Nolet
On Dec. 31, 2014, 4:30 a.m., Josh Elser wrote: core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java, line 197 https://reviews.apache.org/r/29502/diff/1/?file=804415#file804415line197 Can't you pull this from the Scanner? I didn't see a good way to

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2014-12-31 Thread Corey Nolet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29502/ --- (Updated Dec. 31, 2014, 10:40 a.m.) Review request for accumulo, Christopher

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2014-12-31 Thread keith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29502/#review66493 ---

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2014-12-30 Thread Corey Nolet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29502/ --- (Updated Dec. 31, 2014, 4:05 a.m.) Review request for accumulo, Christopher

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2014-12-30 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29502/#review66439 --- Neat stuff, Corey!