Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/#review71241 --- Ship it! Ship It! - Christopher Tubbs On Jan. 9, 2015, 4:39 p.m.

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/ --- (Updated Jan. 9, 2015, 9:39 p.m.) Review request for accumulo. Changes --

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/#review67491 --- core/src/main/java/org/apache/accumulo/core/file/rfile/VisMetricsGa

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/ --- (Updated Jan. 9, 2015, 4:19 p.m.) Review request for accumulo. Changes --

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/#review67440 --- Ship it! Ship It! - kturner On Jan. 8, 2015, 9:24 p.m., Jenna Hu

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/#review67318 --- Ship it! LGTM -- I'll leave some time for other reviewers to add mo

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/ --- (Updated Jan. 8, 2015, 9:24 p.m.) Review request for accumulo. Changes --

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/#review66906 --- core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGathe

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

> On Dec. 18, 2014, 12:20 p.m., Christopher Tubbs wrote: > > core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java, > > line 34 > > > > > > It'd be neat if there were a MetricsGatherer interface,

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

> On Dec. 18, 2014, 5:20 p.m., Christopher Tubbs wrote: > > core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java, > > line 34 > > > > > > It'd be neat if there were a MetricsGatherer interface, w

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/#review66882 --- core/src/test/java/org/apache/accumulo/core/file/rfile/RFileMetrics

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/ --- (Updated Dec. 22, 2014, 3:25 p.m.) Review request for accumulo. Changes -

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/ --- (Updated Dec. 22, 2014, 3:22 p.m.) Review request for accumulo. Changes -

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

> On Dec. 18, 2014, 4:19 p.m., Josh Elser wrote: > > core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java, > > line 36 > > > > > > Why the concurrent maps? I don't see anything in these changes t

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/ --- (Updated Dec. 18, 2014, 9:37 p.m.) Review request for accumulo. Changes -

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

> On Dec. 18, 2014, 4:19 p.m., Josh Elser wrote: > > core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java, > > line 36 > > > > > > Why the concurrent maps? I don't see anything in these changes t

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

> On Dec. 18, 2014, 4:19 p.m., Josh Elser wrote: > > core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java, > > line 36 > > > > > > Why the concurrent maps? I don't see anything in these changes t

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

> On Dec. 18, 2014, 4:19 p.m., Josh Elser wrote: > > core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java, > > line 36 > > > > > > Why the concurrent maps? I don't see anything in these changes t

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

> On Dec. 18, 2014, 11:19 a.m., Josh Elser wrote: > > core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java, > > line 94 > > > > > > What does hashing the visibility label get you? If you can invo

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/#review65502 --- core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGathe

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/#review65499 --- A unit test would be nice. There's a few dangling whitespace at end

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/#review65498 --- core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGathe

Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/ --- Review request for accumulo. Bugs: ACCUMULO-3420 https://issues.apache.org/