[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-06-03 Thread gaohoward
Github user gaohoward commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-108721184 That'll be great. I'll update the branch soon and you can have a look. Thanks. --- If your project is set up for it, you can reply to this email and have your

[GitHub] activemq-artemis pull request: Connection Factory updates

2015-06-03 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/15#issuecomment-108713131 I will need to update this PR. I used the wrong super class for the tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-06-03 Thread thiagokronig
Github user thiagokronig commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-108712726 I am all forward for reusing code/ideas for tests from ActiveMQ! We can accomplish that with an objective in mind: don't replicate/depend on ActiveMQ, just

[GitHub] activemq-artemis pull request: Connection Factory updates

2015-06-03 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/15#discussion_r31691246 --- Diff: tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/ConnectionTest.java --- @@ -65,6 +67,33 @@ public void testMany

[GitHub] activemq-artemis pull request: ARTEMIS-119 Upgraded to Jetty 9.2.

2015-06-03 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/16#issuecomment-108704993 The server doesn't start it for some reason: I built the server, create the server, ran it and got an exception ```sh cd artemis-dis

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-06-03 Thread gaohoward
Github user gaohoward commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-108702094 @thiagokronig Hi Thiago right now I'm trying to get rid of the activemq 5 source code, only have a few classes to wrap the Artemis broker for the test. There a

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-06-03 Thread gaohoward
Github user gaohoward commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-108700719 @clebertsuconic sure I'll. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-06-03 Thread gaohoward
Github user gaohoward commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-108699289 https://github.com/apache/activemq-artemis/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

Re: [DISCUSSION] Artemis 1.0.1 Release

2015-06-03 Thread Clebert
The jetty is used when the server is executed. -- Clebert Suconic typing on the iPhone. > On Jun 3, 2015, at 22:14, John D. Ament wrote: > > Actually its only a minor change. However, it seems like the current Jetty > runner doesn't do anything. I ran mvn jetty:run from the artemis-web > pr

[GitHub] activemq-artemis pull request: ARTEMIS-119 Upgraded to Jetty 9.2.

2015-06-03 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/16 ARTEMIS-119 Upgraded to Jetty 9.2. You can merge this pull request into a Git repository by running: $ git pull https://github.com/johnament/activemq-artemis ARTEMIS-119 Alternativ

Re: [DISCUSSION] Artemis 1.0.1 Release

2015-06-03 Thread John D. Ament
Actually its only a minor change. However, it seems like the current Jetty runner doesn't do anything. I ran mvn jetty:run from the artemis-web project, and while Jetty started there was no content. Is this intentional? John On Wed, Jun 3, 2015 at 9:57 PM John D. Ament wrote: > Fair enough.

Re: [DISCUSSION] Artemis 1.0.1 Release

2015-06-03 Thread John D. Ament
Fair enough. I can look at Jetty 9 probably tomorrow if I had to guess. John On Wed, Jun 3, 2015 at 9:34 PM Clebert Suconic wrote: > ARTEMIS-120 was a copy and paste error.. I meant ARTEMIS-119. > > I tried to simply update the version but there is some API changes so > it wasn't a simple upda

[GitHub] activemq-artemis pull request: Connection Factory updates

2015-06-03 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/15#discussion_r31688005 --- Diff: tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/ConnectionTest.java --- @@ -65,6 +67,33 @@ public void testManyConne

[GitHub] activemq-artemis pull request: Connection Factory updates

2015-06-03 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/15 Connection Factory updates This is a dependency for me on the examples work You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebe

Re: [DISCUSSION] Artemis 1.0.1 Release

2015-06-03 Thread Clebert Suconic
ARTEMIS-120 was a copy and paste error.. I meant ARTEMIS-119. I tried to simply update the version but there is some API changes so it wasn't a simple update. On Wed, Jun 3, 2015 at 9:32 PM, John D. Ament wrote: > Clebert, > > I'm assuming you meant the upgrade to Netty, not Jetty. Unless you a

[GitHub] activemq-artemis pull request: ARTEMIS-120 Upgraded Netty to lates...

2015-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: [DISCUSSION] Artemis 1.0.1 Release

2015-06-03 Thread John D. Ament
Clebert, I'm assuming you meant the upgrade to Netty, not Jetty. Unless you also want to upgrade to Jetty 9.2 as well (seems like there's a mix of 8.1 and 6 in the code base). Anyways PR is open. John On Wed, Jun 3, 2015 at 8:38 PM Clebert Suconic wrote: > I did some admin on the JIRAs, cl

[GitHub] activemq-artemis pull request: ARTEMIS-120 Upgraded Netty to lates...

2015-06-03 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/14 ARTEMIS-120 Upgraded Netty to latest 4.0.x. You can merge this pull request into a Git repository by running: $ git pull https://github.com/johnament/activemq-artemis ARTEMIS-120 A

[DISCUSSION] Artemis 1.0.1 Release

2015-06-03 Thread Clebert Suconic
I did some admin on the JIRAs, cleaning solved ones, etc... and I believe this could be a nice plan for a 1.0.1 (* link at the end of the message). My idea was to fix examples, small issues and improve usability. We would start adding openWire tests and have 1.1.0 a bit more substantial on OpenWi

[GitHub] activemq-artemis pull request: ARTEMIS-19 allow disabling of messa...

2015-06-03 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/13#issuecomment-108646136 @jbertram please don't forget to resolve the JIRA and make sure it's on 1.0.1 --- If your project is set up for it, you can reply to this email and hav

[GitHub] activemq-artemis pull request: ARTEMIS-19 allow disabling of messa...

2015-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] activemq-artemis pull request: ARTEMIS-19 allow disabling of messa...

2015-06-03 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/13#issuecomment-108526486 I see that you changed a lot of tests.. but I didn't see any new tests validating the added semantic? did I miss anything there? --- If your project is

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-06-03 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-108499190 @gaohoward you will probably need to tell Thiago on specifics where he could help you. It's hard to split a task like without duplicating/wasting work, w

[GitHub] activemq-artemis pull request: removing wrong comment

2015-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] activemq-artemis pull request: ARTEMIS-19 allow disabling of messa...

2015-06-03 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/13 ARTEMIS-19 allow disabling of message load-balancing Clebert, please be sure to check the modifications to org.apache.activemq.artemis.core.postoffice.impl.BindingsImpl.getNextBinding() I

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-06-03 Thread gaohoward
Github user gaohoward commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-108464364 Hi Thiago Kronig, it'll be great if you can lend a hand. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] activemq-artemis pull request: ARTEMIS-129 License header should b...

2015-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-06-03 Thread thiagokronig
Github user thiagokronig commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-108443642 Hi, Howard Gao, if you wish, we could work together on this. On Wed, Jun 3, 2015 at 8:46 AM Howard Gao wrote: > Hi Martyn, what you su

[GitHub] activemq-artemis pull request: ARTEMIS-129 License header should b...

2015-06-03 Thread thiagokronig
Github user thiagokronig commented on the pull request: https://github.com/apache/activemq-artemis/pull/11#issuecomment-108447524 Feel free to do so! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] activemq-artemis pull request: ARTEMIS-129 License header should b...

2015-06-03 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/11#issuecomment-108447089 I will amend your commit with a comment: s/Only .java and the following files should be modified/These files had to be modified manually --- If

[GitHub] activemq-artemis pull request: removing wrong comment

2015-06-03 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/12 removing wrong comment this is just removing a typo from the pom I introduced on my last PR You can merge this pull request into a Git repository by running: $ git pull https://

[GitHub] activemq pull request: [AMQ-5821] Avoid probing of classes in Acti...

2015-06-03 Thread cschneider
GitHub user cschneider opened a pull request: https://github.com/apache/activemq/pull/107 [AMQ-5821] Avoid probing of classes in Activator You can merge this pull request into a Git repository by running: $ git pull https://github.com/cschneider/activemq AMQ-5821 Alternativel

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-06-03 Thread gaohoward
Github user gaohoward commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-108329879 Hi Martyn, what you suggested makes sense for sure. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-06-03 Thread mtaylor
Github user mtaylor commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-108295200 Hi Howard. I realise that @clebertsuconic already mentioned this but it looks like you are importing a lot of code from ActiveMQ. Reuse of test suites is prob