[GitHub] activemq-artemis issue #1361: ARTEMIS-1248 Reduce garbage while Paging

2017-06-22 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1361 @clebertsuconic There is no need to use a ThreadLocal or a pooled buffer there because: 1) the method (write/read) is synchronized and it is safe to reuse the same ByteBuf wrapper be

[GitHub] activemq-artemis issue #1361: ARTEMIS-1248 Reduce garbage while Paging

2017-06-22 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1361 @franz1981 I see.. you could still use a ThreadLocal there.. right? also: Why don't you use a PooledBuffer on the write? --- If your project is set up for it, you can reply

[GitHub] activemq-artemis issue #1361: ARTEMIS-1248 Reduce garbage while Paging

2017-06-22 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1361 @clebertsuconic yep agree on the read side: I've done it just for completeness, but the biggest gain (measured) is on the write path. I've changed the sequence of writing too to be only

[GitHub] activemq-artemis issue #1293: ARTEMIS-1194: SOCKS proxy support

2017-06-22 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1293 @adagys we still need a way to test it though.. I looked at their website and it seems to support SOCKS.. but I didn't figure out how. I think we should remove the option yo

[GitHub] activemq-artemis issue #1361: ARTEMIS-1248 Reduce garbage while Paging

2017-06-22 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1361 @franz1981 if you were using a thread local on activeMQBuffer and unsafeByteBufWrapper I would agree with you on saving GC. however... Page won't last much longer on a regul

Re: discard DLQ messages

2017-06-22 Thread Timothy Bish
On 06/22/2017 01:00 PM, srramu45 wrote: Thanks Tabish for quick reply. After making the changes. I have not purged the messages from DLQ.Can I go ahead and do it ? -- View this message in context: http://activemq.2283324.n4.nabble.com/discard-DLQ-messages-tp4727710p4727795.html Sent from

Re: discard DLQ messages

2017-06-22 Thread srramu45
Thanks Tabish for quick reply. After making the changes. I have not purged the messages from DLQ.Can I go ahead and do it ? -- View this message in context: http://activemq.2283324.n4.nabble.com/discard-DLQ-messages-tp4727710p4727795.html Sent from the ActiveMQ - Dev mailing list archive at

Re: [DISCUSS] - Propose new sub-project activemq-extras

2017-06-22 Thread Clebert Suconic
I think it will make sense a different project... for instance: if we make journal a pluggable component there, we could have a JournalQueue and JournalHashMap to support some sort of client side persistence.. @John: you're the man here.. how we can get this rolling? On Wed, Jun 21, 2017 at 2:31

[GitHub] activemq-artemis pull request #1307: [ARTEMIS-1196] Fix missing JSON support

2017-06-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1307 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis pull request #1307: [ARTEMIS-1196] Fix missing JSON support

2017-06-22 Thread gnodet
Github user gnodet commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1307#discussion_r123559429 --- Diff: artemis-features/src/main/resources/features.xml --- @@ -54,8 +54,8 @@ mvn:org.jboss.logging/jboss-logging/${jboss.logging

[GitHub] activemq-artemis pull request #1361: ARTEMIS-1248 Reduce garbage while Pagin...

2017-06-22 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/1361 ARTEMIS-1248 Reduce garbage while Paging You can merge this pull request into a Git repository by running: $ git pull https://github.com/franz1981/activemq-artemis pooled_activem

[GitHub] activemq-artemis pull request #1307: [ARTEMIS-1196] Fix missing JSON support

2017-06-22 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1307#discussion_r123557009 --- Diff: artemis-features/src/main/resources/features.xml --- @@ -54,8 +54,8 @@ mvn:org.jboss.logging/jboss-logging/${jboss

[GitHub] activemq-artemis pull request #1345: ARTEMIS-1235 Support queue and address ...

2017-06-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1345 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis issue #1348: ARTEMIS-1237 - Hard coded timeout on Journal f...

2017-06-22 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1348 can you close this please? merged with a rebase! apache bot won't close 1.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] activemq-artemis pull request #1358: ARTEMIS-1244 propagate retain flag of r...

2017-06-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1358 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis pull request #1357: ARTEMIS-607 New tests AMQP,MQTT,Stomp i...

2017-06-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1357 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis pull request #1345: ARTEMIS-1235 Support queue and address ...

2017-06-22 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1345#discussion_r123536227 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -2313,6 +2318,53 @@ pri

[GitHub] activemq-artemis pull request #1359: ARTEMIS-1237 - Hard coded timeout on Jo...

2017-06-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1359 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis issue #1360: ARTEMIS-1247 - Allow to enable replicated jour...

2017-06-22 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1360 @rpelisse take a look on master.. I'm cherry-picking on 1.x (just because I actually need it :) ) --- If your project is set up for it, you can reply to this email and have your re

[GitHub] activemq-artemis issue #1360: ARTEMIS-1247 - Allow to enable replicated jour...

2017-06-22 Thread rpelisse
Github user rpelisse commented on the issue: https://github.com/apache/activemq-artemis/pull/1360 @clebertsuconic cool, let me know if I can help ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] activemq-artemis pull request #1360: ARTEMIS-1247 - Allow to enable replicat...

2017-06-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1360 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis issue #1360: ARTEMIS-1247 - Allow to enable replicated jour...

2017-06-22 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1360 this is old code.. before we used tracing and logging... I will send a better commit now. --- If your project is set up for it, you can reply to this email and have yo

[GitHub] activemq-artemis pull request #1345: ARTEMIS-1235 Support queue and address ...

2017-06-22 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1345#discussion_r123517809 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -2313,6 +2318,53 @@

[GitHub] activemq-artemis issue #1332: ARTEMIS-1227 Internal properties not removed f...

2017-06-22 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1332 This is being reverted... following up a discussion on the legacy hornetq codebase: https://github.com/hornetq/hornetq/pull/2114 --- If your project is set up for it, you

Re: discard DLQ messages

2017-06-22 Thread Timothy Bish
On 06/21/2017 04:23 PM, srramu45 wrote: DLQ messages occupying the KahaDB space and recenlty we have added below entry and this dont fix the issues. How to discard the DLQ messages ? -- View this message in context: http://activemq.2283324.n4.nabble.com/discard-DLQ-messages-tp4727710.html

Re: org.apache.activemq.artemis.core.journal.impl.JournalImpl

2017-06-22 Thread Clebert Suconic
On Thu, Jun 22, 2017 at 9:41 AM, Justin Bertram wrote: > It's also worth noting that paging is a palliative measure. The broker is > not designed to be consistently in a state where production > consumption > such that more and more messages keep accumulating. Paging is meant to > provide tempor

Re: org.apache.activemq.artemis.core.journal.impl.JournalImpl

2017-06-22 Thread Justin Bertram
I stand corrected. I forgot about this fairly new feature. Cheers! Justin On Thu, Jun 22, 2017 at 8:29 AM, Martyn Taylor wrote: > There's no way to explicitly limit the number of page files. However, you > can set the "max-disk-usage" parameter[1][2]. Once this limit is reached, > the brok

Re: org.apache.activemq.artemis.core.journal.impl.JournalImpl

2017-06-22 Thread Justin Bertram
It's also worth noting that paging is a palliative measure. The broker is not designed to be consistently in a state where production > consumption such that more and more messages keep accumulating. Paging is meant to provide temporary relief. If you find that production > consumption more ofte

Re: org.apache.activemq.artemis.core.journal.impl.JournalImpl

2017-06-22 Thread Martyn Taylor
There's no way to explicitly limit the number of page files. However, you can set the "max-disk-usage" parameter[1][2]. Once this limit is reached, the broker will use flow control to stop the clients sending more messages (this is the same as BLOCK policy). If the protocol being used does not s

Re: org.apache.activemq.artemis.core.journal.impl.JournalImpl

2017-06-22 Thread nigro_franz
Hi, I've just rolled out a couple of improvements on Paging: right now are on the latest master so you could try if it works for you... regards, Franz -- View this message in context: http://activemq.2283324.n4.nabble.com/org-apache-activemq-artemis-core-journal-impl-JournalImpl-tp4726923p472

Re: org.apache.activemq.artemis.core.journal.impl.JournalImpl

2017-06-22 Thread Justin Bertram
There is no limit on the amount of disk space paged data can consume. Justin On Thu, Jun 22, 2017 at 1:29 AM, Sergey Zagalskiy wrote: > Hi, team! > Could you, please, clarify me, are there any options for configuration > limits of disk space for paged messages? > How will behave artemis, when

Re: org.apache.activemq.artemis.core.journal.impl.JournalImpl

2017-06-22 Thread Sergey Zagalskiy
Hi, team! Could you, please, clarify me, are there any options for configuration limits of disk space for paged messages? How will behave artemis, when this limit will exceed? Are there any optinos for this behaviour configuration? Perhaps, there are some best practices for limiting disk space for

[GitHub] activemq-artemis pull request #1345: ARTEMIS-1235 Support queue and address ...

2017-06-22 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1345#discussion_r123497890 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -2313,6 +2318,53 @@ pri

[GitHub] activemq-artemis pull request #1345: ARTEMIS-1235 Support queue and address ...

2017-06-22 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1345#discussion_r123486475 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -2313,6 +2318,53 @@

[GitHub] activemq-artemis pull request #1358: ARTEMIS-1244 propagate retain flag of r...

2017-06-22 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1358#discussion_r123484532 --- Diff: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTPublishManager.java ---

[GitHub] activemq-artemis pull request #1345: ARTEMIS-1235 Support queue and address ...

2017-06-22 Thread mtaylor
Github user mtaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1345#discussion_r123480175 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -2313,6 +2318,53 @@ private vo

[GitHub] activemq-artemis pull request #1358: ARTEMIS-1244 propagate retain flag of r...

2017-06-22 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1358#discussion_r123471949 --- Diff: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTPublishManager.java --- @@ -2

[GitHub] activemq-artemis pull request #1360: ARTEMIS-1247 - Allow to enable replicat...

2017-06-22 Thread rpelisse
GitHub user rpelisse opened a pull request: https://github.com/apache/activemq-artemis/pull/1360 ARTEMIS-1247 - Allow to enable replicated journal (not only at compilation time) Issue: https://issues.apache.org/jira/browse/ARTEMIS-1247 Upstream Issue (Widfly): https://issues.jbo

[GitHub] activemq-artemis pull request #1358: ARTEMIS-1244 propagate retain flag of r...

2017-06-22 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1358#discussion_r123442277 --- Diff: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTPublishManager.java ---

[GitHub] activemq-artemis issue #1348: ARTEMIS-1237 - Hard coded timeout on Journal f...

2017-06-22 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1348 https://github.com/apache/activemq-artemis/pull/1359 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] activemq-artemis pull request #1359: ARTEMIS-1237 - Hard coded timeout on Jo...

2017-06-22 Thread andytaylor
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/1359 ARTEMIS-1237 - Hard coded timeout on Journal file open Make timeout configurable https://issues.apache.org/jira/browse/ARTEMIS-1237 You can merge this pull request into a Git

[GitHub] activemq-artemis issue #1357: ARTEMIS-607 New tests AMQP,MQTT,Stomp intercep...

2017-06-22 Thread michalxo
Github user michalxo commented on the issue: https://github.com/apache/activemq-artemis/pull/1357 @jdanekrh has made a patch for ARTEMIS-1244 issue. So this can be solved if PR is correct & accepted. --- If your project is set up for it, you can reply to this email and have your repl