Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1684
@RaiSaurabh this isn't what was quite meant, the idea of implementing
Message is to avoid conversion, so it only needs to convert if cross protocol
on consume. You have only ext
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1684
e.g.
```
public class OpenwireMessage extends RefCountMessage {
org.apache.activemq.command.Message message;
public OpenwireMessage(org.ap
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1684
@michaelandrepearce Thanks, I got the context now will try to update the
code and test.
---
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/1724
NO-JIRA Add openwire temp queue cluster test
The test makes sure temp queue from openwire
works in a clustered environment.
You can merge this pull request into a Git repository by
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1719
looks good will merge
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1719
---
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1722
@michaelandrepearce In general I think this looks good.
The only thing I am not seeing here is backwards compat between the new
client and an old server. There are two ways you
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1723
@jdanekrh There are still a couple of example using the old name, I will
fix up and merge. Cheers
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1722#discussion_r157459675
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/Packet.java
---
@@ -42,6 +42,21 @@ default int expec
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1723
Forget that last comment. My environment was dirty. Merging as it is.
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1723
---
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1720
@pgfox This wasn't your fault. I merged your work Pat, then Justin's right
after, (reviewing them seperately) not realising that Justin's MD changes
didn't (couldn't have) included your e
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1720
---
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1725
ARTEMIS-1329 testNoLocalReconnect was failing with OpenWire protocol
Can anybody review this? This fixes the issue, but I find it weird to
assign client ID to CID (connection ID) prope
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1722
I would like to see a compatibility test added on the testsuite Iâm
working on. I can help with that.
---
Github user stanlyDoge closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1644
---
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1644
This has been fixed via another PR. Closing.
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1722#discussion_r157483149
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ResponseCache.java
---
@@ -0,0 +1,85 @@
+/*
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1722#discussion_r157484426
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ResponseCache.java
---
@@ -0,0 +1,85 @@
+/*
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1722#discussion_r157484631
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ResponseCache.java
---
@@ -0,0 +1,85 @@
+/*
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1722#discussion_r157484746
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/Packet.java
---
@@ -42,6 +42,21 @@ default
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1722#discussion_r157485298
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ServerPacketDecoder.java
---
@@ -115,6 +123,8 @@ public Packet
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1722#discussion_r157485654
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ResponseCache.java
---
@@ -0,0 +1,85 @
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1722#discussion_r157486228
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ServerPacketDecoder.java
---
@@ -115,6 +123,8 @@ publ
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1722
@mtaylor i was thinking on option 2, because i didn't know i could safely
do option 1, are you confirming it would be safe to do that then? If so Bingo,
I'm doing option 1 :)
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1722
@clebertsuconic agreed, need some more tests, i was waiting a little like
@mtaylor and yourself have said for you're PR to merge first, as ill have some
conflicts ill need to so
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1722#discussion_r157487888
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ServerPacketDecoder.java
---
@@ -115,6 +123,8 @@ public P
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1722
1. Should be fine. Just add an if when you're decoding to check that
there's data on the buffer when you're decoding. If yes, try to decode the
rest, if not then set the defaults. I've
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1722#discussion_r157488380
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ServerPacketDecoder.java
---
@@ -115,6 +123,8 @@ publ
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1722#discussion_r157496805
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ResponseCache.java
---
@@ -0,0 +1,85 @@
+/*
+1 (non-binding)
On Fri, Dec 15, 2017 at 4:24 PM, Matt Pavlovich wrote:
> +1 for updating the website to communicate to users that Apollo is no
> longer in active development.
>
> +1 for going ahead and making repo read-only. If on-going interest in
> making changes arises, it could start out as
+5 Binding votes
(Arthur, Bruce, Clebert, Martyn, Christian Shannon)
+4 Non Binding votes
(Francois, Howard, Matt Pavlovich, Richard Kettelerj)
Before sending this Vote, I also had positive feedback from PMC about this move.
so, I'm confident this is approved by the PMC and Community.
We shoul
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-web/pull/1
Auto Generated MD files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-web md
Alternatively you can
I’ve had some luck auto generating MD files.
Needs some cleanup which probably the worst can be bash scripted.
Have sent a PR back to the activemq-web on github for others to see.
Mike
Sent from my iPhone
> On 14 Dec 2017, at 16:31, Bruce Snyder wrote:
>
> Thanks, Dan. So far I only see the
Github user bsnyder commented on the issue:
https://github.com/apache/activemq-web/pull/1
This conversion looks pretty good for the most part. We will still need to
manually rebuild any valid tables.
---
Nice job, based on my spot check of a handful of files, it looks much
better. But we will still need to manually fix all the valid tables.
Have you had a chance to look at the other branches that Dan Kulp provided?
Bruce
On Mon, Dec 18, 2017 at 10:59 AM, Michael André Pearce <
michael.andre.pea.
Yeah, unfortunately the tool i found wanted just html it blew up when trying to
use modified.
Like wise there was a couple of pages it couldn’t convert due to a css file on
import issue but this wasn’t that many.
Sent from my iPhone
> On 18 Dec 2017, at 19:15, Bruce Snyder wrote:
>
> Nice jo
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-web/pull/2
Md cleanup
with some manual bash script cleanup (e.g. remove repeated nav, footers
etc that should be outside the md files in new site setup.
You can merge this pull request into a
Github user asfgit closed the pull request at:
https://github.com/apache/activemq/pull/226
---
I'm adding a new testsuite in Artemis, to validate compatibility
between versions.
this is using a maven plugin I had written some time ago, that will
scan dependencies, generating a classpath. This maven plugin can also
accept the repository urls.. so you can tweak it a little bit.
The testsuit
I got so deeply involved with the compatibility issue I was working
on.. and the year is already gone for me...
I will try this around 2nd week of Jan.
On Fri, Dec 8, 2017 at 3:30 AM, Francesco Nigro wrote:
> +1 I've had something similar with Clebert in the past and it was very
> useful indeed
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1713
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1659
@michaelandrepearce perhaps we could add a wrapper for tomcat..
SerialWrapper... so we could add the wrapper on the context.xml instead of the
connectionFactory and use read and wri
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1659
@michaelandrepearce I just added the testsuite I was after...
And as I suspected.. it breaks the serialization wire compatibility.
Isn't there a way we could us
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1725
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1712
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1697
@stanlyDoge I believe this is breaking the compatiblity testsuite I just
added...
I'm glad I did :)
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1697
@stanlyDoge actually.. my bad.. I had something wrong...
At least I'm watching it ! :)
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1697
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1659
The point here is to be inline with 5.x implementation to make migration
for users seemless as possible.
This shouldnât break any compatibility if it does let me know
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1659
Can we merge this it has been some time now?
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq/pull/228
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1659
@michaelandrepearce a connection factory serialized with 1.4 won't open
with master. Wires are not compatible.
I know for instance that Wildfly uses that...
So, per
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1659
@clebertsuconic so i run this, but even on master at your last merge (e.g.
none of these changes) i get 15 errors in mesh test.
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1659
@clebertsuconic just pushed with fixes, as noted i locally get 15 errors
with your new mesh test, but i also get this with master at point of your
merge. Serialisation tests pas
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1659
just looking at jenkins, seems
https://builds.apache.org/job/ActiveMQ-Artemis-PR-Build/4638/ it also failing
on same mesh tests, so I'm ignoring that for now.
---
56 matches
Mail list logo
