Github user jmesnil commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1764#discussion_r160605068
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java
---
@@ -188,13 +189,15 @@ public
Github user jmesnil commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1764#discussion_r160605042
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java
---
@@ -95,6 +95,7 @@ public voi
Github user jmesnil commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1764#discussion_r160605094
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java
---
@@ -188,13 +189,15 @@ public
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1757
@franz1981 done, also spotted a few wasteful bits in AMQP as well, where it
went from String to SimpleString, back to String and back to SimpleString (or
repeatedly created Simp
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1764#discussion_r160573966
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java
---
@@ -143,6 +143,8 @@ public v
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/1764
ARTEMIS-1595 Fixing serialization issues between Artemis 1.5 and master
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cleber
I will send the video tomorrow.
On Tue, Jan 9, 2018 at 3:00 PM Christopher Shannon <
christopher.l.shan...@gmail.com> wrote:
> I won't be able to make it today but I'll be sure to check out the replay,
> thanks again Clebert.
>
> On Tue, Jan 9, 2018 at 11:46 AM, Michael André Pearce <
> michael.a
I won't be able to make it today but I'll be sure to check out the replay,
thanks again Clebert.
On Tue, Jan 9, 2018 at 11:46 AM, Michael André Pearce <
michael.andre.pea...@me.com> wrote:
> Great cannot wait.
>
> And thanks in advance.
>
>
> We shall have to tweet your video!
>
> Sent from my iP
Thank you, Justin.
Bruce
On Tue, Jan 9, 2018 at 12:24 PM, Justin Bertram wrote:
> I added a bullet point for the Artemis 2.4.0 release.
>
>
> Justin
>
> On Tue, Jan 9, 2018 at 1:20 PM, Bruce Snyder
> wrote:
>
> > Hi Mike,
> >
> > Hmm, I'm not sure why you would not be able to edit the wiki pag
Sorry about this, Mike. I have added it to the current report.
Bruce
On Tue, Jan 9, 2018 at 10:00 AM, Michael André Pearce <
michael.andre.pea...@me.com> wrote:
> One other I’m not personally fussed.
>
> But I noted that in last report it was omitted that I was added as a
> committer. Not sure i
I added a bullet point for the Artemis 2.4.0 release.
Justin
On Tue, Jan 9, 2018 at 1:20 PM, Bruce Snyder wrote:
> Hi Mike,
>
> Hmm, I'm not sure why you would not be able to edit the wiki page. I did
> not restrict it in any way.
>
> Anyhow, thank you very much for the contributions. I will a
Hi Mike,
Hmm, I'm not sure why you would not be able to edit the wiki page. I did
not restrict it in any way.
Anyhow, thank you very much for the contributions. I will add these to the
report.
Bruce
On Tue, Jan 9, 2018 at 9:55 AM, Michael André Pearce <
michael.andre.pea...@me.com> wrote:
> Hi
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1759
This looks OK to me. @mtaylor, will you review this since you opened the
JIRA?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1754
I ran the PR build myself and it succeeded. It's been so long since the
failure that the artifacts have been removed so I can't see why it failed
originally.
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1751
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1757
@michaelandrepearce I'm not sure I will be present honestly due to some
backlog of work to finish first, I hope to finish soon and I will join for sure!
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1757
@franz1981 I've spotted something else the ActiveMQMessage wraps Strings
into SimpleStrings instead of calling the core Message string equiv methods, as
such its not getting the
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1763
ARTEMIS-1594 don't log dlq/expiry warn for internal q
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTE
One other I’m not personally fussed.
But I noted that in last report it was omitted that I was added as a committer.
Not sure if formally it was meant to have been reported or noted, and if any
correction needs to be made in this one
Sent from my iPhone
> On 9 Jan 2018, at 16:55, Michael André
Hi Bruce I can’t seem to edit the wiki.
Anyhow I think should mention Clebert’s web conference of a broker walk through
that’s happening tonight.
Also should mention the web console for artemis has had good adoption with
contributors beyond that of the originals joining in.
Cheers
Mike
Sent f
Great cannot wait.
And thanks in advance.
We shall have to tweet your video!
Sent from my iPhone
> On 9 Jan 2018, at 15:08, Clebert Suconic wrote:
>
> this will be done today at 3 PM EST (5 hours from the time I'm sending
> this email)
>
>
> I will be using bluejeans, which is an app I us
Github user mbukosky commented on the issue:
https://github.com/apache/activemq-artemis/pull/1534
@jbertram perfect. Thanks for the help. I'll wait until the 2.5.0 release.
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1757
@franz1981 i have now rebased again this brach, after merging
https://github.com/apache/activemq-artemis/pull/1760 - if you wanted to check
it out, and re-test.
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1758
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1534
@mbukosky, please note that a bug regarding this change was just resolved.
See #1750.
---
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1534
@mbukosky Hi, could you open a JIRA here:
https://issues.apache.org/jira/projects/ARTEMIS. You can add a description of
the issue and potential solution. Also a PR with the fix would be
Github user mbukosky commented on the issue:
https://github.com/apache/activemq-artemis/pull/1534
I found a bug with this change. I also have a possible solution. How should
I got about requesting a fix? Thanks
---
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1762
ARTEMIS-1580 Browsing in hawtio console does not allow to show empty â¦
â¦pages
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/s
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1756#discussion_r160451205
--- Diff: artemis-jdbc-store/src/main/resources/journal-sql.properties ---
@@ -0,0 +1,63 @@
+# Generic SQL statements
--- End diff --
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1760
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1758#discussion_r160436610
--- Diff:
tests/compatibility-tests/src/main/resources/servers/hornetqServer.groovy ---
@@ -19,7 +23,7 @@ import org.hornetq.core.config.im
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1758#discussion_r160434660
--- Diff:
tests/compatibility-tests/src/main/resources/exportimport/import1X.groovy ---
@@ -0,0 +1,11 @@
+import org.apache.activemq.ar
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1758#discussion_r160433959
--- Diff:
tests/compatibility-tests/src/main/resources/exportimport/import1X.groovy ---
@@ -0,0 +1,11 @@
+import org.apache.activemq.ar
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1758#discussion_r160434008
--- Diff:
tests/compatibility-tests/src/main/resources/exportimport/import1X.groovy ---
@@ -0,0 +1,11 @@
+import org.apache.activemq.ar
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1758#discussion_r160433884
--- Diff:
tests/compatibility-tests/src/main/resources/servers/hornetqServer.groovy ---
@@ -19,7 +23,7 @@ import org.hornetq.core.config.im
this will be done today at 3 PM EST (5 hours from the time I'm sending
this email)
I will be using bluejeans, which is an app I use at work... you need
to install the software, in order to do so, visit:
https://www.bluejeans.com
There are apps for windows, mac, Linux, iOS and Android as far as
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1756
@jmesnil
> Is there a way to trigger it again?
Not sure but maybe just forcing another push it will restart a CI job?
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1756
@jmesnil I'm looking into it :+1:
---
Github user JiriOndrusek commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1761#discussion_r160421530
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java
---
@@ -990,17 +,
Github user JiriOndrusek commented on the issue:
https://github.com/apache/activemq-artemis/pull/1761
In 2 places I have to use "constant" for repetitive checking, whether
action is already finished. May I use some generic timeout used in project (or
define new attribute, ...)
(Cl
Github user JiriOndrusek commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1761#discussion_r160420636
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java
---
@@ -205,14 +
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1758#discussion_r160420445
--- Diff:
tests/compatibility-tests/src/main/resources/servers/hornetqServer.groovy ---
@@ -19,7 +23,7 @@ import org.hornetq.core.confi
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1758#discussion_r160420063
--- Diff:
tests/compatibility-tests/src/main/resources/exportimport/import1X.groovy ---
@@ -0,0 +1,11 @@
+import org.apache.activem
Github user JiriOndrusek closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1676
---
Github user JiriOndrusek commented on the issue:
https://github.com/apache/activemq-artemis/pull/1676
Replaced with https://github.com/apache/activemq-artemis/pull/1761
---
GitHub user JiriOndrusek opened a pull request:
https://github.com/apache/activemq-artemis/pull/1761
[ARTEMIS-1527] - [Artemis Testsuite] ActiveMQMessageHandlerTest#testSâ¦
â¦erverShutdownAndReconnect fails
Issue: https://issues.apache.org/jira/browse/ARTEMIS-1527
You can
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1760
@michaelandrepearce Sure! Anyway this was a very subtle leak :O
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1760
+1 LGTM will wait for PR build to complete successfully if thats ok
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1757
@franz1981 once the build of that PR for fixing the leaking
RemotingConnectionImpl is green, ill merge it, and then ill rebase this branch
again.
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1760
This PR is addressing an issue present into master and found on
https://github.com/apache/activemq-artemis/pull/1757
---
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1760
ARTEMIS-1593 RemotingConnectionImpl leaks
FileNameKey was holding a reference to PropertiesLoader.this due to its
inner class definition, causing RemotingConnectionImpl to leak through
Just one more reminder, there has been zero contributions to the board
report and I really need some help compiling it.
Please take just a few minutes to glance over what I have so far and
augment it with some additional information, even if it's just a sentence
or two.
https://cwiki.apache.org/c
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1757
@michaelandrepearce Probably I've fixed it: it was subtle...
---
Github user gtully commented on the issue:
https://github.com/apache/activemq-artemis/pull/1759
I added to some existing auto create address logic in the code path which
suffices for my test case. It does appear a little hacky to have three xxToUse
local variables and the toString mes
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1757
@michaelandrepearce Exactly...
---
GitHub user gtully opened a pull request:
https://github.com/apache/activemq-artemis/pull/1759
[ARTEMIS-1241] check for FQQN and autocreate queue using the configurâ¦
â¦ed default routing type
You can merge this pull request into a Git repository by running:
$ git pull https:
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1757
@franz1981 could you fully expand the fields in references pane until root?
I suspect the login context is there holding the jaas callback hadler
---
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/1756
The CI is reporting an error but the build has already disappeared from its
history.
Is there a way to trigger it again?
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1757
@michaelandrepearce
It is near to be fixed, but I've opened a separate JIRA for it:
This `RemotingConnectionImpl` it ha
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1757#discussion_r160352626
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
---
@@ -259,22 +281,23 @@ public boolea
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1757#discussion_r160347432
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
---
@@ -259,22 +281,23 @@ public boolean equals(
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1757
I will take a look on it now, but at a first look semms that there is a
long living `RemoteConnectionImpl` that has a `destroyed` flag `true` which is
not collected after a forced full G
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1757#discussion_r160344540
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
---
@@ -259,22 +281,23 @@ public boolean equals(
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1757#discussion_r160344336
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
---
@@ -259,22 +281,23 @@ public boolean equals(
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1750#discussion_r160340487
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/config/JMSConfigurationTest.java
---
67 matches
Mail list logo
