Sounds good, thanks !
Regards
JB
On 23/10/2018 17:43, Christopher Shannon wrote:
> I will take care of it but I’m unexpectedly out of the office today so I
> plan to do the release first thing early tomorrow morning (US eastern time)
>
> On Mon, Oct 22, 2018 at 12:06 PM Jean-Baptiste Onofré
>
Github user soul2zimate commented on the issue:
https://github.com/apache/activemq-artemis/pull/2391
I updated commit message and PR title.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2391
You shouldnât reference an external JiRA on a commit.
---
GitHub user soul2zimate opened a pull request:
https://github.com/apache/activemq-artemis/pull/2391
[ENTMQBR-2035][JBEAP-15599] add page decoding test for large message â¦
â¦with no persistence
(cherry picked from commit aba9384139956aaf37bde4fc881c7a0e27bbcf32)
Test
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2388
LGTM, will merge tomorrow if no one beats me to it.
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2389
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2390
N.B. this requires https://github.com/apache/activemq-artemis/pull/2389 to
merge first, as that removes last usage of this broker side (dead code)
---
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2390
NO-JIRA Move JMS_SESSION_CLIENT_ID_PROPERTY to JMS module
Remove JMS specifics from CORE, that are not used in broker (typically back
compatibility only now)
You can merge
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2376
I agree with @michaelandrepearce - JMS specifics should not be built into
the console (or any part of the core broker, for that matter). The session
contains generic meta-data which can
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2389
NO-JIRA Remove dead jms code from broker
You can merge this pull request into a Git repository by running:
$ git pull
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2376#discussion_r227610048
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ProducerView.java
---
@@ -79,7 +79,7 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2376#discussion_r227610014
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerView.java
---
@@ -82,7 +82,7 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2376#discussion_r227609704
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConnectionView.java
---
@@ -91,7 +95,14
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2376#discussion_r227609451
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConnectionView.java
---
@@ -51,10 +51,14
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2388#discussion_r227609075
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
---
@@ -1540,6 +1561,75 @@ public
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2384
Please also update ConsumerFilterPredicate to handle the new field, see
QueueFilterPredicate for example of handling filter in the filterpredicates
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2384#discussion_r227607588
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerView.java
---
@@ -89,6 +90,8 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2388#discussion_r227604758
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
---
@@ -1540,6 +1561,75
What about this. WE could :
- commit this on git
- upload a snapshot for review under our web-site.
On Mon, Oct 22, 2018 at 8:46 AM Clebert Suconic
wrote:
>
> +1000. We had that options discussed here a few times. Having the old
> website somewhere with a link is the way to go for the
Github user sebthom commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2388#discussion_r227494586
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
---
@@ -1540,6 +1561,75 @@ public
I will take care of it but I’m unexpectedly out of the office today so I
plan to do the release first thing early tomorrow morning (US eastern time)
On Mon, Oct 22, 2018 at 12:06 PM Jean-Baptiste Onofré
wrote:
> I can also tackle that if you want. Up to you.
>
> Thanks !
>
> Regards
> JB
>
> Le
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2388
ARTEMIS-1856 support delays before deleting addresses & queues
You can merge this pull request into a Git repository by running:
$ git pull
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2383
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2383
@gaohoward this is actually ARTEMIS-2135, which I fixed in 2.6.x and added
a test.
Also verified that @tabish121 ' s refactoring fixed it.. but the actual
issue for this test
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2387
This is to provide feature parity with ActiveMQ 5.x, with being able to
close a group using -1 group sequence.
http://activemq.apache.org/message-groups.html
---
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2387
ARTEMIS-2142 Support JMSXGroupSeq -1to close/reset group
Add test cases
Add GroupSequence to Message Interface
Implement Support closing/reset group in queue impl
+1.
On Mon, Oct 22, 2018 at 8:46 PM Clebert Suconic
wrote:
> +1000. We had that options discussed here a few times. Having the old
> website somewhere with a link is the way to go for the migration.
>
> On Mon, Oct 22, 2018 at 7:47 AM michael.andre.pearce
> wrote:
>
> > Sounds good to me.
> >
27 matches
Mail list logo
