[GitHub] onlyMIT opened a new pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

2019-01-29 Thread GitBox
onlyMIT opened a new pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528 If use MQTT protocol, multiple consumers using the same clientId in the cluster, the last consumer connection should clo

[GitHub] franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-29 Thread GitBox
franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-458487385 @michaelandrepearce @clebertsuconic I have verified that no HW fences are needed so now worries about 32/64

[GitHub] onlyMIT commented on issue #2466: ARTEMIS-2206 The MQTT consumer reconnection caused the queue to not be cle…

2019-01-29 Thread GitBox
onlyMIT commented on issue #2466: ARTEMIS-2206 The MQTT consumer reconnection caused the queue to not be cle… URL: https://github.com/apache/activemq-artemis/pull/2466#issuecomment-458488858 I used to think that the issue with [ARTEMIS-2226 ](https://issues.apache.org/jira/browse/ARTEMIS-2

Re: [VOTE] Release ActiveMQ-CPP v3.9.5

2019-01-29 Thread Christopher Shannon
+1 On Tue, Jan 29, 2019 at 2:04 AM Jean-Baptiste Onofré wrote: > +1 > > Checked the signature and legal. > > Regards > JB > > On 28/01/2019 17:35, Timothy Bish wrote: > > New vote open for ActiveMQ-CPP v3.9.5 > > > > This is a new patch release of the ActiveMQ-CPP client with an > > additional c

[GitHub] TomasHofman commented on a change in pull request #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected

2019-01-29 Thread GitBox
TomasHofman commented on a change in pull request #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected URL: https://github.com/apache/activemq-artemis/pull/2287#discussion_r251879550 ## File path: tests/extra-tests/src/test/java/org/apache/activemq/artemis/

[GitHub] TomasHofman commented on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected

2019-01-29 Thread GitBox
TomasHofman commented on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected URL: https://github.com/apache/activemq-artemis/pull/2287#issuecomment-458591827 @michaelandrepearce thanks for input, all should be done. --

[GitHub] michaelandrepearce commented on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected

2019-01-29 Thread GitBox
michaelandrepearce commented on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected URL: https://github.com/apache/activemq-artemis/pull/2287#issuecomment-458605261 @TomasHofman looks like from the failed PR build, some checkstyle failures need addressing.

[GitHub] clebertsuconic commented on a change in pull request #2527: NO-JIRA add logging to LegacyLDAPSecuritySettingPlugin

2019-01-29 Thread GitBox
clebertsuconic commented on a change in pull request #2527: NO-JIRA add logging to LegacyLDAPSecuritySettingPlugin URL: https://github.com/apache/activemq-artemis/pull/2527#discussion_r251929829 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl

[GitHub] clebertsuconic commented on a change in pull request #2527: NO-JIRA add logging to LegacyLDAPSecuritySettingPlugin

2019-01-29 Thread GitBox
clebertsuconic commented on a change in pull request #2527: NO-JIRA add logging to LegacyLDAPSecuritySettingPlugin URL: https://github.com/apache/activemq-artemis/pull/2527#discussion_r251929829 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl

[GitHub] clebertsuconic commented on a change in pull request #2527: NO-JIRA add logging to LegacyLDAPSecuritySettingPlugin

2019-01-29 Thread GitBox
clebertsuconic commented on a change in pull request #2527: NO-JIRA add logging to LegacyLDAPSecuritySettingPlugin URL: https://github.com/apache/activemq-artemis/pull/2527#discussion_r251929829 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl

[GitHub] jbertram commented on a change in pull request #2527: NO-JIRA add logging to LegacyLDAPSecuritySettingPlugin

2019-01-29 Thread GitBox
jbertram commented on a change in pull request #2527: NO-JIRA add logging to LegacyLDAPSecuritySettingPlugin URL: https://github.com/apache/activemq-artemis/pull/2527#discussion_r251942421 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/Legac

Re: [VOTE] Release ActiveMQ-CPP v3.9.5

2019-01-29 Thread Roddie Kieley
+1 [community] Used the bzip2'd tarball on both Fedora 27 with gcc 7.3.1 and OSX 10.11.6 with Xcode 7.3.1 - default build ./autogen.sh && configure - ran all examples in src/examples/.libs -- On F27 against downstream A-MQ 6.1.1-477 -- On OSX against upstream ActiveMQ 5.15.8 default config OOTB On

[GitHub] michaelandrepearce commented on a change in pull request #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue

2019-01-29 Thread GitBox
michaelandrepearce commented on a change in pull request #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue URL: https://github.com/apache/activemq-artemis/pull/2524#discussion_r252017839 ## File path: artemis-commons/src/main/java/org/apache/activemq/art

[GitHub] michaelandrepearce commented on a change in pull request #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue

2019-01-29 Thread GitBox
michaelandrepearce commented on a change in pull request #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue URL: https://github.com/apache/activemq-artemis/pull/2524#discussion_r252017839 ## File path: artemis-commons/src/main/java/org/apache/activemq/art

[GitHub] michaelandrepearce commented on a change in pull request #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue

2019-01-29 Thread GitBox
michaelandrepearce commented on a change in pull request #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue URL: https://github.com/apache/activemq-artemis/pull/2524#discussion_r252017839 ## File path: artemis-commons/src/main/java/org/apache/activemq/art

[GitHub] michaelandrepearce commented on issue #2525: ARTEMIS-2241 Support direct deliver for InVMAcceptors

2019-01-29 Thread GitBox
michaelandrepearce commented on issue #2525: ARTEMIS-2241 Support direct deliver for InVMAcceptors URL: https://github.com/apache/activemq-artemis/pull/2525#issuecomment-458708363 @franz1981 is that thumbs up a signal you're happy for this to merge?

[GitHub] michaelandrepearce commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-29 Thread GitBox
michaelandrepearce commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-458709026 @orpiske soo... want to come join us as a regular contributor ;) more the merrier @franz

[GitHub] michaelandrepearce commented on issue #1994: ARTEMIS-1787 Openwire message should not contain internal property

2019-01-29 Thread GitBox
michaelandrepearce commented on issue #1994: ARTEMIS-1787 Openwire message should not contain internal property URL: https://github.com/apache/activemq-artemis/pull/1994#issuecomment-458709465 Im closing this, as no update since may last year, or any update since last call out 6 days ago.

[GitHub] michaelandrepearce closed pull request #1994: ARTEMIS-1787 Openwire message should not contain internal property

2019-01-29 Thread GitBox
michaelandrepearce closed pull request #1994: ARTEMIS-1787 Openwire message should not contain internal property URL: https://github.com/apache/activemq-artemis/pull/1994 This is an automated message from the Apache Git Serv

[GitHub] michaelandrepearce edited a comment on issue #1994: ARTEMIS-1787 Openwire message should not contain internal property

2019-01-29 Thread GitBox
michaelandrepearce edited a comment on issue #1994: ARTEMIS-1787 Openwire message should not contain internal property URL: https://github.com/apache/activemq-artemis/pull/1994#issuecomment-458709465 Im closing this, as no update since may last year, or any update since last call out 6 day

[GitHub] michaelandrepearce closed pull request #2199: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

2019-01-29 Thread GitBox
michaelandrepearce closed pull request #2199: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2199 This is an automated message f

[GitHub] michaelandrepearce commented on issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

2019-01-29 Thread GitBox
michaelandrepearce commented on issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2199#issuecomment-458710131 Im closing this, as no update since oct last year, or any update since last

[GitHub] michaelandrepearce commented on issue #2391: Add page decoding test for large message …

2019-01-29 Thread GitBox
michaelandrepearce commented on issue #2391: Add page decoding test for large message … URL: https://github.com/apache/activemq-artemis/pull/2391#issuecomment-45875 @soul2zimate looks like PR build failed, but this i believe is one of the "tempremental" tests we have in the suite, so u

[GitHub] michaelandrepearce commented on issue #2479: ARTEMIS-2211 Refactor ByteBuffer pooling, alignment and zeroing

2019-01-29 Thread GitBox
michaelandrepearce commented on issue #2479: ARTEMIS-2211 Refactor ByteBuffer pooling, alignment and zeroing URL: https://github.com/apache/activemq-artemis/pull/2479#issuecomment-458712438 @franz1981 has a full CI run occured on this? I noted earlier on you said you were going to run. als

[GitHub] clebertsuconic closed pull request #2526: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-29 Thread GitBox
clebertsuconic closed pull request #2526: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2526 This is an automated message from the Apache Git Service. To respond to t

[GitHub] soul2zimate commented on issue #2391: Add page decoding test for large message …

2019-01-29 Thread GitBox
soul2zimate commented on issue #2391: Add page decoding test for large message … URL: https://github.com/apache/activemq-artemis/pull/2391#issuecomment-458796555 it all passed now. This is an automated message from the Apache

[GitHub] asfgit closed pull request #2527: NO-JIRA add logging to LegacyLDAPSecuritySettingPlugin

2019-01-29 Thread GitBox
asfgit closed pull request #2527: NO-JIRA add logging to LegacyLDAPSecuritySettingPlugin URL: https://github.com/apache/activemq-artemis/pull/2527 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] orpiske commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-29 Thread GitBox
orpiske commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-458834727 > @orpiske soo... want to come join us as a regular contributor ;) more the merrier > > @franz1981

[GitHub] franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-29 Thread GitBox
franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-458845348 @michaelandrepearce > this is great stuff!!! looking forward to it. The commit here is just mine :