Hi Chris
In general looks good.
Ive tried adding comments inline on the commit hopefully you see them.
Could an xml config example be added like there was for the upstream bits. (I
could have missed it)
Looks good though great stuff!
Mike
Get Outlook for Android
On Mo
Thanks for taking a look and yes I can see your comments so I will respond
on the branch.
The XML configuration will absolutely be updated, I just hadn't gotten
around to it but adding the new XML config + documentation will be
necessary for the final PR.
I'm still tweaking a few things and polis
My reading of the Apache documentation on release approval [1] indicates
you've already got the required votes for the release to pass. It says:
For a release vote to pass, a minimum of three positive votes and more
positive than negative votes MUST be cast. Releases may not be vetoed.
Votes cas
+1 (Binding)
On Thu, Oct 31, 2019 at 3:18 PM Michael Pearce
wrote:
> Hi All,
>
> Thanks all how reviewed rc1, hopefully all the points raised are now
> resolved.
>
> I have put together a second spin for a Apache NMS AMQP release, please
> check it and vote accordingly.
>
> This release effectiv
Historically at least it was always the that case you needed 3 binding
+1 votes minimum (and more + than -), which is why PMCs needed to
have at least 3 active members or be considered for the attic, as it
is the PMC that must agree to the release happening.
I'd agree the page you linked isnt rea
Thanks for the clarification, Robbie. The link you provided was helpful.
Cheers!
Justin
On Wed, Nov 6, 2019 at 11:13 AM Robbie Gemmell
wrote:
> Historically at least it was always the that case you needed 3 binding
> +1 votes minimum (and more + than -), which is why PMCs needed to
> have at
Hi,
I agree with Robbie.
I didn't vote due to my lack of knowledge on the NMS part. So, I would
like to take more time to be familiar with this part before casting a
vote (my vote is non binding anyway as I'm not PMC member).
However, you already got three binding votes so you are good to close
In case you originally meant to direct it elsewhere instead...you
actually did cast the first vote in the thread.
On Wed, 6 Nov 2019 at 17:19, Jean-Baptiste Onofré wrote:
>
> Hi,
>
> I agree with Robbie.
>
> I didn't vote due to my lack of knowledge on the NMS part. So, I would
> like to take mor
+1 Binding (just so its clear for the records)
As now have 3 bindings, i will shortly send the result mail.
On Wed, 6 Nov 2019 at 17:13, Robbie Gemmell
wrote:
> Historically at least it was always the that case you needed 3 binding
> +1 votes minimum (and more + than -), which is why PMCs need
Results of the Apache NMS AMQP 1.8.0 - RC2 release vote.
Vote passes with 8 votes.
The following votes were received:
+1 Votres:
Binding
Michael Andre Pearce
Clebert Suconic
Martyn Taylor
Non Binding:
Chris Morgan
Duane Pauls
Jean-Baptiste Onofre
Ragnar Paulson
Krzysztof Porebski
There were
10 matches
Mail list logo