[GitHub] activemq-artemis issue #2256: ARTEMIS-2045 Add support for setting delivery ...

2018-12-17 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2256 @jbertram yes, the broker can add additional message annotations as long as those being added follow the rules from the spec, if the user adds something that the remote doesn&#

[GitHub] activemq-artemis pull request #2452: ARTEMIS-1938 Update Qpid JMS and proton...

2018-12-06 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2452 ARTEMIS-1938 Update Qpid JMS and proton-j to latest Updates Qpid JMS to v0.39.0 and proton-j to v0.31.0 You can merge this pull request into a Git repository by running: $ git

[GitHub] activemq-artemis pull request #2448: ARTEMIS-2189 allow deleting temp dest w...

2018-12-06 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2448#discussion_r239486511 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java --- @@ -386,14 +386,27 @@ public

[GitHub] activemq-artemis pull request #2448: ARTEMIS-2189 allow deleting temp dest w...

2018-12-04 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2448#discussion_r238785616 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java --- @@ -386,14 +386,27 @@ public

[GitHub] activemq-artemis pull request #2448: ARTEMIS-2189 allow deleting temp dest w...

2018-12-03 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2448#discussion_r238416943 --- Diff: tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TemporaryDestinationTest.java --- @@ -265,6 +266,126 @@ public

[GitHub] activemq-artemis pull request #2433: ARTEMIS-1938 Update proton-j to 0.30.0 ...

2018-11-14 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2433 ARTEMIS-1938 Update proton-j to 0.30.0 and Qpid JMS 0.37.0 Update to latest proton-j release and refactor the dispostion code to use the new type enums to better deal with the

[GitHub] activemq-artemis issue #2423: ARTEMIS-2168 Fix "populate-validated-user" fea...

2018-11-12 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2423 @michaelandrepearce I agree, that expiry bit qualifies as a bug and should also be fixed to disallow modification ---

[GitHub] activemq-artemis issue #2423: ARTEMIS-2168 Fix "populate-validated-user" fea...

2018-11-09 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2423 I'd say none of them are really the right way to go. I'd suggest your organization create a custom broker plugin that does whatever protocol violating things are acceptable

[GitHub] activemq-artemis issue #2423: ARTEMIS-2168 Fix "populate-validated-user" fea...

2018-11-09 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2423 -1 This is actually worse that before because now you've not only violated the AMQP spec in regards to changing the User ID portion of the properties section but also open

[GitHub] activemq-artemis issue #2422: ARTEMIS-2168 Fix "populate-validated-user" fea...

2018-11-08 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2422 @michaelandrepearce I may have worked due to a bug that allowed the broker to violate the AMQP specification but was fixed later (https://issues.apache.org/jira/browse/ARTEMIS-1092) and

[GitHub] activemq-artemis issue #2422: ARTEMIS-2168 Fix "populate-validated-user" fea...

2018-11-08 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2422 -1 The properties section of an AMQP message is immutable and cannot be changed by the broker as per the AMQP 1.0 specification (Section 3.2) http://docs.oasis

[GitHub] activemq-artemis issue #2383: NO-JIRA Adding a test for ARTEMIS-2096

2018-10-19 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2383 This isn't really a NO-JIRA commit if you are adding a test against a specific JIRA is it? No reason I can see to put a NO-JIRA on this instead of just tagging against the JIRA th

[GitHub] activemq-artemis pull request #2329: ARTEMIS-2096 Refactor AMQMessage abstra...

2018-09-25 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2329 ARTEMIS-2096 Refactor AMQMessage abstraction Major refactoring of the AMQPMessage abstraction to resolve some issue of message corruption still present in the code and improve

[GitHub] activemq-artemis pull request #2309: NO-JIRA Fix condition timeouts to avoid...

2018-09-12 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2309 NO-JIRA Fix condition timeouts to avoid spurious failures The waits for expiration are set at the same value as the expiration interval default to in the test support setup so on

[GitHub] activemq-artemis pull request #2308: ARTEMIS-2083 Decode only the relavent p...

2018-09-12 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2308#discussion_r217179064 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java

[GitHub] activemq-artemis pull request #2306: ENTMQBR-1569 - make sure to send credit...

2018-09-12 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2306#discussion_r217160287 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java

[GitHub] activemq-artemis issue #2306: ENTMQBR-1569 - make sure to send credits on re...

2018-09-12 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2306 This should be referencing some ActiveMQ Artemis JIRA issue and not an JIRA from an external tracker. ---

[GitHub] activemq-artemis pull request #2308: ARTEMIS-2083 Decode only the relavent p...

2018-09-12 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2308 ARTEMIS-2083 Decode only the relavent portions of the message Ensure that the Body of the message is never decoded in the partial decode phase of the message processing and also

[GitHub] activemq-artemis issue #2284: ARTEMIS-2067 Clean up some code in the AMQP pr...

2018-09-11 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2284 Sync'd with master, test failure seems unrelated to AMQP ---

[GitHub] activemq-artemis pull request #2304: ARTEMIS-2082 Reset buffer valid flag af...

2018-09-11 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2304 ARTEMIS-2082 Reset buffer valid flag after re-encoding the message Once a re-encode of the message is done the buffer is not being marked as valid and so subsequent checks on the

[GitHub] activemq-artemis issue #2284: ARTEMIS-2067 Clean up some code in the AMQP pr...

2018-08-30 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2284 I targeted 2.7.0 in the JIRA as I don't think it is a critical fix can add it on next cycle if you want. ---

[GitHub] activemq-artemis pull request #2284: ARTEMIS-2067 Clean up some code in the ...

2018-08-30 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2284 ARTEMIS-2067 Clean up some code in the AMQP protocol handling paths Cleans up some of the code on the proton event handler, most noteable: 1. Fix IOCallback creation on each

[GitHub] activemq-artemis pull request #2277: ARTEMIS-2062 Only attempt to refill cre...

2018-08-28 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2277 ARTEMIS-2062 Only attempt to refill credit when needed Avoid firing the offerProducerCredit code when we know that the credit is low enough that a refill is needed which avoids lock

[GitHub] activemq-artemis issue #2272: ARTEMIS-2057 Fix runaway credit grants

2018-08-28 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2272 @gemmellr I've pushed some updates based on comments, thanks for reviewing ---

[GitHub] activemq-artemis pull request #2272: ARTEMIS-2057 Fix runaway credit grants

2018-08-27 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2272 ARTEMIS-2057 Fix runaway credit grants Ensure the broker looks at local receiver credit when checking for credit top off threshold and then do a proper top off back to the high

[GitHub] activemq-artemis issue #2269: ARTEMIS-1938 Update Qpid JMS along with Proton...

2018-08-24 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2269 @michaelandrepearce Seems the tcnative dependency used for those tests was to old, fixed now. ---

[GitHub] activemq-artemis pull request #2269: ARTEMIS-1938 Update Qpid JMS along with...

2018-08-24 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2269 ARTEMIS-1938 Update Qpid JMS along with Proton and Netty Update the Qpid JMS and Proton dependencies to lastest and sync Netty with the 4.1.28.Final version used by Qpid JMS to

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-08-03 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r207644233 --- Diff: src/example/csharp/HelloWorld/HelloWorld.cs --- @@ -0,0 +1,331 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-08-03 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r207644379 --- Diff: src/example/csharp/HelloWorld/HelloWorld.cs --- @@ -0,0 +1,331 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-08-03 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r207643922 --- Diff: src/example/csharp/HelloWorld/HelloWorld.cs --- @@ -0,0 +1,331 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-08-03 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r207644112 --- Diff: src/example/csharp/HelloWorld/HelloWorld.cs --- @@ -0,0 +1,331 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-08-03 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r207643986 --- Diff: src/example/csharp/HelloWorld/HelloWorld.cs --- @@ -0,0 +1,331 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-08-03 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r207643307 --- Diff: src/main/csharp/ConnectionMetaData.cs --- @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] activemq-nms-amqp issue #2: AMQNET-575: NMS AMQP Client Rework

2018-07-24 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/2 I would just make the changes and amend the commit and force push it to the PR branch, you can also commit things locally and squash later if you prefer that route. Basically until this

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-07-20 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r204159506 --- Diff: README.md --- @@ -0,0 +1,112 @@ +# NMS-AMQP --- End diff -- Apache-NMS-AMQP ---

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-07-20 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r204161653 --- Diff: src/main/csharp/Connection.cs --- @@ -0,0 +1,1158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-07-20 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r204159065 --- Diff: NMS.AMQP/NMS-AMQP.csproj --- @@ -0,0 +1,124 @@ + + + + + +Debug +AnyCPU +{0D8CF699

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-07-20 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r204160011 --- Diff: src/main/csharp/Connection.cs --- @@ -0,0 +1,1158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-07-20 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r204160492 --- Diff: NMS.AMQP/App.config --- @@ -0,0 +1,16 @@ + --- End diff -- missing license header ---

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-07-20 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r204160181 --- Diff: NMS.AMQP/Properties/AssemblyInfo.cs --- @@ -0,0 +1,37 @@ +using System.Reflection; --- End diff -- Missing license

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-07-20 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r204160304 --- Diff: NMS.AMQP/Properties/AssemblyInfo.cs --- @@ -0,0 +1,37 @@ +using System.Reflection; +using System.Runtime.CompilerServices

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-07-20 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r204159176 --- Diff: NMS.AMQP/NMS-AMQP.csproj --- @@ -0,0 +1,124 @@ + + + + + +Debug +AnyCPU +{0D8CF699

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-07-20 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r204159358 --- Diff: NMS.AMQP/Properties/AssemblyInfo.cs --- @@ -0,0 +1,37 @@ +using System.Reflection; +using System.Runtime.CompilerServices

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-07-20 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r204160128 --- Diff: README.md --- @@ -0,0 +1,112 @@ +# NMS-AMQP --- End diff -- Should be Apache NMS AMQP ---

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-07-20 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r204159401 --- Diff: NMS.AMQP/Properties/AssemblyInfo.cs --- @@ -0,0 +1,37 @@ +using System.Reflection; --- End diff -- License header

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-07-20 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r204160391 --- Diff: NMS.AMQP/Properties/AssemblyInfo.cs --- @@ -0,0 +1,37 @@ +using System.Reflection; +using System.Runtime.CompilerServices

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-07-20 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r204158230 --- Diff: HelloWorld/Properties/AssemblyInfo.cs --- @@ -0,0 +1,36 @@ +using System.Reflection; --- End diff -- Missing License

[GitHub] activemq-nms-amqp issue #2: AMQNET-575: NMS AMQP Client Rework

2018-07-17 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/2 If you can't work out the squash then another way to fix things is to back out the commit using a "git reset --soft HEAD~X" where 'X' is the number of commits and

[GitHub] activemq-nms-amqp issue #2: AMQNET-575: NMS AMQP Client Rework

2018-07-10 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/2 It is generally best practice to squash commits into one on a PR to make life easier for the reviews and to make the commit history simpler. We don't really need to preserve a c

[GitHub] activemq-nms-amqp issue #1: AMQNET-576: Clean out old code base for NMS AMQP...

2018-07-10 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/1 This looks like it could be closed now given a new PR(#2) with the client code is now open ---

[GitHub] activemq-artemis pull request #2174: ARTEMIS-1941 fix failing tests

2018-07-09 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2174#discussion_r201156531 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message

[GitHub] activemq-nms-amqp issue #1: AMQNET-576: Clean out old code base for NMS AMQP...

2018-07-09 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/1 The move of legacy code was done properly now on the Apache repo, this PR needs to be rebased and squashed into one commit for review. ---

[GitHub] activemq-artemis pull request #2174: ARTEMIS-1941 fix failing tests

2018-07-09 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2174#discussion_r201007171 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message

[GitHub] activemq-artemis pull request #2174: ARTEMIS-1941 fix failing tests

2018-07-06 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2174#discussion_r200759349 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message

[GitHub] activemq-artemis pull request #2174: ARTEMIS-1941 fix failing tests

2018-07-06 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2174#discussion_r200754867 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message

[GitHub] activemq-artemis pull request #2168: RTEMIS-1941 Preserve AMQP body section ...

2018-07-02 Thread tabish121
Github user tabish121 closed the pull request at: https://github.com/apache/activemq-artemis/pull/2168 ---

[GitHub] activemq-artemis pull request #2168: RTEMIS-1941 Preserve AMQP body section ...

2018-06-29 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2168 RTEMIS-1941 Preserve AMQP body section type on "large" messages When "large" messages are converted to / from core in order to be stored in the large message s

[GitHub] activemq-artemis issue #2145: ARTEMIS-1938 Update to Qpid JMS 0.33.0

2018-06-15 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2145 There are no updates to proton-j at this time, only client fixes ---

[GitHub] activemq-artemis issue #2145: ARTEMIS-1938 Update to Qpid JMS 0.33.0

2018-06-15 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2145 The only reason you might want to take it is that it contains several fixes for failover handling and artemis provides a Karaf feature for an AMQP client so your users could benefit

[GitHub] activemq-artemis issue #2145: ARTEMIS-1938 Update to Qpid JMS 0.33.0

2018-06-15 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2145 I targeted the JIRA at 2.7.0 for that reason. ---

[GitHub] activemq-artemis pull request #2145: ARTEMIS-1938 Update to Qpid JMS 0.33.0

2018-06-15 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2145 ARTEMIS-1938 Update to Qpid JMS 0.33.0 Update to latest release of Qpid JMS You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] activemq-artemis pull request #2135: ARTEMIS-1924 Add amqpIdleTimeout

2018-06-11 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2135#discussion_r194568008 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java --- @@ -0,0 +1,83

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866 Make Quorum vote result wait time...

2018-05-25 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 Doesn't that sort of defeat the point of using source control ? ---

[GitHub] activemq-artemis issue #2106: [ARTEMIS-1885]max-consumers attribute in queue...

2018-05-24 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2106 If it is fixing something then it needs a test. If it is not fixing something than the JIRA description needs to be changed as it makes it sound like it is fixing something, and

[GitHub] activemq-artemis issue #2106: [ARTEMIS-1885]max-consumers attribute in queue...

2018-05-24 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2106 There's no tests here, how do we know this does or does not fix an issue that may or may not exist given there's no test provided to observe it ? ---

[GitHub] activemq-artemis pull request #2087: ARTEMIS-1861 Set a max-frame-size on AM...

2018-05-11 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2087 ARTEMIS-1861 Set a max-frame-size on AMQP connections by default Configure a value of 128KB for AMQP max frame size by default to improve overall performance and provide a limit on

[GitHub] activemq-artemis pull request #2084: ARTEMIS-1859 Adding testAnonymousProduc...

2018-05-11 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2084#discussion_r187643834 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSMessageProducerTest.java --- @@ -70,10

[GitHub] activemq-artemis pull request #2067: ARTEMIS-1847 Update to Netty 4.1.24.Fin...

2018-05-03 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2067 ARTEMIS-1847 Update to Netty 4.1.24.Final You can merge this pull request into a Git repository by running: $ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1847

[GitHub] activemq-artemis pull request #2064: ARTEMIS-1843 Update Qpid JMS 0.32.0 and...

2018-05-03 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2064 ARTEMIS-1843 Update Qpid JMS 0.32.0 and Proton-j 0.27.1 Use new no copy variants for the delivery send and receive and make use of the ReadableBuffer type that is now used to

[GitHub] activemq-artemis issue #2053: ARTEMIS-1838 Fixing AMQP->Core Race on durable...

2018-04-30 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2053 @clebertsuconic ok, I was about to fix it myself. I confirmed that the fix does seem to resolve the issue, I can no longer reproduce it here using the test and an external broker or

[GitHub] activemq-artemis issue #2053: ARTEMIS-1838 Fixing AMQP->Core Race on durable...

2018-04-30 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2053 Now you have a checkstyle violation :) ---

[GitHub] activemq-artemis pull request #2053: ARTEMIS-1838 Fixing AMQP->Core Race on ...

2018-04-30 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2053#discussion_r185075306 --- Diff: tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/crossprotocol/MultiThreadConvertTest.java --- @@ -0,0 +1,173

[GitHub] activemq-artemis issue #2031: ARTEMIS-1816 OpenWire should avoid ByteArrayOu...

2018-04-20 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2031 Ok, I'll be "the decider". Will check with franz to see how much it's worth to him ---

[GitHub] activemq-artemis issue #2031: ARTEMIS-1816 OpenWire should avoid ByteArrayOu...

2018-04-19 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2031 The change as it is seems acceptable as it does reduce unnecessary allocations when ByteMessages types cross to OpenWire. I've reviewed the changes as it relates to the Ope

[GitHub] activemq-artemis issue #2031: ARTEMIS-1816 OpenWire should avoid ByteArrayOu...

2018-04-19 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2031 That would be the more ideal thing to do yes. ---

[GitHub] activemq-artemis issue #2031: ARTEMIS-1816 OpenWire should avoid ByteArrayOu...

2018-04-19 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2031 @franz1981 So I think that you could avoid subclassing the ActiveMQBytesMessage if you built the properties yourself instead of calling setObjectProperty in setAMQMsgObjectProperties in

[GitHub] activemq-artemis issue #1985: ARTEMIS-1780 Handle conversion of large Object...

2018-04-03 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1985 That's twice now today I've rebased. Test failure doesn't seem related to AMQP ---

[GitHub] activemq-artemis issue #1985: ARTEMIS-1780 Handle conversion of large Object...

2018-04-03 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1985 I updated the patch to remove the duplicate decode which seems to have been the root cause of the other test failure. ---

[GitHub] activemq-artemis pull request #1985: ARTEMIS-1780 Handle conversion of large...

2018-04-02 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/1985 ARTEMIS-1780 Handle conversion of large ObjectMessage types Make sure the correct buffer is used when decoding the stored Core message that originated from the conversion of an AMQP

[GitHub] activemq-artemis pull request #1980: ARTEMIS-1777 Adding Protocol specific i...

2018-03-29 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1980#discussion_r178144111 --- Diff: artemis-distribution/pom.xml --- @@ -102,6 +102,11 @@ artemis-amqp-protocol ${project.version

[GitHub] activemq-artemis issue #1961: [ARTEMIS-1758] support SASL EXTERNAL with Text...

2018-03-21 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1961 When running in the IDE the new test works fine, however when I run the AMQP tests from the command line the new test produces an error as below which seems to indicate the test

[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...

2018-03-06 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1928 Need @clebertsuconic to give it a look ---

[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...

2018-03-06 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1928 @franz1981 I've updated this PR with changes to the common path based on your suggestions to me over on my fork. Thanks for the review and ideas, even better now. ---

[GitHub] activemq-artemis issue #1918: ARTEMIS-1722 Reduce pooled Netty ByteBuf usage

2018-03-02 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1918 @franz1981 @clebertsuconic I've sent an alternate PR #1928 which performs the send without any buffer copy unless necessary due to message redelivery or existence of original del

[GitHub] activemq-artemis pull request #1928: ARTEMIS-1722 Don't copy message bytes u...

2018-03-02 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/1928 ARTEMIS-1722 Don't copy message bytes unless needed Alternate patch that doesn't copy the message bytes unless doing a redelivery or skipping delivery annotations in th

[GitHub] activemq-artemis pull request #1925: ARTEMIS-1727 - Make sure transport is s...

2018-03-02 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1925#discussion_r171918979 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java

[GitHub] activemq-artemis issue #1918: ARTEMIS-1722 Reduce pooled Netty ByteBuf usage

2018-03-02 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1918 @franz1981 It doesn't look like the buffer could be contended unless perhaps the consumer was able to be subscribed to more than one queue at a time via some sort of composite

[GitHub] activemq-artemis pull request #1916: ARTEMIS-1504 Update Qpid JMS to 0.30.0 ...

2018-03-01 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/1916 ARTEMIS-1504 Update Qpid JMS to 0.30.0 and proton-j to 0.26.0 Updates to latest Qpid JMS and the latest Proton-J release, use new proton-j setting to disable read-only buffers use to

[GitHub] activemq-artemis pull request #1909: ARTEMIS-1712 Add additional null check ...

2018-02-28 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/1909 ARTEMIS-1712 Add additional null check in TX rollback handler Check for AMQSession being null before handling various TX state checks in order to ensure the correct errors are

[GitHub] activemq-artemis issue #1903: ARTEMIS-1706 - Add support for wantClientAuth

2018-02-28 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1903 Looks good. +1 ---

[GitHub] activemq-artemis pull request #1905: ARTEMIS-1707 Check for already exists e...

2018-02-27 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/1905 ARTEMIS-1707 Check for already exists exceptions and ignore For address and queue create check for the already exists exceptions and ignore as another client might have just created

[GitHub] activemq-artemis pull request #1903: ARTEMIS-1706 - Add support for wantClie...

2018-02-27 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1903#discussion_r171066273 --- Diff: docs/user-manual/en/configuring-transports.md --- @@ -403,6 +403,15 @@ following additional properties: This property is only

[GitHub] activemq-artemis pull request #1903: ARTEMIS-1706 - Add support for wantClie...

2018-02-27 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1903#discussion_r171060932 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java --- @@ -468,8 +473,12 @@ public

[GitHub] activemq-artemis pull request #:

2018-02-16 Thread tabish121
Github user tabish121 commented on the pull request: https://github.com/apache/activemq-artemis/commit/6470e7e64d883282624619adc9d4816fa1688a1e#commitcomment-27609794 Merged it, looked ok to me as well. ---

[GitHub] activemq-artemis pull request #1802: ARTEMIS-1504 Update Qpid JMS to 0.29.0 ...

2018-01-22 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/1802 ARTEMIS-1504 Update Qpid JMS to 0.29.0 and proton-j to 0.25.0 Updates to latest Qpid JMS and the latest Proton-J release You can merge this pull request into a Git repository by

[GitHub] activemq-artemis issue #1773: ARTEMIS-1589 ActiveMQProtonRemotingConnection#...

2018-01-17 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1773 @jbertram @jostbg As far as I can see the patch looks correct, it would seem to make more sense to return the remote container ID here than the locally generated server side value as

[GitHub] activemq-artemis pull request #1769: ARTEMIS-1576 Fix test that was broken w...

2018-01-10 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/1769 ARTEMIS-1576 Fix test that was broken with changes on this issue The test is using the wrong indices for the destinations it uses so they don't match the one's created i

[GitHub] activemq-artemis issue #1734: ARTEMIS-1329 fix openwire noLocal flag

2017-12-20 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1734 Given that there is a JIRA related to this doesn't it seem like the commit should carry the JIRA tag and not a "NO-JIRA" tag? ---

[GitHub] activemq-artemis pull request #1722: (WIP DO NOT MERGE) ARTEMIS-1545 Support...

2017-12-15 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1722#discussion_r157260287 --- Diff: tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/SecurityTest.java --- @@ -169,6 +180,71 @@ public void

[GitHub] activemq-artemis pull request #1714: ARTEMIS-1504 Update Qpid JMS to 0.28.0 ...

2017-12-14 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/1714 ARTEMIS-1504 Update Qpid JMS to 0.28.0 and proton-j to 0.24.0 Updates to latest Qpid JMS and the latest Proton-J release You can merge this pull request into a Git repository by

  1   2   3   >