Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-110862182
yes I can.
On Wed, Jun 10, 2015 at 1:44 PM clebertsuconic
wrote:
> I think we should keep Error Prone on the compilation.. unless it st
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-110828541
I think we should keep Error Prone on the compilation.. unless it starts to
bother people.
So far I think it's useful.
can you send the
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-110823751
@clebertsuconic we are skipping checkstyle, may we skip Error Prone also,
just to maintain certain compatibility with the ActiveMQ codebase?
On W
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-110814326
@clebertsuconic, here:
tests/activemq5-unit-tests/pom.xml:23:
1.0.0-SNAPSHOT
Changing to 1.0.1-SNAPHOT breaks the build because of Erro
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-110558166
@thiagokronig where you are saying that?
and how to enforce that kind of rule. I'm not sure where it's missing a
parent as snapshot
---
If your pro
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-110555396
Thanks Clebert!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-110427482
@clebertsuconic please update the parent version pom:
1.0.0-SNAPSHOT
Should we have some kind of rule in the build to enforce that a child pom
always co
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-110425687
@gaohoward I merged a rebased version of your PR.. so please rebase your
branch before continuing working on anything around this.
since this is
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-110423683
I'm ok with this change!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Thanks, in advance, for any info.
ไฮไลท์บอล คู่เด็ด ทุกคู่ ทุกแมต ไม่พลาด ได้ที่นี่ ไฮไลท์ฟุตบอล
<https://cliphighlight.buaksib.com>
--
View this message in context:
http://activemq.2283324.n4.nabble.com/GitHub-activemq-artemis-pull-request-ARTEMIS-127-Adding-activemq-u
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-109855586
@gtully
I tried and got some compilation error, looks like the wrapper is
referencing some of the API in broker jar (like Broker, TransportConnector).
Any
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-109303356
I'm good either way. The good thing about having the tests committed is it
would be easier to maintain them on the long term.
Howard had a whole b
Github user gtully commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-109288077
@gaohoward - this may be naive, but what happens if your pom dependency for
5.x is just:
```
org.apache.activemq
activemq-unit-test
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-109167037
@clebertsuconic @thiagokronig can you take a look at this? I've gotten rid
of most of the amq5 code.
do 'mvn -Pactivemq5-unit-tests' and you can kick of the
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-108721184
That'll be great. I'll update the branch soon and you can have a look.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-108712726
I am all forward for reusing code/ideas for tests from ActiveMQ! We can
accomplish that with an objective in mind: don't replicate/depend on ActiveMQ,
just
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-108702094
@thiagokronig Hi Thiago right now I'm trying to get rid of the activemq 5
source code, only have a few classes to wrap the Artemis broker for the test.
There a
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-108700719
@clebertsuconic sure I'll.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-108699289
https://github.com/apache/activemq-artemis/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-108499190
@gaohoward you will probably need to tell Thiago on specifics where he
could help you. It's hard to split a task like without duplicating/wasting
work, w
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-108464364
Hi Thiago Kronig, it'll be great if you can lend a hand. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-108443642
Hi, Howard Gao, if you wish, we could work together on this.
On Wed, Jun 3, 2015 at 8:46 AM Howard Gao wrote:
> Hi Martyn, what you su
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-108329879
Hi Martyn, what you suggested makes sense for sure. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-108295200
Hi Howard. I realise that @clebertsuconic already mentioned this but it
looks like you are importing a lot of code from ActiveMQ. Reuse of test suites
is prob
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-108151515
ok let's try that. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-107992912
There must be a better way. Why don't you just implement BrokerService
properly instead of depending on the whole activemq5?
---
If your project is set
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-107970469
I need activemq5 client and broker sources because I need to modify some of
them in order to inject the Artemis broker into activemq5 broker service. I
bring i
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-107951707
This doesn't seem ready to me. I don't see a reason for bringing the entire
activemq5 broker as a source folder inside a test folder.
I will look
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-107951267
@gaohoward I don't understand this... what's under
./activemq5-unit-tests... it seems the whole activemq5 broker implementation.
You even have a Protocol
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-107915237
Hi Clebert,
I got the PR build passed finally. Can you take a look at it?
Thanks
Howard
---
If your project is set up for it, you can reply t
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-107780140
I got something messed up. fixing it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-107566978
@gaohoward you said you would send a new PR? no need.. just update this
one...
let me know when you have done it
---
If your project is set up for i
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-107305686
I've updated my last comment.. I meant, if you need the patch, we will need
to refacdtor this somehow it's independent and you should have the code
commit
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-107302365
ok, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-107289228
Just commit the code you need. a patch is not a good solution on moving
forward. It's impossible to maintain it.
If you don't need the patch, the
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-107281546
The code is only for compiling and running the tests to get the result.
after that do a 'mvn clean' will get rid of all those codes.
---
If your project is s
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-107280665
@gaohoward we don't commit the code? why not actually commit the code and
carry on?
let me talk to you tomorrow about this.
---
If your project
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-107280602
@gaohoward Howard, just add @Deprecated on those classes.. that's all.
---
If your project is set up for it, you can reply to this email and have your
re
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-107278310
Hi Clebert,
I don't have a good idea as to how to fix this. What the module does is
actually download the activmq 5 source code (unit tests, activemq-b
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-107043394
@gaohoward It's an easy fix... and we are importing the code on moving
forward.
If this is verbatim we could just use it straight from maven, but if yo
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-106879458
Please correct those as we have error-prone on the compilation.
Look at my last commit and the post to the activemq-dev-list
---
If your project is se
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-106868119
last time I ran the test suite I got a little over 30% pass rate. So there
still a long way to fix it. I don't think we should enable it by default for
now.
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-106867647
Hi Clebert,
those @deprecated tags are from activemq 5 source code, we don't need to
correct them imo.
This module just get them from amq repository ve
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-106826140
Howard, your PR doesn't build because of these issues:
/work/apache/six-merge/artemis-selector/target/generated-sources/javacc/org/apache/activemq
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-106826266
Please, rebase and fix those?
http://errorprone.info/bugpattern/DepAnn
---
If your project is set up for it, you can reply to this email and have
Github user andytaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-106816951
most of the tests fail clebert so we shouldn't have it enabled by default i
dont think.
---
If your project is set up for it, you can reply to this email and
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/8
ARTEMIS-127 Adding activemq unit test module to Artemis
This test module brings in activemq unit tests and run them
against Artemis broker.
You can merge this pull request into a Git r
48 matches
Mail list logo
