Re: [VOTE] Add Probot Integrations to Airflow Github Repo

2020-01-04 Thread Kaxil Naik
I have created a Github app using Probot: https://github.com/kaxil/boring-cyborg. This is integrated with Airflow and we now have auto-labeling enabled based on filepaths of the changes files in the PR. We can add more integrations iteratively in the "boring-cyborg" and automate other boring chor

Re: Killing Webserver/Scheduler gracefully

2020-01-04 Thread Jarek Potiuk
Some more links Huang: Docker has its own issues - depending on what is the docker entrypoint you use, you can get different (and wrong) behaviour. It is especially problematic if you are using bash script as an entrypoint. It can lead to zombie processes easily. There are many blogs about it, but

Re: [DISCUSS] Airflow Website Blog Guidelines

2020-01-04 Thread Jarek Potiuk
Few important points: We already have a very good source of "everything-airflow" : https://github.com/jghoman/awesome-apache-airflow - this is maintained by Jakob Homan - and it contains a list of a lot of resources of Airflow. They are a bit vetted by Jakob who is a member of the community, but

Re: Killing Webserver/Scheduler gracefully

2020-01-04 Thread Huang Xinbin
+1 for the `stop` idea too. In my team, we use docker to manage airflow, so `stoping` and `restart on failure` are all handled by Docker. It works great so far, but not sure if this is a good practice and I would definitely like to hear other people's feedback. i.e. thanks Jarek for the reference

Re: [DISCUSS] Airflow Website Blog Guidelines

2020-01-04 Thread Austin Bennett
Depends on your aims. @Kaxil "... for it to be meaningful to serve any purpose." is quite loaded, and *any* seems a bit exaggerated. There is value in being the go-to content aggregator, and therefore initials stop, even if whole of content lives elsewhere. That is different from trying to keep

Re: Killing Webserver/Scheduler gracefully

2020-01-04 Thread hotmail
+1 for `stop` arg, and thank Jarek for the clarification. Best Wish — Jiajie

Re: Killing Webserver/Scheduler gracefully

2020-01-04 Thread Jarek Potiuk
I also like "stop" idea. Also to answer a bit my own question and explain current behaviour. We know that if you use systemd or similar (or simply run airflow in terminal and press ^C) the webserver and scheduler will be killed nicely. But I think we miss the case when you want to kill the webserv

Re: Killing Webserver/Scheduler gracefully

2020-01-04 Thread Kaxil Naik
That is a good idea I think. On Sat, Jan 4, 2020 at 11:33 AM Tomasz Urbaszek wrote: > From some time I think about adding "stop" commands like "airflow scheduler > stop", "airflow celery worker stop". > What do you think? I have already done this in native executor POC and it's > helpful. > > T.

Re: Killing Webserver/Scheduler gracefully

2020-01-04 Thread Tomasz Urbaszek
>From some time I think about adding "stop" commands like "airflow scheduler stop", "airflow celery worker stop". What do you think? I have already done this in native executor POC and it's helpful. T. On Sat, Jan 4, 2020 at 12:22 PM Kaxil Naik wrote: > Systemd integrations have worked nicely f

Re: Killing Webserver/Scheduler gracefully

2020-01-04 Thread Kaxil Naik
Systemd integrations have worked nicely for me: https://airflow.apache.org/docs/stable/howto/run-with-systemd.html On Sat, Jan 4, 2020 at 11:01 AM Jarek Potiuk wrote: > I would like to bring the subject from user@ group > > https://lists.apache.org/thread.html/5add5e8a19cb86ef2141d9d0634bd01c1

Killing Webserver/Scheduler gracefully

2020-01-04 Thread Jarek Potiuk
I would like to bring the subject from user@ group https://lists.apache.org/thread.html/5add5e8a19cb86ef2141d9d0634bd01c12d74a7655c4eddfa7b8e75a%40%3Cusers.airflow.apache.org%3E Seems some people have problems with nicely killing airflow scheduler/webserver with signals and I was wondering if thi

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

2020-01-04 Thread Jarek Potiuk
Those both are cool. Love them :). Why not use the periodic labeler workaround? It seems to do the trick and uses the same configuration and does not seem to have any negative side effects. I think auto-labelling our PRs would be a great step (together with working stale bot) towards making more