Correction in my previous email. pre-commit hook double-quote-string-fixer
too does not seem to work well for f-strings with a mix of double and
single quotes (meaning does not convert a f-string which has outer quotes
as double and inner quotes as single). It just skips it if the string is
like th
Definitely in favor of more consistency. (Hoping it will not make things
too hard for people doing the cherry picking)
Best Regards,
Pierre
Le mer. 21 sept. 2022 à 08:35, Pankaj Koti
a écrit :
> I'm in for normalizing.
> Personally, I don't like a mix of both single and double quotes.
>
> In my
I'm in for normalizing.
Personally, I don't like a mix of both single and double quotes.
In my opinion, we can enforce double-quotes with Black or also try the
pre-commit hook double-quote-string-fixer
https://github.com/pre-commit/pre-commit-hooks/blob/main/README.md#double-quote-string-fixer
whi
Totally for it!
That’s not true actually. Black won’t reformat strings using f-string if you
use single quotes for the string and double quotes within e.g. when passing a
str.join statement as a value which uses double quotes. So you can still have a
mixture of both in the codebase but it will
>
> I'll weigh in on this most important of decisions
:)
OK but I must clear up one thing ... if we turn on string normalization, we
do not get to choose single vs double -- with black, there is only one way,
and it is double.
Personally I have always liked single but yeah, I am in favor of tur
I'll weigh in on this most important of decisions. I find myself wishing I
had time to standardize string quotes when I am in files and not doing it
because I don't want to complicate PRs with unnecessary/unrelated changes. So
I'd be for this. I prefer single-quotes myself, but I'd consider
I'd be in favor of turning it on.
I tend to prefer double quotes, but I'd rather have it on and have single
quotes.
If we do get enough support for this, I'd like to wait until we are closer
to 2.5 to reduce conflicts when cherry-picking for 2.4.x's.
Great release! Thanks you all for dataset feature!
But for this time I had to revert
https://github.com/apache/airflow/commit/36eea1c8e0 change for our
production since it completely broke the grid view for all our dags - it
thought that the last dagrun was somewhere at 2021.11 dates while all the
This option has been used to limit the number of changes to files.
https://github.com/apache/airflow/pull/9550#issuecomment-650971650
śr., 21 wrz 2022 o 02:32 Daniel Standish
napisał(a):
> Black, our python formatter, can "normalize" strings to prefer double
> quotes, and we disable this feature
Black, our python formatter, can "normalize" strings to prefer double
quotes, and we disable this feature.
I have always been a single quotes person unless using f-string and
supported disabling normalization when we introduced black.
But lately, black’s string normalization has seemed more appea
Description:
In Apache Airflow 2.3.0 through 2.3.4, there was an open redirect in the
webserver's `/confirm` endpoint.
Credit:
The Apache Airflow PMC would like to thank Konstantin Weddige (Lutra Security)
for reporting this issue.
References:
https://github.com/apache/airflow/pull/26409
Description:
In Apache Airflow 2.3.0 through 2.3.4, part of a url was unnecessarily
formatted, allowing for possible information extraction.
Credit:
The Apache Airflow PMC would like to thank L3yx of Syclover Security Team for
reporting this issue.
References:
https://github.com/apache/airfl
12 matches
Mail list logo
