Re: [DISCUSS] Deprecating SLA feature?

2022-07-13 Thread Daniel Standish
I don't think it makes sense to deprecate it at this time just to re-add it. It's not necessarily backward incompatibility if you are fixing something that is not functioning as intended / desired. And I'm not sure that we'll really have to break backcompat even if you don't want to interpret it

Re: [DISCUSS] Deprecating SLA feature?

2022-07-13 Thread Vikram Koka
You are absolutely right that it will be very hard to "fix" the SLA as it stands while keeping backwards compatibility. My thoughts on the new / updated SLA mechanism will NOT be compatible, but will address the core need for data timeliness. Hmm, that's an interesting thought on "marking it as

Re: [DISCUSS] Deprecating SLA feature?

2022-07-13 Thread Jarek Potiuk
Cool to see that people still need SLA in Airflow. I see the points why and they make perfect sense. Glad we discussed it :) Still - WDYT do we want to signal current SLA as "deprecated" now (even if we do not know what will replace it?) - at least as a signal to stay away from it. Or do we want

Re: [DISCUSS] Deprecating SLA feature?

2022-07-13 Thread Vikram Koka
- resending below to keep the same thread as Ping's response. My prior response and Ping's were sent at the same time, but I did not two two email threads -- I understand the frustration with the SLA feature as it stands. I struggled with trying to understand this early on and finally understood

Re: [DISCUSS] Deprecating SLA feature?

2022-07-13 Thread Vikram Koka
I understand the frustration with the SLA feature as it stands. I struggled with trying to understand this early on and finally understood how they were broken. Having said that, I believe that Airflow users strongly care about the timeliness and consequently SLAs of their data. I also believe

Re: [DISCUSS] Deprecating SLA feature?

2022-07-13 Thread Ping Zhang
Hi Jarek, Thanks for bringing this up. I agree the SLA feature needs some work. However, I think we want an equivalent SLA feature as it is still very useful. Thanks, Ping On Tue, Jul 12, 2022 at 12:42 AM Jarek Potiuk wrote: > Hey everyone, > > I keep on being involved in discussions where

Re: [DISCUSS] Deprecating SLA feature?

2022-07-12 Thread Daniel Standish
I also think SLAs make sense in airflow and think we should fix the feature.

Re: [DISCUSS] Deprecating SLA feature?

2022-07-12 Thread Ash Berlin-Taylor
I agree they SLA as they work now is basically non functional, but strongly disagree with removing them and think a high level concept such as SLA must belong in Airflow. Ultimately what the vast majority of users want to do with Airflow is process data _and make it available_ in a timely

Re: [DISCUSS] Deprecating SLA feature?

2022-07-12 Thread Bas Harenslak
Thanks for bringing this up. I agree SLAs have been broken forever and try to stay away from them. However, I do see people trying to use them (not knowing it's broken). While I appreciate the effort others have made to build a system around Airflow for correct SLA alerting, I think Airflow is

[DISCUSS] Deprecating SLA feature?

2022-07-12 Thread Jarek Potiuk
Hey everyone, I keep on being involved in discussions where people are complaining about how bad and useless the SLA feature of Airflow is. And yeah, I pretty much agree with it. Without getting into details of why it is bad - should we possibly just, well, deprecate it? I think that would give