Re: Running Pylint/Flake/Mypy/Docs/Licence checks locally

2019-07-18 Thread Jarek Potiuk
Yep Maxime 100% agree! It's exactly what I am going to make proposal about next :) and I have working POC as well for Airflow: https://github.com/PolideaInternal/airflow/pull/97/ (and result of it in Travis: https://travis-ci.org/PolideaInternal/airflow/jobs/555443376) On Thu, Jul 18, 2019 at 12:3

Re: Running Pylint/Flake/Mypy/Docs/Licence checks locally

2019-07-17 Thread Maxime Beauchemin
`pre-commit` is pretty great if someone wants to set it up. https://pre-commit.com/ Here's what our configuration looks like for Superset: https://github.com/apache/incubator-superset/blob/master/.pre-commit-config.yaml It's super fast too as it only executes for the files that have been touched

Running Pylint/Flake/Mypy/Docs/Licence checks locally

2019-07-17 Thread Jarek Potiuk
Hello everyone, Following merging AIP-10, I have a kind request to you. In order to limit failed checks on Travis CI (and make your development workflow faster). You should be able to run all static code analysis tests very easily - and they will be run consistently with Travis CI runs. You can r