Re: Review Request 28908: Expose Stage and Upgrade Item update status API.

2014-12-10 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28908/#review64591 --- Ship it! Ship It! - Nate Cole On Dec. 10, 2014, 1:26 p.m., Tom B

Re: Review Request 28908: Expose Stage and Upgrade Item update status API.

2014-12-10 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28908/ --- (Updated Dec. 10, 2014, 6:26 p.m.) Review request for Ambari and Nate Cole. B

Re: Review Request 28908: Expose Stage and Upgrade Item update status API.

2014-12-10 Thread Tom Beerbower
> On Dec. 10, 2014, 6:16 p.m., Nate Cole wrote: > > Thanks for the review! > On Dec. 10, 2014, 6:16 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/StageStatus.java, > > lines 83-85 > >

Re: Review Request 28908: Expose Stage and Upgrade Item update status API.

2014-12-10 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28908/ --- (Updated Dec. 10, 2014, 6:24 p.m.) Review request for Ambari and Nate Cole. B

Re: Review Request 28908: Expose Stage and Upgrade Item update status API.

2014-12-10 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28908/#review64588 --- Ship it! LGTM +1, should help to unblock folks. - Alejandro Fernan

Re: Review Request 28908: Expose Stage and Upgrade Item update status API.

2014-12-10 Thread Nate Cole
> On Dec. 10, 2014, 1:16 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/StageStatus.java, > > lines 83-85 > > > > > > Can use Enum.setOf(e1, ...) instead of new HashSet()

Re: Review Request 28908: Expose Stage and Upgrade Item update status API.

2014-12-10 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28908/#review64583 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/acti

Review Request 28908: Expose Stage and Upgrade Item update status API.

2014-12-10 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28908/ --- Review request for Ambari and Nate Cole. Bugs: AMBARI-8643 https://issues.a