Re: Review Request 29779: Refactor the OS-dependent Ambari Server Windows components - Part 1.2

2015-01-13 Thread Artem Baranchuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29779/#review67944 --- Ship it! Ship It! - Artem Baranchuk On Янв. 13, 2015, 3:59 п.п.,

Re: Review Request 29779: Refactor the OS-dependent Ambari Server Windows components - Part 1.2

2015-01-13 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29779/#review67919 --- Ship it! Ship It! - Eugene Chekanskiy On Jan. 13, 2015, 3:59 p.m

Re: Review Request 29779: Refactor the OS-dependent Ambari Server Windows components - Part 1.2

2015-01-13 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29779/#review67895 --- Ship it! Ship It! - Jayush Luniya On Jan. 13, 2015, 3:59 p.m., F

Re: Review Request 29779: Refactor the OS-dependent Ambari Server Windows components - Part 1.2

2015-01-13 Thread Florian Barca
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29779/ --- (Updated Jan. 13, 2015, 3:59 p.m.) Review request for Ambari, Artem Baranchuk,

Re: Review Request 29779: Refactor the OS-dependent Ambari Server Windows components - Part 1.2

2015-01-13 Thread Florian Barca
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29779/ --- (Updated Jan. 13, 2015, 3:53 p.m.) Review request for Ambari, Artem Baranchuk,

Re: Review Request 29779: Refactor the OS-dependent Ambari Server Windows components - Part 1.2

2015-01-13 Thread Florian Barca
> On Jan. 13, 2015, 8:07 a.m., Jayush Luniya wrote: > > ambari-common/src/main/python/ambari_commons/os_utils.py, line 32 > > > > > > Remove comment? Comment from long time ago - Florian ---

Re: Review Request 29779: Refactor the OS-dependent Ambari Server Windows components - Part 1.2

2015-01-13 Thread Florian Barca
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29779/#review67855 --- ambari-server/src/test/python/unitTests.py

Re: Review Request 29779: Refactor the OS-dependent Ambari Server Windows components - Part 1.2

2015-01-13 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29779/#review67817 --- ambari-common/src/main/python/ambari_commons/os_utils.py

Re: Review Request 29779: Refactor the OS-dependent Ambari Server Windows components - Part 1.2

2015-01-12 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29779/#review67816 --- Can you refresh the patch? hw11039:ambari jluniya$ git apply ~/Down

Review Request 29779: Refactor the OS-dependent Ambari Server Windows components - Part 1.2

2015-01-09 Thread Florian Barca
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29779/ --- Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley,