JUnit4 support - done?

2006-03-01 Thread Jon Skeet
So, having just seen the commit and bug 38811 notes for JUnit4 support - does that mean it's all done? Should I call off the hounds as it were in terms of the JUnit team getting together with the Ant and Maven teams? Or should we still be looking at a transfer of ownership, as it were? Jon

Re: JUnit4 support - done?

2006-03-01 Thread Martijn Kruithof
1.7 isn't final yet, all options are still open. Jon Skeet wrote: So, having just seen the commit and bug 38811 notes for JUnit4 support - does that mean it's all done? Should I call off the hounds as it were in terms of the JUnit team getting together with the Ant and Maven teams? Or should

Re: svn commit: r381780 - in /ant/core/trunk: WHATSNEW docs/manual/OptionalTasks/junit.html src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTestRunner.java src/main/org/apache/tools/ant/tas

2006-03-01 Thread Martijn Kruithof
Isn't this a bit premature, junit 4 isn't even out yet. Furthermore I thought junit 4 would get rid of the distinction between failure and error, wouldn't we want to remain in-line with this new junit behaviour when running junit 4 testcases in an junit 4 environment? Martijn

svn commit: r381998 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java

2006-03-01 Thread stevel
Author: stevel Date: Wed Mar 1 03:59:54 2006 New Revision: 381998 URL: http://svn.apache.org/viewcvs?rev=381998view=rev Log: include the caught exception when relayed Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java Modified:

Junut4 (was Re: svn commit: r381780 - in /ant/core/trunk: WHATSNEW docs/manual/OptionalTasks/junit.html src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTestRunner.java src/main/org/apache/t

2006-03-01 Thread Steve Loughran
Martijn Kruithof wrote: Isn't this a bit premature, junit 4 isn't even out yet. shipped last week. Gump is still recovering. Furthermore I thought junit 4 would get rid of the distinction between failure and error, wouldn't we want to remain in-line with this new junit behaviour when

xalan2.present test broken

2006-03-01 Thread Steve Loughran
We need a test for a trax engine being around, for things like junitreport. But this code doesnt work available property=xalan2.present classname=org.apache.xalan.transformer.TransformerImpl classpathref=classpath/ Not on java1.5, even though xsltc is around. Who

svn commit: r382011 - /ant/core/trunk/build.xml

2006-03-01 Thread stevel
Author: stevel Date: Wed Mar 1 05:27:01 2006 New Revision: 382011 URL: http://svn.apache.org/viewcvs?rev=382011view=rev Log: tweak how tests run -you get the junit report if a trax impl is present -we fail afterwards if a test failed or errored -commonality of the two junit runs factored out

AW: svn commit: r381934 - /ant/core/trunk/docs/manual/cover.html

2006-03-01 Thread Jan.Materne
URL: http://svn.apache.org/viewcvs?rev=381934view=rev Log: Fix the strange bahaviour reported by Steve Meredith. Modified: ant/core/trunk/docs/manual/cover.html h1Apache Ant 1.7 Manual/h1 p align=leftThis is the manual for version 1.7alpha of - a

svn commit: r382017 - /ant/core/trunk/build.xml

2006-03-01 Thread stevel
Author: stevel Date: Wed Mar 1 05:49:04 2006 New Revision: 382017 URL: http://svn.apache.org/viewcvs?rev=382017view=rev Log: and turn off halting on failure until later Modified: ant/core/trunk/build.xml Modified: ant/core/trunk/build.xml URL:

svn commit: r382055 - /ant/core/trunk/build.xml

2006-03-01 Thread stevel
Author: stevel Date: Wed Mar 1 07:31:57 2006 New Revision: 382055 URL: http://svn.apache.org/viewcvs?rev=382055view=rev Log: let's not save XML reports to the project dir, but instead somewhere under build/ and stick the results in a directory parallel to it. Modified:

svn commit: r382058 - in /ant/core/trunk/src/etc: junit-frames.xsl log.xsl

2006-03-01 Thread stevel
Author: stevel Date: Wed Mar 1 07:33:07 2006 New Revision: 382058 URL: http://svn.apache.org/viewcvs?rev=382058view=rev Log: minor layout tweaks to make it slightly more readable, updated year and corrected an old URL Modified: ant/core/trunk/src/etc/junit-frames.xsl

Re: xalan2.present test broken

2006-03-01 Thread Jesse Glick
Steve Loughran wrote: We need a test for a trax engine being around, for things like junitreport. But this code doesnt work available property=xalan2.present classname=org.apache.xalan.transformer.TransformerImpl classpathref=classpath/ Not on java1.5, even though xsltc is

Re: svn commit: r381780 - in /ant/core/trunk: WHATSNEW docs/manual/OptionalTasks/junit.html src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTestRunner.java src/main/org/apache/tools/a

2006-03-01 Thread Jesse Glick
Stefan Bodewig wrote: I haven't looked into the implemenation of JUnit4TestAdapter so I have to ask you 8-) Sure, was expecting some questions here... Even if I have JUnit 4 on my CLASSPATH I can still use JUnit 3 style of tests (no annotations, naming conventions instead). Yes. Will

Re: svn commit: r381780 - in /ant/core/trunk: WHATSNEW docs/manual/OptionalTasks/junit.html src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTestRunner.java src/main/org/apache/tools/ant

2006-03-01 Thread Jesse Glick
Martijn Kruithof wrote: Isn't this a bit premature, junit 4 isn't even out yet. Seems junit.org has not announced it, but it's there for download and semi-announced at http://sourceforge.net/projects/junit. Furthermore I thought junit 4 would get rid of the distinction between failure and

Re: JUnit4 support - done?

2006-03-01 Thread Jesse Glick
Jon Skeet wrote: So, having just seen the commit and bug 38811 notes for JUnit4 support - does that mean it's all done? Well probably you should try it and judge for yourself whether it's working well enough. :-) The impl is a bit hackish due to the need to keep full JUnit 3

Re: Junut4 (was Re: svn commit: r381780 - in /ant/core/trunk: WHATSNEW docs/manual/OptionalTasks/junit.html src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTestRunner.java src/main/org/

2006-03-01 Thread Jesse Glick
Steve Loughran wrote: There was some discussion of junit4 implications in the ant-user mail list, Ah, thanks for the pointer, missed that before. Some things I can extract from that thread: - ignored tests ought to be reported (currently they are just silently skipped) - junit should

svn commit: r382127 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTestRunner.java

2006-03-01 Thread jglick
Author: jglick Date: Wed Mar 1 11:13:16 2006 New Revision: 382127 URL: http://svn.apache.org/viewcvs?rev=382127view=rev Log: Tweak: in case junit-3.8.1.jar and junit-4.0.jar are on CP but in that order, and running JDK 1.4-, at least run JUnit 3.x tests. Modified:

Re: svn commit: r382055 - /ant/core/trunk/build.xml

2006-03-01 Thread Jesse Glick
[EMAIL PROTECTED] wrote: let's not save XML reports to the project dir, but instead somewhere under build/ and stick the results in a directory parallel to it. URL: http://svn.apache.org/viewcvs/ant/core/trunk/build.xml?rev=382055r1=382054r2=382055view=diff @@ -1596,8 +1600,8 @@ -

DO NOT REPLY [Bug 38811] - Support JUnit 4

2006-03-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38811. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 38807] - Add an errorproperty parameter to sql task, like the junit task's

2006-03-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38807. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 38807] - Add an errorproperty parameter to sql task, like the junit task's

2006-03-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38807. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Re: svn commit: r381780 - in /ant/core/trunk: WHATSNEW docs/manual/OptionalTasks/junit.html src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTestRunner.java src/main/org/apache/tools/ant/t

2006-03-01 Thread Stefan Bodewig
On Wed, 01 Mar 2006, Jesse Glick [EMAIL PROTECTED] wrote: Stefan Bodewig wrote: Will this patch still allow me to run those tests? Or will wrapping the tests in a JUnit4TestAdapter force me to use annotations? No, you can still use the 3-compatible tests as before. Great. You do need

Re: Junut4

2006-03-01 Thread Stefan Bodewig
On Wed, 01 Mar 2006, Steve Loughran [EMAIL PROTECTED] wrote: Martijn Kruithof wrote: Furthermore I thought junit 4 would get rid of the distinction between failure and error, wouldn't we want to remain in-line with this new junit behaviour when running junit 4 testcases in an junit 4

Re: xalan2.present test broken

2006-03-01 Thread Stefan Bodewig
On Wed, 01 Mar 2006, Steve Loughran [EMAIL PROTECTED] wrote: We need a test for a trax engine being around, for things like junitreport. But this code doesnt work available property=xalan2.present classname=org.apache.xalan.transformer.TransformerImpl

Re: Junut4

2006-03-01 Thread Stefan Bodewig
On Wed, 01 Mar 2006, Jesse Glick [EMAIL PROTECTED] wrote: Not really clear to me at this point whether the significant features of JUnit 4 can be accommodated comfortably inside junit or whether a separate task would be better. +1 for a separate task, packaged in an Ant library. This one

Re: Junut4

2006-03-01 Thread Kev Jackson
+1 for a separate task, packaged in an Ant library. This one could be release before Ant 1.7.0 which would give people using JUnit4 more support sooner. Personally I'd even prefer the JUnit team to provide that Ant library so they have to keep up with their API changes themselves 8-) That

svn commit: r382315 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTaskMirror.java

2006-03-01 Thread kevj
Author: kevj Date: Wed Mar 1 23:42:41 2006 New Revision: 382315 URL: http://svn.apache.org/viewcvs?rev=382315view=rev Log: don't need final in interface Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTaskMirror.java Modified: