Re: Opportunities for cohesion improvement and refatoring.

2017-07-20 Thread Gintautas Grigelionis
I looked at Project proposal [1]. I would suggest running the refactored Ant through japicmp [2] or revapi [3] and examining the binary incompatibilities. Gintas [1] https://bz.apache.org/bugzilla/show_bug.cgi?id=61305 [2] http://siom79.github.io/japicmp/ [3] http://revapi.org/ 2017-07-20 16:41

Re: Opportunities for cohesion improvement and refatoring.

2017-07-20 Thread Stefan Bodewig
Welcome João Paulo On 2017-07-20, João Paulo Lemes Machado wrote: > I was analyzing the modularization of some classes of Ant, and I > identified some opportunities for cohesion improvement in the following > classes: > Javac > Javadoc > FTPTask > FileUtils > AbstractFileSet Similar to what I

Re: Coding style: import of nested classes

2017-07-20 Thread Jaikiran Pai
I have no personal preference for this specific kind of usages. Although I almost always use Map.Entry in the statements, I don't mind seeing code which uses just plain Entry. Having said that, for this specific kind of cases, I personally would just let the developer decide which form of it

Re: Opportunities for cohesion improvement and refatoring.

2017-07-20 Thread Gintautas Grigelionis
Hi João Paulo, please open a pull request on GitHub or at least provide a description of your suggested improvements. Thanks, Gintas 2017-07-20 1:56 GMT+02:00 João Paulo Lemes Machado : > Hello everyone. > > My name is João Paulo, I am a graduate student the Federal

Opportunities for cohesion improvement and refatoring.

2017-07-20 Thread João Paulo Lemes Machado
Hello everyone. My name is João Paulo, I am a graduate student the Federal University of Uberlandia, Brazil. I was analyzing the modularization of some classes of Ant, and I identified some opportunities for cohesion improvement in the following classes: Javac Javadoc FTPTask FileUtils

Opportunities for cohesion improvement and refatoring.

2017-07-20 Thread João Paulo Lemes Machado
Hello everyone. My name is João Paulo, I am a graduate student the Federal University of Uberlandia, Brazil. I was analyzing the modularization of some classes of Ant, and I identified some opportunities for cohesion improvement in the following classes: Javac Javadoc FTPTask FileUtils