Github user arcadius commented on the issue:
https://github.com/apache/ant/pull/31
Thank you very much @janmaterne for your help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user janmaterne commented on the issue:
https://github.com/apache/ant/pull/31
committed to master branch (Ant 1.10.x).
thanks for the patch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user arcadius commented on the issue:
https://github.com/apache/ant/pull/31
Hello @janmaterne ... is there anything i can do to help get this through?
Thank you very much.
Arcadius.
---
If your project is set up for it, you can reply to this email and ha
Github user arcadius commented on the issue:
https://github.com/apache/ant/pull/31
Thank you very much @janmaterne for taking the time to review the code.
Most appreciated. :+1:
I have made all suggested changes.
Feel free to have a look.
Many thanks.
Github user janmaterne commented on the issue:
https://github.com/apache/ant/pull/31
Haven't done a deep check, but first comments:
- overall it seems to be ok
- get.html: maybe a hint that key and value are trimmed and must not be
null or empty string
- get.html, example:
Github user arcadius commented on the issue:
https://github.com/apache/ant/pull/31
@mbenson , would you be able to review this pull request for me?
It is very similar to the email header that you worked on.
---
If your project is set up for it, you can reply to this email a