Vlad Rozov created APEXCORE-502:
---
Summary: Unnecessary byte array copy in
DefaultKryoStreamCodec.toByteArray
Key: APEXCORE-502
URL: https://issues.apache.org/jira/browse/APEXCORE-502
Project: Apache
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/324#discussion_r73969296
--- Diff:
library/src/main/java/org/apache/apex/malhar/lib/state/spillable/SpillableStateStore.java
---
@@ -0,0 +1,33 @@
+/**
+ * Licensed
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/324#discussion_r73966670
--- Diff:
library/src/main/java/org/apache/apex/malhar/lib/state/spillable/SpillableArrayListImpl.java
---
@@ -0,0 +1,324 @@
+/**
+ *
+1 for common abstract class and specific implementations that are use case
specific.
Regards,
Ashwin.
On Mon, Aug 8, 2016 at 7:55 AM, Devendra Tagare
wrote:
> + 1 for a common Abstract Class.
>
> 0 - for adding ports.
>
> Use-case for CSV - data migration from
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/324#discussion_r73941677
--- Diff:
library/src/main/java/org/apache/apex/malhar/lib/state/spillable/WindowListener.java
---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the
GitHub user sanjaypujare opened a pull request:
https://github.com/apache/apex-malhar/pull/362
JMS Input operator changes to support SQS and ActiveMQ
@PramodSSImmaneni these changes incorporate your comments and dont have
extraneous changes. Pls review and merge...
You can merge
[
https://issues.apache.org/jira/browse/APEXCORE-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412264#comment-15412264
]
ASF GitHub Bot commented on APEXCORE-496:
-
Github user tushargosavi commented on the issue:
Github user tushargosavi commented on the issue:
https://github.com/apache/apex-core/pull/361
@vrozov @sandeshh I have updated the pull request please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
The idea here was to create, on demand, recovery/committed window. But
there is always one(except before the first) recovery window for the DAG.
Instead of using/modifying the Checkpoint tuple, I am planning to reuse
the existing recovery window state, which simplifies the implementation.
+ 1 for a common Abstract Class.
0 - for adding ports.
Use-case for CSV - data migration from columnar stores.Some users may want
to move TB's of data from a store like Greenplum and then do
transformations using the CSV parser that is already present.
Thanks,
Dev
On Mon, Aug 8, 2016 at 7:39
+1 for Tushar's idea for common abstract class.
Additionally, POJO based output should be considered for active
development. CSV output can be deprecated. Since it can be achieved easily
using POJO + CSV formatter.
Operators are meant to be lego blocks for reusable functionality to achieve
I would prefer a common abstract class having emitTuple method. And
two different implementation one for emitting comma separated values
and other emitting pojo.
Regards,
-Tushar.
On Mon, Aug 8, 2016 at 5:34 PM, Priyanka Gugale
wrote:
> The concrete implementation is
The concrete implementation is supposed to do mainly formatting of input
data and emit in required form. Also it would be tricky to implement some
abstract methods like "getTuple", you have to conditionally return the
values.
-Priyanka
On Mon, Aug 8, 2016 at 4:49 PM, Bhupesh Chawda
[
https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411685#comment-15411685
]
ASF GitHub Bot commented on APEXMALHAR-2172:
Github user bhupeshchawda commented on a
I am +1 for having two ports in the same concrete implementation.
One port for POJOs and second one for CSV strings (if this is actually
needed)
+0 on having multiple concrete operators.
I don't think it is necessary to create multiple concrete implementations
just because we want the same data
Github user chaithu14 closed the pull request at:
https://github.com/apache/apex-malhar/pull/360
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user chaithu14 reopened a pull request:
https://github.com/apache/apex-malhar/pull/360
APEXMALHAR-2174-S3-ReaderIssue Fixed the S3 reader issue
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/APEXMALHAR-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411639#comment-15411639
]
ASF GitHub Bot commented on APEXMALHAR-2174:
Github user chaithu14 closed the pull
[
https://issues.apache.org/jira/browse/APEXMALHAR-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411640#comment-15411640
]
ASF GitHub Bot commented on APEXMALHAR-2174:
GitHub user chaithu14 reopened a pull
Github user yogidevendra commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/359#discussion_r73849743
--- Diff:
library/src/test/java/com/datatorrent/lib/io/fs/AbstractThroughputFileInputOperatorTest.java
---
@@ -0,0 +1,129 @@
+/**
+ *
[
https://issues.apache.org/jira/browse/APEXMALHAR-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411604#comment-15411604
]
ASF GitHub Bot commented on APEXMALHAR-2161:
Github user yogidevendra commented on a diff
[
https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411600#comment-15411600
]
ASF GitHub Bot commented on APEXMALHAR-2172:
Github user DT-Priyanka commented on a diff
[
https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411598#comment-15411598
]
ASF GitHub Bot commented on APEXMALHAR-2172:
Github user DT-Priyanka commented on a diff
Github user DT-Priyanka commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/358#discussion_r73848661
--- Diff:
library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java
---
@@ -438,119 +261,110 @@ public void endWindow()
[
https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411578#comment-15411578
]
ASF GitHub Bot commented on APEXMALHAR-2172:
Github user DT-Priyanka commented on a diff
[
https://issues.apache.org/jira/browse/APEXMALHAR-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411558#comment-15411558
]
ASF GitHub Bot commented on APEXMALHAR-2100:
Github user chaithu14 commented on a diff in
[
https://issues.apache.org/jira/browse/APEXMALHAR-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411565#comment-15411565
]
ASF GitHub Bot commented on APEXMALHAR-2100:
Github user chaithu14 commented on a diff in
[
https://issues.apache.org/jira/browse/APEXMALHAR-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411556#comment-15411556
]
ASF GitHub Bot commented on APEXMALHAR-2100:
Github user chaithu14 commented on a diff in
[
https://issues.apache.org/jira/browse/APEXMALHAR-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411569#comment-15411569
]
ASF GitHub Bot commented on APEXMALHAR-2100:
Github user chaithu14 commented on a diff in
[
https://issues.apache.org/jira/browse/APEXMALHAR-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411560#comment-15411560
]
ASF GitHub Bot commented on APEXMALHAR-2100:
Github user chaithu14 commented on a diff in
[
https://issues.apache.org/jira/browse/APEXMALHAR-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411557#comment-15411557
]
ASF GitHub Bot commented on APEXMALHAR-2100:
Github user chaithu14 commented on a diff in
[
https://issues.apache.org/jira/browse/APEXMALHAR-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411570#comment-15411570
]
ASF GitHub Bot commented on APEXMALHAR-2100:
Github user chaithu14 commented on a diff in
[
https://issues.apache.org/jira/browse/APEXMALHAR-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411567#comment-15411567
]
ASF GitHub Bot commented on APEXMALHAR-2100:
Github user chaithu14 commented on a diff in
[
https://issues.apache.org/jira/browse/APEXMALHAR-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411563#comment-15411563
]
ASF GitHub Bot commented on APEXMALHAR-2100:
Github user chaithu14 commented on a diff in
Github user chaithu14 commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/330#discussion_r73844379
--- Diff:
library/src/main/java/org/apache/apex/malhar/lib/state/managed/ManagedTimeStateMultiValue.java
---
@@ -0,0 +1,363 @@
+/**
+ *
Github user chaithu14 commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/330#discussion_r73844212
--- Diff:
library/src/main/java/com/datatorrent/lib/join/AbstractInnerJoinOperator.java
---
@@ -0,0 +1,331 @@
+/**
+ * Licensed to the Apache
Github user chaithu14 commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/330#discussion_r73844311
--- Diff:
library/src/main/java/com/datatorrent/lib/join/POJOInnerJoinOperator.java ---
@@ -0,0 +1,248 @@
+/**
+ * Licensed to the Apache
Github user chaithu14 commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/330#discussion_r73844328
--- Diff:
library/src/main/java/com/datatorrent/lib/join/POJOInnerJoinOperator.java ---
@@ -0,0 +1,248 @@
+/**
+ * Licensed to the Apache
Github user chaithu14 commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/330#discussion_r73844275
--- Diff:
library/src/main/java/com/datatorrent/lib/join/InnerJoinStreamCodec.java ---
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache
Github user chaithu14 commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/330#discussion_r73844228
--- Diff:
library/src/main/java/com/datatorrent/lib/join/AbstractManagedStateInnerJoinOperator.java
---
@@ -0,0 +1,354 @@
+/**
+ * Licensed
Github user chaithu14 commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/330#discussion_r73844300
--- Diff:
library/src/main/java/com/datatorrent/lib/join/POJOInnerJoinOperator.java ---
@@ -0,0 +1,248 @@
+/**
+ * Licensed to the Apache
Github user chaithu14 commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/330#discussion_r73844285
--- Diff:
library/src/main/java/com/datatorrent/lib/join/POJOInnerJoinOperator.java ---
@@ -0,0 +1,248 @@
+/**
+ * Licensed to the Apache
Github user chaithu14 commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/330#discussion_r73844252
--- Diff:
library/src/main/java/com/datatorrent/lib/join/AbstractManagedStateInnerJoinOperator.java
---
@@ -0,0 +1,354 @@
+/**
+ * Licensed
[
https://issues.apache.org/jira/browse/APEXMALHAR-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411555#comment-15411555
]
ASF GitHub Bot commented on APEXMALHAR-2100:
Github user chaithu14 commented on a diff in
[
https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411548#comment-15411548
]
ASF GitHub Bot commented on APEXMALHAR-2172:
Github user DT-Priyanka commented on a diff
Github user DT-Priyanka commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/358#discussion_r73843385
--- Diff:
library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java
---
@@ -80,201 +91,45 @@
* @tags database,
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/358#discussion_r73843244
--- Diff:
library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java
---
@@ -286,149 +141,117 @@ public
[
https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411544#comment-15411544
]
ASF GitHub Bot commented on APEXMALHAR-2172:
Github user bhupeshchawda commented on a
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/358#discussion_r73842885
--- Diff:
library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java
---
@@ -438,119 +261,110 @@ public void
[
https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411531#comment-15411531
]
ASF GitHub Bot commented on APEXMALHAR-2172:
Github user bhupeshchawda commented on a
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/358#discussion_r73841819
--- Diff:
library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java
---
@@ -438,119 +261,110 @@ public void
Github user DT-Priyanka commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/358#discussion_r73841763
--- Diff:
library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java
---
@@ -438,119 +261,110 @@ public void endWindow()
[
https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411521#comment-15411521
]
ASF GitHub Bot commented on APEXMALHAR-2172:
Github user DT-Priyanka commented on a diff
Github user DT-Priyanka commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/358#discussion_r73841414
--- Diff:
library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java
---
@@ -438,119 +261,110 @@ public void endWindow()
[
https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411515#comment-15411515
]
ASF GitHub Bot commented on APEXMALHAR-2172:
Github user DT-Priyanka commented on a diff
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/358#discussion_r73840984
--- Diff:
library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java
---
@@ -438,119 +261,110 @@ public void
[
https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411512#comment-15411512
]
ASF GitHub Bot commented on APEXMALHAR-2172:
Github user bhupeshchawda commented on a
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/358#discussion_r73840151
--- Diff:
library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java
---
@@ -438,119 +261,110 @@ public void
[
https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411480#comment-15411480
]
ASF GitHub Bot commented on APEXMALHAR-2172:
Github user bhupeshchawda commented on a
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/358#discussion_r73838062
--- Diff:
library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java
---
@@ -80,201 +91,45 @@
* @tags database,
[
https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411473#comment-15411473
]
ASF GitHub Bot commented on APEXMALHAR-2172:
Github user bhupeshchawda commented on a
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/358#discussion_r73830019
--- Diff:
library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java
---
@@ -438,119 +261,110 @@ public void
[
https://issues.apache.org/jira/browse/APEXMALHAR-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Kolhatkar resolved APEXMALHAR-1701.
---
Resolution: Done
Fix Version/s: 3.5.0
PR for deduper with managed
[
https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411406#comment-15411406
]
ASF GitHub Bot commented on APEXMALHAR-2172:
Github user bhupeshchawda commented on a
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/358#discussion_r73828487
--- Diff:
library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java
---
@@ -80,201 +91,45 @@
* @tags database,
Github user chinmaykolhatkar commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/330#discussion_r73828318
--- Diff:
library/src/main/java/com/datatorrent/lib/join/POJOInnerJoinOperator.java ---
@@ -0,0 +1,248 @@
+/**
+ * Licensed to the
[
https://issues.apache.org/jira/browse/APEXMALHAR-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411403#comment-15411403
]
ASF GitHub Bot commented on APEXMALHAR-2100:
Github user chinmaykolhatkar commented on a
[
https://issues.apache.org/jira/browse/APEXMALHAR-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411388#comment-15411388
]
Siyuan Hua commented on APEXMALHAR-2169:
[~chaithu]
Then I think the problem is in
[
https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411374#comment-15411374
]
ASF GitHub Bot commented on APEXMALHAR-2172:
Github user bhupeshchawda commented on a
69 matches
Mail list logo