[GitHub] apex-core pull request #541: APEXCORE-622 Made data members for Default Port...

2017-06-07 Thread bhupeshchawda
GitHub user bhupeshchawda opened a pull request: https://github.com/apache/apex-core/pull/541 APEXCORE-622 Made data members for Default Port classes as private wi… …th protected access methods @vrozov please see. You can merge this pull request into a Git repository

[GitHub] apex-malhar pull request #632: APEXMALHAR-2488 APEXMALHAR-2503 Deprecated in...

2017-06-02 Thread bhupeshchawda
GitHub user bhupeshchawda opened a pull request: https://github.com/apache/apex-malhar/pull/632 APEXMALHAR-2488 APEXMALHAR-2503 Deprecated inner join operator and co… …mmented out the tests @tweise @chaithu14 Please see comments on https://issues.apache.org/jira/browse

[GitHub] apex-core pull request #509: APEXCORE-678 Fixed shutdown of input nodes in S...

2017-04-13 Thread bhupeshchawda
GitHub user bhupeshchawda opened a pull request: https://github.com/apache/apex-core/pull/509 APEXCORE-678 Fixed shutdown of input nodes in StreamingContainer This was a straightforward bug. Also did not find any easy way to add test for it. @tushargosavi please see You

[GitHub] apex-core pull request #497: [REVIEW-ONLY] APEXCORE-654 fix update recovery ...

2017-03-25 Thread bhupeshchawda
GitHub user bhupeshchawda opened a pull request: https://github.com/apache/apex-core/pull/497 [REVIEW-ONLY] APEXCORE-654 fix update recovery window when delay part of group You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] apex-core pull request #484: [REVIEW ONLY] APEXCORE-660 Added documentation ...

2017-03-14 Thread bhupeshchawda
GitHub user bhupeshchawda opened a pull request: https://github.com/apache/apex-core/pull/484 [REVIEW ONLY] APEXCORE-660 Added documentation for custom control tuple support @tweise Please see. Currently just opened PR for review. Waiting for any other comments over the

[GitHub] apex-core pull request #482: APEXCORE-580 APEXCORE-581 Renamed UserDefinedCo...

2017-03-06 Thread bhupeshchawda
GitHub user bhupeshchawda opened a pull request: https://github.com/apache/apex-core/pull/482 APEXCORE-580 APEXCORE-581 Renamed UserDefinedControlTuple to ControlT… …uple @PramodSSImmaneni Please see. Also regarding your second comment regarding control aware stream

[GitHub] apex-malhar pull request #567: *DO NOT MERGE - REVIEW_ONLY* - Changes in Fil...

2017-02-28 Thread bhupeshchawda
GitHub user bhupeshchawda opened a pull request: https://github.com/apache/apex-malhar/pull/567 *DO NOT MERGE - REVIEW_ONLY* - Changes in File Input / Output operators for Batch 3 Changes: 1. Pointing to apex-core 3.6.0-SNAPSHOT for Control Tuple Support 2. Modifying

[GitHub] apex-core pull request #440: APEXCORE-580-581 custom control tuple support

2017-02-21 Thread bhupeshchawda
Github user bhupeshchawda closed the pull request at: https://github.com/apache/apex-core/pull/440 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] apex-core pull request #440: APEXCORE-580-581 custom control tuple support

2017-02-21 Thread bhupeshchawda
GitHub user bhupeshchawda reopened a pull request: https://github.com/apache/apex-core/pull/440 APEXCORE-580-581 custom control tuple support You can merge this pull request into a Git repository by running: $ git pull https://github.com/bhupeshchawda/apex-core APEXCORE-580

[GitHub] apex-malhar pull request #534: APEXMALHAR-2354 Support for heuristic waterma...

2017-01-17 Thread bhupeshchawda
GitHub user bhupeshchawda opened a pull request: https://github.com/apache/apex-malhar/pull/534 APEXMALHAR-2354 Support for heuristic watermark @davidyan74 @chinmaykolhatkar Please see. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] apex-core pull request #440: [REVIEW ONLY] - APEXCORE-580-581 custom control...

2017-01-03 Thread bhupeshchawda
GitHub user bhupeshchawda opened a pull request: https://github.com/apache/apex-core/pull/440 [REVIEW ONLY] - APEXCORE-580-581 custom control tuple support You can merge this pull request into a Git repository by running: $ git pull https://github.com/bhupeshchawda/apex-core

[GitHub] apex-malhar pull request #508: APEXMALHAR-2353 Made timeExpression as @NotNu...

2016-11-23 Thread bhupeshchawda
GitHub user bhupeshchawda opened a pull request: https://github.com/apache/apex-malhar/pull/508 APEXMALHAR-2353 Made timeExpression as @NotNull @chinmaykolhatkar Please review and merge You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] apex-core pull request #413: APEXCORE-560: Fixed logical operator removal wh...

2016-10-20 Thread bhupeshchawda
GitHub user bhupeshchawda opened a pull request: https://github.com/apache/apex-core/pull/413 APEXCORE-560: Fixed logical operator removal when all physical partit… …ions are removed Added unit test. @tushargosavi Please review You can merge this pull request into

[GitHub] apex-malhar pull request #397: APEXMALHAR-2219: Added documentation for Dedu...

2016-09-01 Thread bhupeshchawda
GitHub user bhupeshchawda opened a pull request: https://github.com/apache/apex-malhar/pull/397 APEXMALHAR-2219: Added documentation for Deduper You can merge this pull request into a Git repository by running: $ git pull https://github.com/bhupeshchawda/apex-malhar

[GitHub] apex-malhar pull request #383: APEXMALHAR-2206: Fixed application test. Limi...

2016-08-26 Thread bhupeshchawda
GitHub user bhupeshchawda opened a pull request: https://github.com/apache/apex-malhar/pull/383 APEXMALHAR-2206: Fixed application test. Limited the input rate for t… …he test app. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] apex-malhar pull request #369: Added Bounded Deduper

2016-08-12 Thread bhupeshchawda
GitHub user bhupeshchawda opened a pull request: https://github.com/apache/apex-malhar/pull/369 Added Bounded Deduper 1. Refactored Abstract implementation for flexibility for future implementations 2. Added Dedup implementation for bounded data and tests You can merge this

[GitHub] apex-malhar pull request #369: Added Bounded Deduper

2016-08-12 Thread bhupeshchawda
Github user bhupeshchawda closed the pull request at: https://github.com/apache/apex-malhar/pull/369 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] apex-malhar pull request #369: Added Bounded Deduper

2016-08-12 Thread bhupeshchawda
GitHub user bhupeshchawda reopened a pull request: https://github.com/apache/apex-malhar/pull/369 Added Bounded Deduper 1. Refactored Abstract implementation for flexibility for future implementations 2. Added Dedup implementation for bounded data and tests You can merge this

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-09 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74187632 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/JdbcPOJOPollInputOperator.java --- @@ -0,0 +1,321 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-09 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74187569 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -638,24 +504,191 @@ public void partitioned

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-09 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74187536 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -638,24 +504,191 @@ public void partitioned

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-09 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74187324 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -286,271 +141,238 @@ public

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-09 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74187296 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -286,271 +141,238 @@ public

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-09 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74015429 --- Diff: library/src/test/java/com/datatorrent/lib/db/jdbc/JdbcPojoPollableOpeartorTest.java --- @@ -0,0 +1,251 @@ +/** + * Licensed to

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-09 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74015328 --- Diff: library/src/test/java/com/datatorrent/lib/db/jdbc/JdbcPojoPollableOpeartorTest.java --- @@ -0,0 +1,251 @@ +/** + * Licensed to

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-09 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74013531 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/JdbcPOJOPollInputOperator.java --- @@ -0,0 +1,321 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-09 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74012725 --- Diff: library/src/test/java/com/datatorrent/lib/db/jdbc/JdbcPojoPollableOpeartorTest.java --- @@ -0,0 +1,251 @@ +/** + * Licensed to

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-09 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74011772 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/JdbcPollInputOperator.java --- @@ -18,214 +18,75 @@ */ package

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74005996 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/JdbcPOJOPollInputOperator.java --- @@ -0,0 +1,321 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74006020 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/JdbcPOJOPollInputOperator.java --- @@ -0,0 +1,321 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74005794 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/JdbcPollInputOperator.java --- @@ -18,214 +18,75 @@ */ package

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74005624 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -27,48 +27,62 @@ import

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74005458 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -27,48 +27,62 @@ import

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74005324 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -27,48 +27,62 @@ import

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74005037 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -286,271 +146,233 @@ public

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74004337 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -286,271 +146,233 @@ public

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74004125 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -438,119 +261,110 @@ public void endWindow

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74004081 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -438,119 +261,110 @@ public void endWindow

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74003783 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -286,149 +141,117 @@ public

[GitHub] apex-malhar pull request #358: APEXMALHAR-2172: Updates to JDBC Poll Input O...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r74003272 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -286,271 +146,233 @@ public

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73859472 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -80,201 +91,45 @@ * @tags database

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73843244 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -286,149 +141,117 @@ public

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73842885 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -438,119 +261,110 @@ public void endWindow

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73841819 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -438,119 +261,110 @@ public void endWindow

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73840984 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -438,119 +261,110 @@ public void endWindow

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73840151 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -438,119 +261,110 @@ public void endWindow

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73838593 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -438,119 +261,110 @@ public void endWindow

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73838062 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -80,201 +91,45 @@ * @tags database

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-08 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73830019 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -438,119 +261,110 @@ public void endWindow

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-07 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73828487 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -80,201 +91,45 @@ * @tags database

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-07 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73828043 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -286,149 +141,117 @@ public

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-07 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73826686 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -565,67 +379,110 @@ public void

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-07 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73824180 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -80,201 +91,45 @@ * @tags database

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-07 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73823756 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -80,201 +91,45 @@ * @tags database

[GitHub] apex-malhar pull request #343: [Review Only] APEXMALHAR-1701: Deduper using ...

2016-08-07 Thread bhupeshchawda
Github user bhupeshchawda closed the pull request at: https://github.com/apache/apex-malhar/pull/343 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-03 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r7333 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -286,149 +146,119 @@ public

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-03 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73326772 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -286,149 +146,119 @@ public

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-03 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73326407 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -80,201 +93,48 @@ * @tags database

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-03 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73326356 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -80,201 +93,48 @@ * @tags database

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-03 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73326138 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -286,149 +146,119 @@ public

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-03 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73321098 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -80,201 +93,48 @@ * @tags database

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-03 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73320816 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -80,201 +93,48 @@ * @tags database

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-03 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73320448 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -80,201 +93,48 @@ * @tags database

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-03 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73319997 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -80,201 +93,48 @@ * @tags database

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-03 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73319897 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -80,201 +93,48 @@ * @tags database

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-03 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73319799 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -80,201 +93,48 @@ * @tags database

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-03 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73319725 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -80,201 +93,48 @@ * @tags database

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-03 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73319381 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -51,22 +64,22 @@ import

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-03 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73319137 --- Diff: library/pom.xml --- @@ -335,6 +335,12 @@ 7.0.6 + org.jooq + jooq + 3.6.4

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-03 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r73296580 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -80,201 +93,48 @@ * @tags database

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73161100 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,459 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73160693 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,459 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73160600 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,459 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73160639 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,459 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73160450 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,459 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73160437 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,459 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73156767 --- Diff: library/src/test/java/org/apache/apex/malhar/lib/dedup/DeduperIdempotencyTest.java --- @@ -0,0 +1,132 @@ +/** + * Licensed to

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73156746 --- Diff: library/src/test/java/org/apache/apex/malhar/lib/dedup/DeduperPartitioningTest.java --- @@ -0,0 +1,171 @@ +/** + * Licensed to

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73155029 --- Diff: library/src/test/java/org/apache/apex/malhar/lib/dedup/DeduperIdempotencyTest.java --- @@ -0,0 +1,132 @@ +/** + * Licensed to

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73142080 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,459 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73141988 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/DeduperStreamCodec.java --- @@ -0,0 +1,45 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73139110 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,462 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73138996 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/DeduperStreamCodec.java --- @@ -0,0 +1,45 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73139012 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,462 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73132546 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,462 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73132603 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,462 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73132123 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,463 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73132107 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,462 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73115146 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/DeduperTimeBasedPOJOImpl.java --- @@ -0,0 +1,209 @@ +/** + * Licensed to

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73115095 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/DeduperTimeBasedPOJOImpl.java --- @@ -0,0 +1,209 @@ +/** + * Licensed to

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-02 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73114470 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/DeduperTimeBasedPOJOImpl.java --- @@ -0,0 +1,209 @@ +/** + * Licensed to

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-01 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73102835 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,462 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-01 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73102615 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,462 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-01 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73102463 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,462 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #335: [Review Only] APEXMALHAR-1701 Deduper with Ma...

2016-08-01 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/335#discussion_r73101735 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java --- @@ -0,0 +1,462 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...

2016-08-01 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/358#discussion_r72958642 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -80,201 +93,48 @@ * @tags database

[GitHub] apex-malhar pull request #353: APEXMALHAR-2153 Adding user docs for POJOEnri...

2016-07-31 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/353#discussion_r72930965 --- Diff: docs/operators/enricher.md --- @@ -0,0 +1,169 @@ +POJO Enricher += + +## Operator Objective +This

[GitHub] apex-malhar pull request #353: APEXMALHAR-2153 Adding user docs for POJOEnri...

2016-07-31 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/353#discussion_r72930798 --- Diff: docs/operators/enricher.md --- @@ -0,0 +1,169 @@ +POJO Enricher += + +## Operator Objective +This

[GitHub] apex-malhar pull request #353: APEXMALHAR-2153 Adding user docs for POJOEnri...

2016-07-31 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/353#discussion_r72930763 --- Diff: docs/operators/enricher.md --- @@ -0,0 +1,169 @@ +POJO Enricher += + +## Operator Objective +This

[GitHub] apex-malhar pull request #353: APEXMALHAR-2153 Adding user docs for POJOEnri...

2016-07-31 Thread bhupeshchawda
Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/353#discussion_r72930659 --- Diff: docs/operators/enricher.md --- @@ -0,0 +1,169 @@ +POJO Enricher += + +## Operator Objective +This

  1   2   3   >