Github user PramodSSImmaneni commented on the issue:
https://github.com/apache/apex-core/pull/364
Yes @chandnisingh please make it volatile or have some other mechanism of
passing the information between threads.
---
If your project is set up for it, you can reply to this email and h
Github user vrozov commented on the issue:
https://github.com/apache/apex-core/pull/364
As far as I can see not all changes are correct (please see my comments
regarding UnifierDeployInfo and access from two different threads to the
operatorName). It will be good to have them fixed an
Github user PramodSSImmaneni commented on the issue:
https://github.com/apache/apex-core/pull/364
I second it, please reopen this PR and I will merge it. I think we have
spent enough time on the tests and everyone's inputs have been valuable. There
will be other opportunities in futur
Github user tweise commented on the issue:
https://github.com/apache/apex-core/pull/364
This pull request attracts a lot of attention... Not to spoil the party,
but this looks like a rather minor change and there are many other pull
requests that I would consider of much higher import
Github user chandnisingh commented on the issue:
https://github.com/apache/apex-core/pull/364
@vrozov @PramodSSImmaneni
Please have another look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user chandnisingh commented on the issue:
https://github.com/apache/apex-core/pull/364
Oh my I thought this was a simple change :)
Changing the ```OperatorContext(...)``` signature. Will update once that is
done
---
If your project is set up for it, you can reply to this
Github user chandnisingh commented on the issue:
https://github.com/apache/apex-core/pull/364
Addressed all the review comments so far
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user chandnisingh commented on the issue:
https://github.com/apache/apex-core/pull/364
Changed the method to ```getName()```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user chandnisingh commented on the issue:
https://github.com/apache/apex-core/pull/364
I have addressed the review comments so far.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user ilooner commented on the issue:
https://github.com/apache/apex-core/pull/364
@chandnisingh lgtm once unit test is updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user chandnisingh commented on the issue:
https://github.com/apache/apex-core/pull/364
@PramodSSImmaneni please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
11 matches
Mail list logo
