I agree with Pramod. Current order + org.apache.apex.* with delta change.
IMO, com.datatorrent.* should be after org.apache.apex.
For example, if some company xyz is developing their applications on top of
apex; they would put com.xyz.* after org.apache.apex.
I understand that, com.datatorrent.*
I would prefer to have org.apache.apex with other org.apache projects as
Vlad suggested. Rest what we have is good w.t.r. standard practices
followed.
-Priyanka
On Thu, Apr 7, 2016 at 4:09 AM, Pramod Immaneni
wrote:
> Like original suggestion from Chandni, current order + org.apache.apex.* at
>
[
https://issues.apache.org/jira/browse/APEXMALHAR-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229535#comment-15229535
]
ASF GitHub Bot commented on APEXMALHAR-2025:
GitHub user PramodSSImmaneni
GitHub user PramodSSImmaneni opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/236
APEXMALHAR-2025 Fixed the operator package
@chandnisingh please review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Pr
[
https://issues.apache.org/jira/browse/APEXMALHAR-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chandni Singh updated APEXMALHAR-2047:
--
Summary: Create Factory Which Can Easily Create A Single Spillable Data
Structure
[
https://issues.apache.org/jira/browse/APEXMALHAR-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chandni Singh updated APEXMALHAR-2047:
--
Assignee: Timothy Farkas (was: Chandni Singh)
> Create Factory Which Can Easily Cr
[
https://issues.apache.org/jira/browse/APEXMALHAR-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chandni Singh updated APEXMALHAR-2026:
--
Summary: Spill-able Datastructures (was: Spooled Datastructures)
> Spill-able Data
[
https://issues.apache.org/jira/browse/APEXMALHAR-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chandni Singh updated APEXMALHAR-2046:
--
Summary: Introduce Spill-able data-structure interfaces (was: Create
SpillableComp
[
https://issues.apache.org/jira/browse/APEXMALHAR-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229390#comment-15229390
]
Timothy Farkas commented on APEXMALHAR-2026:
Interfaces are in. The next
[
https://issues.apache.org/jira/browse/APEXMALHAR-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chandni Singh updated APEXMALHAR-2025:
--
Affects Version/s: 3.4.0
> Move FileLineInputOperator out of AbstractFileInputOpera
[
https://issues.apache.org/jira/browse/APEXMALHAR-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chandni Singh reopened APEXMALHAR-2025:
---
Please move the org.apache.apex.fs under org.apache.apex.lib.fs
> Move FileLineInp
[
https://issues.apache.org/jira/browse/APEXCORE-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229358#comment-15229358
]
ASF GitHub Bot commented on APEXCORE-421:
-
Github user chandnisingh commented on
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/296#discussion_r58800303
--- Diff: engine/src/main/java/com/datatorrent/stram/engine/InputNode.java
---
@@ -241,11 +241,14 @@ else if (PROCESSING_MODE ==
Processing
[
https://issues.apache.org/jira/browse/APEXMALHAR-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chandni Singh updated APEXMALHAR-2046:
--
Summary: Create SpillableComplexComponent Interface And Data Structure
Interfaces
[
https://issues.apache.org/jira/browse/APEXMALHAR-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chandni Singh resolved APEXMALHAR-2046.
---
Resolution: Fixed
Fix Version/s: 3.4.0
> Create SpillableComplexComponent
[
https://issues.apache.org/jira/browse/APEXCORE-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229346#comment-15229346
]
ASF GitHub Bot commented on APEXCORE-421:
-
Github user ilooner commented on the
Github user ilooner commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/296#issuecomment-206621280
@chandnisingh please review and merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
[
https://issues.apache.org/jira/browse/APEXMALHAR-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229344#comment-15229344
]
ASF GitHub Bot commented on APEXMALHAR-2046:
Github user asfgit closed th
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/232
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Like original suggestion from Chandni, current order + org.apache.apex.* at
the end.
On Wed, Apr 6, 2016 at 3:36 PM, Vlad Rozov wrote:
> I would prefer not to change the current import order and once
> org.apache.apex is introduced to keep it together with the org.apache
> group. It will be extr
[
https://issues.apache.org/jira/browse/APEXCORE-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229266#comment-15229266
]
ASF GitHub Bot commented on APEXCORE-421:
-
Github user ilooner commented on the
Github user ilooner commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/296#issuecomment-206598592
@davidyan74 please review and merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
I would prefer not to change the current import order and once
org.apache.apex is introduced to keep it together with the org.apache
group. It will be extremely inconvenient to work on different branches
with different import orders.
Thank you,
Vlad
On 4/6/16 13:18, Munagala Ramanath wrote:
Timothy Farkas created APEXMALHAR-2048:
--
Summary: Create concrete implementations using managed state.
Key: APEXMALHAR-2048
URL: https://issues.apache.org/jira/browse/APEXMALHAR-2048
Project: Apac
[
https://issues.apache.org/jira/browse/APEXMALHAR-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229023#comment-15229023
]
ASF GitHub Bot commented on APEXMALHAR-2046:
Github user chandnisingh com
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/232#discussion_r58775045
--- Diff:
library/src/main/java/org/apache/apex/malhar/lib/spillable/SpillableComponentManager.java
---
@@ -0,0 +1,122 @@
+/*
+
I prefer imports to be organized in groups with the groups themselves
ordered by decreasing order of "scope" where I
consider java to have the widest scope and com.datatorrent the narrowest
(roughly the way we have it now) with a
single blank line separating groups. When "scope" is not clear we can
+1 for David's suggestion except for the blank lines.
On Wed, Apr 6, 2016 at 11:30 AM, Chandni Singh
wrote:
> Except the blanks lines I agree with David.
>
> It is future proof to have everything in lexicographic order.
>
> Will still like to have blank lines.
> Chandni
>
> On Wed, Apr 6, 2016 a
Except the blanks lines I agree with David.
It is future proof to have everything in lexicographic order.
Will still like to have blank lines.
Chandni
On Wed, Apr 6, 2016 at 12:24 PM, David Yan wrote:
> I think the import order should be alphabetical or lexicographical, and no
> blank lines ar
I think the import order should be alphabetical or lexicographical, and no
blank lines are needed.
The reason is this:
1) It's simple and future proof, and there will be no need to have this
discussion again in the future about what order it should be and where the
blank lines should be placed
2)
Github user amberarrow commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/297#discussion_r58765782
--- Diff: docs/apex_development_setup.md ---
@@ -94,6 +94,42 @@ When the run completes successfully, you should see a
new directory named `mya
Github user chandnisingh commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/298#issuecomment-206520902
@davidyan74 @tweise please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
[
https://issues.apache.org/jira/browse/APEXCORE-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228928#comment-15228928
]
ASF GitHub Bot commented on APEXCORE-422:
-
Github user chandnisingh commented on
[
https://issues.apache.org/jira/browse/APEXCORE-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228927#comment-15228927
]
ASF GitHub Bot commented on APEXCORE-422:
-
GitHub user chandnisingh opened a pul
GitHub user chandnisingh opened a pull request:
https://github.com/apache/incubator-apex-core/pull/298
APEXCORE-422 removed the rule which doesn't allow parameterized annotâ¦
â¦ation on the same line as the target
You can merge this pull request into a Git repository by running:
[
https://issues.apache.org/jira/browse/APEXCORE-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chandni Singh updated APEXCORE-422:
---
Summary: Remove checkstyle rule of not allowing parameterized annotation on
the same line as
Github user sandeshh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/297#discussion_r58764149
--- Diff: docs/apex_development_setup.md ---
@@ -94,6 +94,42 @@ When the run completes successfully, you should see a
new directory named `myape
[
https://issues.apache.org/jira/browse/APEXMALHAR-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Farkas updated APEXMALHAR-2046:
---
Summary: Create SpillableComposite Interface And Data Structure Interfaces
(was:
Timothy Farkas created APEXMALHAR-2047:
--
Summary: Create Factory Which Can Easily Create A Single Spoolable
Data Structure
Key: APEXMALHAR-2047
URL: https://issues.apache.org/jira/browse/APEXMALHAR-2047
[
https://issues.apache.org/jira/browse/APEXCORE-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chandni Singh updated APEXCORE-422:
---
Description:
Right now we are not letting users to write the following
{code}
for (@Suppress
[
https://issues.apache.org/jira/browse/APEXMALHAR-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228887#comment-15228887
]
Timothy Farkas commented on APEXMALHAR-2026:
byte[] optimization will be
Chandni Singh created APEXCORE-422:
--
Summary: Remove checkstyle rule of not allowing parameterized
annotations on the same line
Key: APEXCORE-422
URL: https://issues.apache.org/jira/browse/APEXCORE-422
GitHub user chinmaykolhatkar opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/235
APEXMALHAR-2023 Enricher
POJO and Map Enricher along with File and JDBC loader.
@tushargosavi Please review
You can merge this pull request into a Git repository by
[
https://issues.apache.org/jira/browse/APEXMALHAR-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228653#comment-15228653
]
ASF GitHub Bot commented on APEXMALHAR-2023:
GitHub user chinmaykolhatkar
Github user amberarrow commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/297#discussion_r58738987
--- Diff: docs/apex_development_setup.md ---
@@ -94,6 +94,38 @@ When the run completes successfully, you should see a
new directory named `mya
[
https://issues.apache.org/jira/browse/APEXCORE-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandesh closed APEXCORE-407.
https://github.com/apache/incubator-apex-core/commit/062c01ae6e0bdc00801d7978a1a9774f98398d73
Will be availab
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/297#discussion_r58737026
--- Diff: docs/apex_development_setup.md ---
@@ -94,6 +94,38 @@ When the run completes successfully, you should see a
new directory named `myape
[
https://issues.apache.org/jira/browse/APEXCORE-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandesh resolved APEXCORE-407.
--
Resolution: Fixed
Fix Version/s: 3.4.0
Change is merged will be available in next release
> Ad
[
https://issues.apache.org/jira/browse/APEXCORE-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandesh resolved APEXCORE-412.
--
Resolution: Fixed
Assignee: Sandesh
Fix Version/s: 3.4.0
> Javadoc - THREAD_LOCAL - re
[
https://issues.apache.org/jira/browse/APEXCORE-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandesh closed APEXCORE-412.
> Javadoc - THREAD_LOCAL - remove "not implemented" line
> ---
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/297#discussion_r58736703
--- Diff: docs/apex_development_setup.md ---
@@ -94,6 +94,38 @@ When the run completes successfully, you should see a
new directory named `myape
GitHub user amberarrow opened a pull request:
https://github.com/apache/incubator-apex-core/pull/297
Add doc section on running unit tests
Added section on running unit tests and installing winutils.exe on Windows.
@tweise Please review and merge
You can merge this pull request
[
https://issues.apache.org/jira/browse/APEXMALHAR-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228300#comment-15228300
]
ASF GitHub Bot commented on APEXMALHAR-1966:
Github user bhupeshchawda co
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/227#discussion_r58711090
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/cassandra/CassandraPOJOOutputOperator.java
---
@@ -172,25 +197,32 @@ public voi
[
https://issues.apache.org/jira/browse/APEXMALHAR-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228297#comment-15228297
]
ASF GitHub Bot commented on APEXMALHAR-1966:
Github user bhupeshchawda co
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/227#discussion_r58710629
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/cassandra/CassandraPOJOOutputOperator.java
---
@@ -102,20 +92,31 @@ public Cass
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/227#discussion_r58710287
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/cassandra/CassandraPOJOOutputOperator.java
---
@@ -50,17 +49,21 @@
* @sin
[
https://issues.apache.org/jira/browse/APEXMALHAR-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228294#comment-15228294
]
ASF GitHub Bot commented on APEXMALHAR-1966:
Github user bhupeshchawda co
[
https://issues.apache.org/jira/browse/APEXMALHAR-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228288#comment-15228288
]
ASF GitHub Bot commented on APEXMALHAR-1966:
Github user bhupeshchawda co
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/227#discussion_r58709506
--- Diff:
contrib/src/test/java/com/datatorrent/contrib/cassandra/CassandraOperatorTest.java
---
@@ -301,6 +324,59 @@ public void testC
[
https://issues.apache.org/jira/browse/APEXMALHAR-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228282#comment-15228282
]
ASF GitHub Bot commented on APEXMALHAR-1966:
Github user bhupeshchawda co
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/227#discussion_r58708886
--- Diff:
contrib/src/test/java/com/datatorrent/contrib/cassandra/CassandraOperatorTest.java
---
@@ -301,6 +324,59 @@ public void testC
[
https://issues.apache.org/jira/browse/APEXMALHAR-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228269#comment-15228269
]
ASF GitHub Bot commented on APEXMALHAR-1966:
Github user bhupeshchawda co
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/227#discussion_r58707219
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/cassandra/CassandraPOJOOutputOperator.java
---
@@ -260,6 +292,17 @@ protected S
[
https://issues.apache.org/jira/browse/APEXMALHAR-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228275#comment-15228275
]
ASF GitHub Bot commented on APEXMALHAR-1966:
Github user bhupeshchawda co
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/227#discussion_r58708006
--- Diff:
contrib/src/test/java/com/datatorrent/contrib/cassandra/CassandraOperatorTest.java
---
@@ -269,15 +269,38 @@ public void test
[
https://issues.apache.org/jira/browse/APEXMALHAR-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228274#comment-15228274
]
ASF GitHub Bot commented on APEXMALHAR-1966:
Github user bhupeshchawda co
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/227#discussion_r58707688
--- Diff:
contrib/src/test/java/com/datatorrent/contrib/cassandra/CassandraOperatorTest.java
---
@@ -269,15 +269,38 @@ public void test
[
https://issues.apache.org/jira/browse/APEXMALHAR-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228253#comment-15228253
]
ASF GitHub Bot commented on APEXMALHAR-1966:
Github user bhupeshchawda co
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/227#discussion_r58705647
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/cassandra/CassandraPOJOOutputOperator.java
---
@@ -260,6 +292,17 @@ protected S
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/227#discussion_r58705296
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/cassandra/CassandraPOJOOutputOperator.java
---
@@ -172,25 +197,32 @@ public voi
[
https://issues.apache.org/jira/browse/APEXMALHAR-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228250#comment-15228250
]
ASF GitHub Bot commented on APEXMALHAR-1966:
Github user bhupeshchawda co
[
https://issues.apache.org/jira/browse/APEXMALHAR-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228235#comment-15228235
]
ASF GitHub Bot commented on APEXMALHAR-1966:
Github user bhupeshchawda co
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/227#discussion_r58703820
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/cassandra/CassandraPOJOOutputOperator.java
---
@@ -162,6 +163,30 @@ public void
[
https://issues.apache.org/jira/browse/APEXMALHAR-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228193#comment-15228193
]
ASF GitHub Bot commented on APEXMALHAR-2045:
GitHub user DT-Priyanka open
GitHub user DT-Priyanka opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/234
APEXMALHAR-2045: Adding bandwidth control feature to limit Input Operâ¦
â¦ator bandwidth limit
You can merge this pull request into a Git repository by running:
$ git pull
Github user DT-Priyanka commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/233#discussion_r58694240
--- Diff:
library/src/test/java/com/datatorrent/lib/io/fs/HDFSOutputOperatorTest.java ---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to t
Github user DT-Priyanka commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/233#discussion_r58693831
--- Diff:
library/src/main/java/com/datatorrent/lib/io/fs/HDFSOutputOperator.java ---
@@ -0,0 +1,393 @@
+/**
+ * Licensed to the A
Github user DT-Priyanka commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/233#discussion_r58693785
--- Diff:
library/src/main/java/com/datatorrent/lib/io/fs/HDFSOutputOperator.java ---
@@ -0,0 +1,393 @@
+/**
+ * Licensed to the A
Github user DT-Priyanka commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/233#discussion_r58693332
--- Diff:
library/src/main/java/com/datatorrent/lib/io/fs/HDFSOutputOperator.java ---
@@ -0,0 +1,393 @@
+/**
+ * Licensed to the A
Github user DT-Priyanka commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/233#discussion_r58693233
--- Diff:
library/src/main/java/com/datatorrent/lib/io/fs/HDFSOutputOperator.java ---
@@ -0,0 +1,393 @@
+/**
+ * Licensed to the A
Github user DT-Priyanka commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/233#discussion_r58693168
--- Diff:
library/src/main/java/com/datatorrent/lib/io/fs/HDFSOutputOperator.java ---
@@ -0,0 +1,393 @@
+/**
+ * Licensed to the A
[
https://issues.apache.org/jira/browse/APEXCORE-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228098#comment-15228098
]
pradeep kumbhar commented on APEXCORE-316:
--
Hey Tim,
I developed a simple app w
GitHub user yogidevendra opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/233
Added concrete implementation for HDFS output operator with unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yogi
84 matches
Mail list logo
