Re: Enhancements in JdbcPOJOInputOperator

2016-05-17 Thread Shubham Pathak
Hello, Thank you for the comments. Here is the pull request for the enhancement https://github.com/apache/incubator-apex-malhar/pull/269 With this change, the user will be able to provide POJO with Date, Time and DateTime fields. Long field for Date/Time/Timestamp will no longer be supported. As

Re: Enhancements in JdbcPOJOInputOperator

2016-05-09 Thread Bhupesh Chawda
+1 Having Date field will make it more intuitive. Additionally Date is timezone independent, so all timezone conversions have to be taken care of, by the user code. ~Bhupesh On Mon, May 9, 2016 at 6:33 AM, Sandeep Deshmukh wrote: > +1 on being consistent in the ecosystem. > On 09-May-2016 6:51

Re: Enhancements in JdbcPOJOInputOperator

2016-05-09 Thread Sandeep Deshmukh
+1 on being consistent in the ecosystem. On 09-May-2016 6:51 pm, "Shubham Pathak" wrote: > Yes, we can surely do the conversion. But we should also consider usability > and consistency across operators. > Operators such as JSON Parser, CSV Parser emit POJOs and have the ability > to define Date f

Re: Enhancements in JdbcPOJOInputOperator

2016-05-09 Thread Shubham Pathak
Yes, we can surely do the conversion. But we should also consider usability and consistency across operators. Operators such as JSON Parser, CSV Parser emit POJOs and have the ability to define Date fields in POJO. Having similar ability in JdbcPOJOInputOperator will make it consistent. It would al

Re: Enhancements in JdbcPOJOInputOperator

2016-05-04 Thread Priyanka Gugale
Java many times preserve date as long and then we can convert it the way we want when we need to interface with other systems (like UI, DB or etc). We can still do conversion from one date format to other, but I would prefer to keep it raw and convert in required format when need arise. -Priyanka

Re: Enhancements in JdbcPOJOInputOperator

2016-05-03 Thread Pradeep Kumbhar
+1 for the change. At some point in time, user'll need this to specify fields related to time more meaningfully. On Wed, May 4, 2016 at 10:17 AM, Sandeep Deshmukh wrote: > +1. > Good to have intuitive way of using fields. > > Regards, > Sandeep > > On Wed, May 4, 2016 at 9:39 AM, Shubham Pathak

Re: Enhancements in JdbcPOJOInputOperator

2016-05-03 Thread Sandeep Deshmukh
+1. Good to have intuitive way of using fields. Regards, Sandeep On Wed, May 4, 2016 at 9:39 AM, Shubham Pathak wrote: > Hello Community, > > JdbcPOJOInputOperator reads from a database using JDBC API and emits a POJO > for each record. > > In the current implementation, Date/Time/Timestamp fi

Enhancements in JdbcPOJOInputOperator

2016-05-03 Thread Shubham Pathak
Hello Community, JdbcPOJOInputOperator reads from a database using JDBC API and emits a POJO for each record. In the current implementation, Date/Time/Timestamp fields of the table are mapped to "long" field in POJO. While this works fine, it is not intuitive. I would like to enhance the operat