Re: Did anybody ever play with cmake+apr and/or have any advice applicable to cmake+apr?

2013-08-22 Thread Tom Donovan
On 08/20/2013 03:47 PM, Jeff Trawick wrote: I plan to spend some time tilting at that windmill starting later this week, for the purposes of getting a flexible build on Windows. Enough time to get something working? Dunno :( -- Born in Roswell... married an alien...

Re: Did anybody ever play with cmake+apr and/or have any advice applicable to cmake+apr?

2013-08-22 Thread Tom Donovan
On 08/22/2013 04:55 PM, Jeff Trawick wrote: On Thu, Aug 22, 2013 at 10:49 AM, Tom Donovan donov...@bellatlantic.net mailto:donov...@bellatlantic.net wrote: On 08/20/2013 03:47 PM, Jeff Trawick wrote: I plan to spend some time tilting at that windmill starting later this week

Re: svn commit: r1078507 - /apr/apr/trunk/dbd/apr_dbd_odbc.c

2011-03-10 Thread Tom Donovan
On 3/9/2011 1:54 PM, William A. Rowe Jr. wrote: On 3/9/2011 12:40 PM, Jeff Trawick wrote: The original code was a bit disturbing because of the indentation: /* mark all the columns as needing SQLGetData unless they are bound */ for (c = 0; c res-ncols; c++) { if

Re: svn commit: r1078507 - /apr/apr/trunk/dbd/apr_dbd_odbc.c

2011-03-10 Thread Tom Donovan
On 3/9/2011 1:54 PM, William A. Rowe Jr. wrote: On 3/9/2011 12:40 PM, Jeff Trawick wrote: The original code was a bit disturbing because of the indentation: My 2nd try is change 1080404. I guess I've become a bit rusty at this! -tom-

Re: apr_dbd_odbc patches

2010-07-25 Thread Tom Donovan
On 7/19/2010 12:14 PM, Kappa wrote: After doing some testing and then comparing the odbc driver to the other drivers (pgsql, oracle, etc). I noticed what appears to be a bug in the ODBC driver. For getting binary data (in odbc_datum_get), it is using the /void *data/ argument differently than

Re: sqllen error

2009-11-01 Thread Tom Donovan
Stephen Ince wrote: I am getting the following error when trying to build the apr-utl 1.3 on win32. I am missing odbc setting. C:\work\apr-util\dbd\apr_dbd_odbc.c(134) : error C2061: syntax error : identifier 'SQLLEN' If you are building APR with Visual C++, please make sure that you have

Re: svn commit: r679630 - in /apr/apr/trunk: CHANGES file_io/unix/copy.c file_io/win32/open.c include/apr_file_io.h test/testfilecopy.c

2008-07-24 Thread Tom Donovan
Bojan Smojver wrote: On Fri, 2008-07-25 at 00:17 +, [EMAIL PROTECTED] wrote: Add apr_file_link() function. PR 44841. Patch by Mark Heily mark heily.com Folks, this addition includes Windows code, which I am unable to review at all (Unix code is very simple, though). So, I'm relying on

Re: [Fwd: connobject.c broke with apr 1.3.2]

2008-06-30 Thread Tom Donovan
William A. Rowe, Jr. wrote: Guys, please take a look, looks like one of the 1.3.x generation patches has broken our API compatibility rules. It looks like this has always been wrong in mod_python. APR_BRIGADE_SENTINEL takes a brigade argument, not a bucket. refs:

Re: Warnings for apr_dbd_odbc.c on 64-bit platforms

2008-06-17 Thread Tom Donovan
Bojan Smojver wrote: I'm getting these on Fedora 9, x86_64: --- dbd/apr_dbd_odbc.c: In function ‘odbc_open’: dbd/apr_dbd_odbc.c:1010: warning: cast to pointer from integer of different size dbd/apr_dbd_odbc.c: In function ‘odbc_start_transaction’:

Re: Warnings for apr_dbd_odbc.c on 64-bit platforms

2008-06-17 Thread Tom Donovan
Tom Donovan wrote: Bojan Smojver wrote: I'm getting these on Fedora 9, x86_64: --- dbd/apr_dbd_odbc.c: In function ‘odbc_open’: dbd/apr_dbd_odbc.c:1010: warning: cast to pointer from integer of different size dbd/apr_dbd_odbc.c: In function ‘odbc_start_transactionâ

Re: svn commit: r667153 - /apr/apr/branches/1.3.x/include/apr.hw

2008-06-15 Thread Tom Donovan
[EMAIL PROTECTED] wrote: This should not be necessary, but SDK 6.1 headers were broken (post Visual Studio 2005) +++ apr/apr/branches/1.3.x/include/apr.hw Thu Jun 12 09:32:51 2008 +/* Restrict the server to a subset of Windows XP header files by default */ -#define _WIN32_WINNT 0x0500

Re: svn commit: r667153 - /apr/apr/branches/1.3.x/include/apr.hw

2008-06-15 Thread Tom Donovan
William A. Rowe, Jr. wrote: Tom Donovan wrote: I don't find this necessary with SDK6.1 on WinXP using the command-line VC9 compiler included with the SDK. Is it to pick up XP/2003 TCP/IP multicast constants per the CHANGES file? The concern is that it opens up the possibility

Re: [EMAIL PROTECTED] 2.2.9 missing options, no sql

2008-06-14 Thread Tom Donovan
William A. Rowe, Jr. wrote: Looking over the patches, none seem to correspond to this gentleman's post from over on [EMAIL PROTECTED] Could anyone particularly familiar with mysql take a quick look and perhaps come up with a few ideas? Seems that this user has a perfectly working non-dso

Re: svn commit: r667182 - in /apr/apr-util/trunk: Makefile.win aprutil.dsw dbd/apr_dbd.c dbd/apr_dbd_odbc.c dbd/apr_dbd_odbc.dsp include/apu.hw include/private/apr_dbd_odbc_v2.h

2008-06-12 Thread Tom Donovan
Bojan Smojver wrote: On Thu, 2008-06-12 at 17:54 +, [EMAIL PROTECTED] wrote: +SQL_C_CHAR, /*SQL_C_TYPE_TIME, /* APR_DBD_TYPE_TIME, \%pDi */ +SQL_C_CHAR, /*SQL_C_TYPE_DATE, /* APR_DBD_TYPE_DATE, \%pDd */ +SQL_C_CHAR, /*SQL_C_TYPE_TIMESTAMP, /*

Re: svn commit: r667300 - /apr/apr-util/trunk/build/dbd.m4

2008-06-12 Thread Tom Donovan
Bojan Smojver wrote: On Fri, 2008-06-13 at 10:26 +1000, Bojan Smojver wrote: It would be good if Windows folks could check this change that I made: -- #ifdef HAVE_SQL_H All set on Windows now - r667309

Re: svn commit: r667300 - /apr/apr-util/trunk/build/dbd.m4

2008-06-12 Thread Tom Donovan
Bojan Smojver wrote: On Thu, 2008-06-12 at 19:17 -0500, William A. Rowe, Jr. wrote: This is looking great, do we feel it's ready for people to try out with apr 1.3.1? Tom, Do you have an opinion on this? PS. I would personally prefer to see ODBC DBC in 1.3.1. It's seen considerable use

Re: svn commit: r667328 - in /apr/apr-util/trunk: dbd/apr_dbd.c dbd/apr_dbd_freetds.c dbd/apr_dbd_odbc.c include/apu.h.in

2008-06-12 Thread Tom Donovan
Bojan Smojver wrote: On Fri, 2008-06-13 at 04:10 +, [EMAIL PROTECTED] wrote: @@ -646,7 +649,7 @@ if (SQL_SUCCEEDED(rc) || rc == SQL_NO_DATA) { -if (rc = SQL_SUCCESS_WITH_INFO +if (rc == SQL_SUCCESS_WITH_INFO ( len_indicator == SQL_NO_TOTAL ||

Re: svn commit: r667328 - in /apr/apr-util/trunk: dbd/apr_dbd.c dbd/apr_dbd_freetds.c dbd/apr_dbd_odbc.c include/apu.h.in

2008-06-12 Thread Tom Donovan
Bojan Smojver wrote: On Fri, 2008-06-13 at 00:32 -0400, Tom Donovan wrote: The second one doesn't change the behavior, just cleaning up -Wall warnings, right? That's right. Thanks for reviewing. If nobody objects, I'm going to backport ODBC driver to 1.3.x then. Builds runs OK now

Re: Summary of win32 build issues

2008-06-10 Thread Tom Donovan
If there's interest, I have an ODBC DBD driver I would be glad to contribute. It's currently hosted at http://odbc-dbd.googlecode.com/ The license is already Apache2, so transferring ownership shouldn't pose any problems. For Windows, it could be included by default because odbc32.dll is

Re: ODBC driver (Re: Summary of win32 build issues)

2008-06-10 Thread Tom Donovan
Nick Kew wrote: On Tue, 10 Jun 2008, Tom Donovan wrote: If there's interest, I have an ODBC DBD driver I would be glad to contribute. That'll be great. I look forward to it! Given the limitations of the FreeTDS driver, I think there's a strong case to recommend the ODBC driver over

Re: Compiling on windows

2008-06-10 Thread Tom Donovan
William A. Rowe, Jr. wrote: Matt Tolton wrote: Hi, I'm attempting to compile APR on windows xp. I am receiving the following errors: io\unix\multicast.c multicast.c .\network_io\unix\multicast.c(183) : error C2065: 'IPPROTO_IPV6' : undeclared identifier What version? Would appreciate

Re: sqlite3 dbd provider question

2008-05-19 Thread Tom Donovan
William A. Rowe, Jr. wrote: William A. Rowe, Jr. wrote: I'm reviewing the providers themselves and trying to determine how and when the dbd lock api should be used vs. a dso-module apr-util wide mutex should be used instead.l The oracle provider alone is using this lock to prepare

Re: sqlite3 dbd provider question

2008-05-19 Thread Tom Donovan
William A. Rowe, Jr. wrote: Tom Donovan wrote: And a related question, any prepared statement can be portably used across any of the databases open within the specific provider. Correct? In general no. Most databases consider a prepared statement to be associated with a single database

Re: sqlite3 and postgresql

2008-05-17 Thread Tom Donovan
Bob Rossi wrote: Hi, I've been using sqlite3 dbd for some time now. I find that the function apr_dbd_get_row, http://apr.apache.org/docs/apr-util/trunk/group___a_p_r___util___d_b_d.html#gd4cdc5f4e8981b93f5a467a8c8a768f1 is 1 based. That is, 1 is the first row returned from a query. However,

Re: sqlite3 and postgresql

2008-05-17 Thread Tom Donovan
Bojan Smojver wrote: On Sat, 2008-05-17 at 18:29 -0500, William A. Rowe, Jr. wrote: +1 and I concur with Tom's suggestion w.r.t. a preferred row offset 1. Tom, do you want to fix this one or do you want me to do it? I would be happy to take care of it as soon as I receive commit access.

Re: sqlite3 and postgresql

2008-05-17 Thread Tom Donovan
Bob Rossi wrote: On Sun, May 18, 2008 at 10:17:34AM +1000, Bojan Smojver wrote: On Sat, 2008-05-17 at 18:29 -0500, William A. Rowe, Jr. wrote: +1 and I concur with Tom's suggestion w.r.t. a preferred row offset 1. Tom, do you want to fix this one or do you want me to do it? Aren't you

Re: DBD driver license issues (must default to --without-driver)

2008-05-11 Thread Tom Donovan
Roy T. Fielding wrote: This is a showstopper. It must be fixed in 1.3.x before release. My fix is also incomplete: All of the other DBD drivers that do not have redistributable client libraries must also default off. Oracle is one for sure -- I am unaware of the terms for the other drivers.

Re: DBD driver license issues (must default to --without-driver)

2008-05-11 Thread Tom Donovan
Roy T. Fielding wrote: This is a showstopper. It must be fixed in 1.3.x before release. My fix is also incomplete: All of the other DBD drivers that do not have redistributable client libraries must also default off. Oracle is one for sure -- I am unaware of the terms for the other drivers.

Re: DBD driver license issues (must default to --without-driver)

2008-05-11 Thread Tom Donovan
Bojan Smojver wrote: On Sun, 2008-05-11 at 20:35 -0400, Tom Donovan wrote: Maybe that should be the default, combined with disabling of MySQL/Oracle drivers by default due to possible downstream licensing issues? I agree that --enable-dbd-dso should be the default (presuming the platform

Re: Possible bug in apr_dbd_mysql

2008-02-02 Thread Tom Donovan
Scott Sanders wrote: Scott Sanders wrote: the pwd2 field was empty then any password would succeed. If pwd2 was NULL then the user was rejected, and if pwd2 had a string in it the user was rejected (excepting, of course, when pwd2 had the proper encrypted

Re: Possible bug in apr_dbd_mysql

2008-01-31 Thread Tom Donovan
Scott Sanders wrote: Hi, After much frustration I was able to get apr_dbd_mysql compiled and working on my machine. However, when testing the module I believe I ... but in my environment that's OK. My initial apache config to secure this section of the site with basic auth set the

Some dbd driver questions

2007-03-24 Thread Tom Donovan
I've been working on an ODBC dbd driver, and I have a few questions about how LOBs are supposed to be returned as bucket brigades. Looking at the Oracle driver, it appears that the caller creates the brigade which is passed as an argument to apr_dbd_datum_get. If the LOB contains no data,

Re: Some dbd driver questions

2007-03-24 Thread Tom Donovan
Bojan Smojver wrote: On Sat, 2007-03-24 at 11:31 -0400, Tom Donovan wrote: I've been working on an ODBC dbd driver, and I have a few questions ... Finally, Most of the non-binary functions have new binary equivalents: There is a _pbselect and a _pvbselect - but not a simple _bselect

Re: function apr_strtok does not work..

2007-03-21 Thread Tom Donovan
xu li wrote: i want to use apr_strtok to split the string.but it failed. my_test.c: #include stdio.h #include apr_strings.h int main(void) { char *strToSplit = Hello world; char *last; char *strResult; strResult = apr_strtok(strToSplit, ,last);

Re: [PATCH] DBD drivers as DSOs

2007-03-12 Thread Tom Donovan
I appreciate that this idea didn't just die as not supported. Thanks! Another way to accomplish runtime registration of db drivers would be a public apr_dbd_set_driver() function. Using this function the app - or even the driver itself - could register at runtime. FYI, I entered enhancement

Re: [PATCH] DBD drivers as DSOs

2007-03-01 Thread Tom Donovan
to) by APR rather than expect the database community (vs. the APR community) to independently develop and distribute DBD drivers for SQLServer, ODBC, OLE, Sybase, Informix, DB2, Teradata, Mckoi, Ingres, etc? -tom- Joe Orton wrote: On Tue, Feb 27, 2007 at 09:12:16PM -0500, Tom Donovan wrote: I'm

Re: [PATCH] DBD drivers as DSOs

2007-02-28 Thread Tom Donovan
) libz.so.1 = /usr/lib/libz.so.1 (0xb7c41000) /lib/ld-linux.so.2 (0x8000) -tom- Bojan Smojver wrote: On Wed, 2007-02-28 at 22:16 -0500, Tom Donovan wrote: This worked for me on both Windows and Linux. One question here - what does the output of ldd .libs/libaprutil-1.so look

Re: [PATCH] DBD drivers as DSOs

2007-02-28 Thread Tom Donovan
: On Wed, 2007-02-28 at 23:29 -0500, Tom Donovan wrote: In this test, pgsql was the static driver, mysql was dynamic. Pretty cool :-) Thanks,