Re: [PATCH] apr_make_os_sock()

2000-12-04 Thread rbb
> > Won't it need to be different on different platforms? I mean, Windows > > wants a SOCKET, and I wouldn't put it past M$ to change the sockaddr to > > some windows specific structure in the future. > > The prototype will be the same... that is why we have the apr_os_sock_t > type. > > We sho

Re: [PATCH] apr_make_os_sock()

2000-12-04 Thread Greg Stein
On Sun, Dec 03, 2000 at 09:27:45AM -0500, Jeff Trawick wrote: > Hopefully I didn't miss any comments on the mailing list last night > (where is that archive again?). > > Here is enough to look at to make sure I didn't screw anything up. I > added family and type parameters too so that APR doesn't

Re: [PATCH] apr_make_os_sock()

2000-12-04 Thread Greg Stein
On Sun, Dec 03, 2000 at 11:38:32AM -0800, [EMAIL PROTECTED] wrote: > > > > > Here is enough to look at to make sure I didn't screw anything up. I > > > > added family and type parameters too so that APR doesn't have to bend > > > > over backwards (i.e., use syscalls) to find that out. We don't k

Re: [PATCH] apr_make_os_sock()

2000-12-03 Thread rbb
> > > Here is enough to look at to make sure I didn't screw anything up. I > > > added family and type parameters too so that APR doesn't have to bend > > > over backwards (i.e., use syscalls) to find that out. We don't keep > > > the type anywhere yet but it is likely to become useful in the fu

Re: [PATCH] apr_make_os_sock()

2000-12-03 Thread Jeff Trawick
[EMAIL PROTECTED] writes: > On Sun, 3 Dec 2000, Jeff Trawick wrote: > > > Hopefully I didn't miss any comments on the mailing list last night > > (where is that archive again?). > > > > Here is enough to look at to make sure I didn't screw anything up. I > > added family and type parameters too

Re: [PATCH] apr_make_os_sock()

2000-12-03 Thread rbb
On Sun, 3 Dec 2000, Jeff Trawick wrote: > Hopefully I didn't miss any comments on the mailing list last night > (where is that archive again?). > > Here is enough to look at to make sure I didn't screw anything up. I > added family and type parameters too so that APR doesn't have to bend > over

Re: [PATCH] apr_make_os_sock()

2000-12-03 Thread Jeff Trawick
Jeff Trawick <[EMAIL PROTECTED]> writes: > +apr_status_t apr_make_os_sock(apr_socket_t **apr_sock, apr_os_sock_t > *os_sock, > + struct sockaddr *local, struct sockaddr > *remote, > + int family, int type, apr_pool_t *cont) > +{ ... > +

[PATCH] apr_make_os_sock()

2000-12-03 Thread Jeff Trawick
Hopefully I didn't miss any comments on the mailing list last night (where is that archive again?). Here is enough to look at to make sure I didn't screw anything up. I added family and type parameters too so that APR doesn't have to bend over backwards (i.e., use syscalls) to find that out. We