Altogether Broken OtherChild logic

2003-01-28 Thread William A. Rowe, Jr.
I belive I've deciphered the "RotateLogs doesn't work for access logs on Windows" Apache 2.0.44 bug. It's actually many bugs in conformance. First, rbb's reorg of the WinNT pipe logic (apr/file_io/win32/pipe.c rev 1.46) causes server/log.c ap_open_piped_log() to create an async (nonblocking) pi

Re: Altogether Broken OtherChild logic

2003-01-28 Thread William A. Rowe, Jr.
A perfect example; how does one go from this; /** * Check on the specified process. If it is gone, call the maintenance * function. * @param pid The process to check. * @param status The status to pass to the maintenance function. */ APR_DECLARE(apr_status_t) apr_proc_other_child_read(apr_p

Re: Altogether Broken OtherChild logic

2003-01-28 Thread William A. Rowe, Jr.
Another quick example; APR_OC_REASON_UNWRITABLE is entirely unimplemented according to my quick grep of the entire code base. Bill

Re: Altogether Broken OtherChild logic

2003-01-30 Thread Bill Stoddard
William A. Rowe, Jr. wrote: I belive I've deciphered the "RotateLogs doesn't work for access logs on Windows" Apache 2.0.44 bug. It's actually many bugs in conformance. First, rbb's reorg of the WinNT pipe logic (apr/file_io/win32/pipe.c rev 1.46) causes server/log.c ap_open_piped_log() to create

Re: Altogether Broken OtherChild logic

2003-01-30 Thread Bill Stoddard
William A. Rowe, Jr. wrote: I belive I've deciphered the "RotateLogs doesn't work for access logs on Windows" Apache 2.0.44 bug. It's actually many bugs in conformance. First, rbb's reorg of the WinNT pipe logic (apr/file_io/win32/pipe.c rev 1.46) causes server/log.c ap_open_piped_log() to create

Re: Altogether Broken OtherChild logic

2003-01-30 Thread Jeff Trawick
wrowe wrote: > Finally, it looks like apr_proc_other_child_read is the function we > *really* wanted > to use within the health check. But it seems all of these > apr_proc_other_child > functions are really misdocumented within APR. Would someone step up and > spell out exactly what they are *su

Re: Altogether Broken OtherChild logic

2003-01-30 Thread William A. Rowe, Jr.
At 02:03 PM 1/30/2003, Jeff Trawick wrote: >wrowe wrote: > >>> Finally, it looks like apr_proc_other_child_read is the function we >>> *really* wanted >>> to use within the health check. But it seems all of these >>> apr_proc_other_child >>> functions are really misdocumented within APR. Would so

Re: Altogether Broken OtherChild logic

2003-01-30 Thread Bill Stoddard
William A. Rowe, Jr. wrote: At 02:03 PM 1/30/2003, Jeff Trawick wrote: wrowe wrote: Finally, it looks like apr_proc_other_child_read is the function we *really* wanted to use within the health check. But it seems all of these apr_proc_other_child functions are really misdocumented within A

Re: Altogether Broken OtherChild logic

2003-01-30 Thread William A. Rowe, Jr.
At 01:30 PM 1/30/2003, Bill Stoddard wrote: >William A. Rowe, Jr. wrote: > >>I belive I've deciphered the "RotateLogs doesn't work for access logs >>on Windows" Apache 2.0.44 bug. It's actually many bugs in conformance. >> >>Finally, it looks like apr_proc_other_child_read is the function we *real

Re: Altogether Broken OtherChild logic

2003-01-30 Thread William A. Rowe, Jr.
At 12:37 PM 1/30/2003, Bill Stoddard wrote: >This stuff kinda worked on Windows in the past. I need to dig some but I seem >to recall that it was basically impossible to do the exact same thing in >Windows as you do in Unix. The other_child_read in Unix will not (and cannot) >work the same way

Re: Altogether Broken OtherChild logic

2003-01-30 Thread Bill Stoddard
I am guessing that the windows MPM is whacking the piped logger because ocr->proc->hproc is somehow hosed. No, that is working fine. It is whacking it because I modified the code in _check() to do exactly the same thing on Win32 as it does on Unix. Humm... perhaps you got the cart b

Re: Altogether Broken OtherChild logic

2003-01-30 Thread William A. Rowe, Jr.
At 04:47 PM 1/30/2003, Bill Stoddard wrote: >>No, that is working fine. It is whacking it because I modified the code in >>_check() to do exactly the same thing on Win32 as it does on Unix. >Humm... perhaps you got the cart before the horse... if i recall correctly, I >think I created the _c

Re: Altogether Broken OtherChild logic

2003-01-31 Thread Bill Stoddard
So I 've actually spent some time looking at this... apr_proc_other_child_check() on Unix came first, afaict. Right you are. Now we're left with ery simple problem. OC works on Unix today, and it's broken on Win32. Unix's logic is well exercised by a larger group, WinNT's by a much smaller minor

Re: Altogether Broken OtherChild logic

2003-01-31 Thread Jeff Trawick
William A. Rowe, Jr. wrote: I'm simply thinking of renaming it apr_proc_other_child_died() and documenting it correctly. Step two is determining how I can then identify and report that case in the WinNT MPM, or automagically as a callback. How about rename it to apr_proc_other_child_some_random

Re: Altogether Broken OtherChild logic

2003-02-05 Thread William A. Rowe, Jr.
At 09:11 AM 1/31/2003, Bill Stoddard wrote: >>As for your question about polling, if we cycle every second we waste >>cpu - if we sample every few seconds we lose more log entries etc. >>If we receive alerts when the otherchild processes die we can react >>immediately without the extra loops. >In