Re: svn commit: r1086790 - /apr/apr/trunk/xml/apr_xml_internal.h

2011-04-11 Thread Nick Kew
On Mon, 11 Apr 2011 15:14:00 -0400 Jeff Trawick wrote: > >> niq, is that to be exported eventually? No (since I still seem to owe you an answer - sorry). > how about changing the _ex to _internal? +1. I thought so more-or-less as soon as I'd committed. Didn't make the trivial change in case

Re: svn commit: r1086790 - /apr/apr/trunk/xml/apr_xml_internal.h

2011-04-11 Thread Guenter Knauf
Am 11.04.2011 21:14, schrieb Jeff Trawick: how about changing the _ex to _internal? sure, sounds better ... Gün.

Re: svn commit: r1086790 - /apr/apr/trunk/xml/apr_xml_internal.h

2011-04-11 Thread Jeff Trawick
On Mon, Apr 11, 2011 at 3:11 PM, Guenter Knauf wrote: > Jeff, Niq, > Am 30.03.2011 01:26, schrieb Jeff Trawick: >> >> On Tue, Mar 29, 2011 at 7:09 PM, Guenter Knauf  wrote: >>> >>> Am 30.03.2011 00:52, schrieb Guenter Knauf: are you really sure this is the right thing? /me doubt ...

Re: svn commit: r1086790 - /apr/apr/trunk/xml/apr_xml_internal.h

2011-04-11 Thread Guenter Knauf
Jeff, Niq, Am 30.03.2011 01:26, schrieb Jeff Trawick: On Tue, Mar 29, 2011 at 7:09 PM, Guenter Knauf wrote: Am 30.03.2011 00:52, schrieb Guenter Knauf: are you really sure this is the right thing? /me doubt ... 1. its in an internal header - if we want to expoert that function then it should

Re: svn commit: r1086790 - /apr/apr/trunk/xml/apr_xml_internal.h

2011-03-29 Thread Jeff Trawick
On Tue, Mar 29, 2011 at 7:09 PM, Guenter Knauf wrote: > Am 30.03.2011 00:52, schrieb Guenter Knauf: >> >> are you really sure this is the right thing? /me doubt ... >> 1. its in an internal header - if we want to expoert that function then >> it should be moved to a public header >> 2. if you look

Re: svn commit: r1086790 - /apr/apr/trunk/xml/apr_xml_internal.h

2011-03-29 Thread Guenter Knauf
Am 30.03.2011 00:52, schrieb Guenter Knauf: are you really sure this is the right thing? /me doubt ... 1. its in an internal header - if we want to expoert that function then it should be moved to a public header 2. if you look into apr_xml.c you can find: APR_DECLARE(apr_xml_parser *) apr_xml_pa

Re: svn commit: r1086790 - /apr/apr/trunk/xml/apr_xml_internal.h

2011-03-29 Thread Guenter Knauf
Hi Jeff, Am 30.03.2011 00:29, schrieb traw...@apache.org: Author: trawick Date: Tue Mar 29 22:29:05 2011 New Revision: 1086790 URL: http://svn.apache.org/viewvc?rev=1086790&view=rev Log: fix linkage of apr_parser_create_ex() on Windows Submitted by: Carlo Bramini PR: tiny part of 4617