Re: cvs commit: apr/locks/unix locks.c

2000-12-01 Thread rbb
> Modified:.configure.in hints.m4 CHANGES >include apr.h.in apr.hw >locks/unix locks.c > Log: > New config variable apr_process_lock_is_global specifies that the selected > inter-process lock method is sufficient for APR_LOCKALL (i.e., it blocks

Re: cvs commit: apr/locks/unix locks.c

2000-12-01 Thread Jeff Trawick
[EMAIL PROTECTED] writes: > > Modified:.configure.in hints.m4 CHANGES > >include apr.h.in apr.hw > >locks/unix locks.c > > Log: > > New config variable apr_process_lock_is_global specifies that the selected > > inter-process lock method is suffi

Re: cvs commit: apr/locks/unix locks.c

2000-12-01 Thread rbb
> Why don't we add something like apr_get_config_string() which returns > a string like the "httpd -V" output (but of course only builds the APR > part)? How many +1s can I give this? this would be incredibly useful. > include/apr_general.h: > > apr_status_t apr_get_config_string(char **cfg,

Re: cvs commit: apr/locks/unix locks.c

2000-12-01 Thread Greg Stein
On Fri, Dec 01, 2000 at 08:44:14AM -0800, [EMAIL PROTECTED] wrote: > > > Why don't we add something like apr_get_config_string() which returns > > a string like the "httpd -V" output (but of course only builds the APR > > part)? > > How many +1s can I give this? this would be incredibly useful.

Re: cvs commit: apr/locks/unix locks.c

2000-12-01 Thread rbb
> > This should work the same way apr_initialize works, so that it calls into > > the APR sub-libraries with a function like "apr_report_lock" or > > "apr_report_threads". This would make it very extensible, and as we build > > APR with or without different components, we would just pick up the r

Re: cvs commit: apr/locks/unix locks.c

2000-12-01 Thread Jeff Trawick
Greg Stein <[EMAIL PROTECTED]> writes: > On Fri, Dec 01, 2000 at 08:44:14AM -0800, [EMAIL PROTECTED] wrote: > > > > This should work the same way apr_initialize works, so that it calls into > > the APR sub-libraries with a function like "apr_report_lock" or > > "apr_report_threads". This would m

Re: cvs commit: apr/locks/unix locks.c

2000-12-01 Thread rbb
> > I think that is overkill for now. All of these flags are available in > > apr_private.h. If it starts to get unwieldy or something, then we can split. > > But let's start simple, make it harder when that is needed. > > That is for damn sure :)^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^

Re: cvs commit: apr/locks/unix locks.c

2000-12-02 Thread Greg Stein
On Fri, Dec 01, 2000 at 02:29:43PM -0800, [EMAIL PROTECTED] wrote: > > > > I think that is overkill for now. All of these flags are available in > > > apr_private.h. If it starts to get unwieldy or something, then we can > > > split. > > > But let's start simple, make it harder when that is neede

Re: cvs commit: apr/locks/unix locks.c

2000-12-02 Thread rbb
> > Then please just leave it, and I'll implement the whole thing myself. The > > other option is for you to implement it, and I'll go in immediately and > > change it. > > Why is it that two people ask for the simple one, don't want to do the > harder one (and don't want to see that complexity

Re: cvs commit: apr/locks/unix locks.c

2001-06-05 Thread Ben Laurie
Isn't this another example where we should just die instead of returning an error? Cheers, Ben. [EMAIL PROTECTED] wrote: > > dreid 01/06/05 06:48:28 > > Modified:locks/unix locks.c > Log: > One slipped through the rename, but got it now! > > Revision ChangesPath > 1.5

Re: cvs commit: apr/locks/unix locks.c

2001-06-05 Thread Cliff Woolley
On Tue, 5 Jun 2001, Ben Laurie wrote: > >apr_status_t apr_os_lock_put(apr_lock_t **lock, apr_os_lock_t *thelock, > > apr_pool_t *pool) > >{ > > -if (cont == NULL) { > > +if (pool == NULL) { > >return APR_ENOPOOL; > >} > >

Re: cvs commit: apr/locks/unix locks.c

2001-06-05 Thread David Reid
Could be! david - Original Message - From: "Ben Laurie" <[EMAIL PROTECTED]> To: Cc: <[EMAIL PROTECTED]> Sent: Tuesday, June 05, 2001 7:23 PM Subject: Re: cvs commit: apr/locks/unix locks.c > Isn't this another example where we should just die i