Re: cvs commit: apr/strings apr_cpystrn.c

2002-05-21 Thread William A. Rowe, Jr.
At 05:57 PM 5/20/2002, Greg Stein wrote: On Fri, May 17, 2002 at 02:38:27PM -0500, William A. Rowe, Jr. wrote: >... > > > > trawick 02/05/17 07:58:27 > > > > > > > > Modified:strings apr_cpystrn.c > > > > Log: > > > > don't check for malloc() failure in our strdup() replacement >...

Re: cvs commit: apr/strings apr_cpystrn.c

2002-05-20 Thread Greg Stein
On Fri, May 17, 2002 at 02:38:27PM -0500, William A. Rowe, Jr. wrote: >... > > > > trawick 02/05/17 07:58:27 > > > > > > > > Modified:strings apr_cpystrn.c > > > > Log: > > > > don't check for malloc() failure in our strdup() replacement >... > We have an callback for pool functions,

Re: cvs commit: apr/strings apr_cpystrn.c

2002-05-17 Thread William A. Rowe, Jr.
At 10:27 AM 5/17/2002, you wrote: Ben Laurie <[EMAIL PROTECTED]> writes: > [EMAIL PROTECTED] wrote: > > > > trawick 02/05/17 07:58:27 > > > > Modified:strings apr_cpystrn.c > > Log: > > don't check for malloc() failure in our strdup() replacement > > E - why not? we're going to g

Re: cvs commit: apr/strings apr_cpystrn.c

2002-05-17 Thread Jeff Trawick
Ben Laurie <[EMAIL PROTECTED]> writes: > [EMAIL PROTECTED] wrote: > > > > trawick 02/05/17 07:58:27 > > > > Modified:strings apr_cpystrn.c > > Log: > > don't check for malloc() failure in our strdup() replacement > > E - why not? we're going to get segfaults inside strdup()

Re: cvs commit: apr/strings apr_cpystrn.c

2002-05-17 Thread Ben Laurie
[EMAIL PROTECTED] wrote: > > trawick 02/05/17 07:58:27 > > Modified:strings apr_cpystrn.c > Log: > don't check for malloc() failure in our strdup() replacement E - why not? Cheers, Ben. -- http://www.apache-ssl.org/ben.html http://www.thebunker.net/ "There is no limi

Re: cvs commit: apr/strings apr_cpystrn.c

2002-05-17 Thread Aaron Bannert
>size_t len = strlen(str) + 1; > >if (!(sdup = (char *) malloc(len))) { > -/* ### whoops! we can't call Apache logging routines here... */ > -#if 0 > -apr_log_error(APLOG_MARK, APLOG_STARTUP | APLOG_NOERRNO, 0, NULL, > - "Ouch! Out of