Re: [C++] Implement function for time zone conversion

2022-02-07 Thread David Li
Ah - the Result is for error handling. So either: 1) Return arrow::Status from this function, and use the ARROW_ASSIGN_OR_RAISE macro: ARROW_ASSIGN_OR_RAISE(auto scalar, arrow::MakeScalar(...)); ..., cp::literal(std::move(scalar)) ... 2) For experimentation purposes, just assume it'll succeed:

Re: [DISCUSS] New Types (Schema.fbs vs Extension Types)

2022-02-07 Thread Rok Mihevc
To follow up the discussion from the bi-weekly Arrow sync: - JSON seems the most suitable candidate for the extension metadata. E.g.: TensorArray {"key": "ARROW:extension:name", "value": "tensor"}, {"key": "ARROW:extension:metadata", "value": "{'type': 'int64', 'shape': [3, 3, 4], 'strides': [12,

Re: [VOTE][RUST] Release Apache Arrow Rust 9.0.1 RC1

2022-02-07 Thread Jörn Horstmann
+1 (non-binding) Updated to the release candidate and ran the test suite of our query engine. Thanks a lot Andrew for the quick reaction. On Mon, Feb 7, 2022 at 6:51 PM Andrew Lamb wrote: > I would like to propose a release of Apache Arrow Rust Implementation, > version 9.0.1. > > This release

[VOTE][RUST] Release Apache Arrow Rust 9.0.1 RC1

2022-02-07 Thread Andrew Lamb
I would like to propose a release of Apache Arrow Rust Implementation, version 9.0.1. This release candidate is based on commit: e5003bf40bceb942c1c78cc2311e7d7a7e87ebf6 [1] The proposed release tarball and signatures are hosted at [2]. The changelog is located at [3]. Please download, verify

Re: [C++] Implement function for time zone conversion

2022-02-07 Thread Li Jin
So I think I am getting close... now I have cp::Expression predicate = cp::call( "equal", {...} cp::literal(arrow::MakeScalar(arrow::time64(arrow::TimeUnit::NANO), time))} );

Re: [C++] Implement function for time zone conversion

2022-02-07 Thread Li Jin
Another question - what is the correct way of creating a constant Scalar that represents a time64 from a string in C++ (e.g. "10:00:00") ? I am trying to use cp::literal(arrow::MakeScalar(...)) but not sure what to fill in the body of MakeScalar On Mon, Feb 7, 2022 at 12:05 PM Li Jin wrote: >

Re: [C++] Implement function for time zone conversion

2022-02-07 Thread Li Jin
Hello, Did some more work on this. Follow up question on this: I am doing a {cp::call("cast", {cp::field_ref("time_ns")}, cp::CastOptions::Safe(arrow::timestamp(arrow::TimeUnit::NANO, timezone)))}, And got: NotImplemented: Unsupported cast

Re: [VOTE][RUST] Release Apache Arrow Rust 9.0.0 RC1

2022-02-07 Thread Andrew Lamb
Testing has found a critical issue[1] in RC1. I'll be creating an RC 2 shortly with the fix. Sorry about that, Andrew [1] https://github.com/apache/arrow-rs/issues/1285 On Fri, Feb 4, 2022 at 5:33 PM Andy Grove wrote: > +1 (binding) > > Verified on Ubuntu 20.04.3 LTS > > On Fri, Feb 4, 2022