Re: [ANNOUNCE] New Arrow committer: Kevin Gurney

2023-07-04 Thread Alenka Frim
Congratulations! On Tue, Jul 4, 2023 at 9:41 PM Dewey Dunnington wrote: > Congrats! > > On Tue, Jul 4, 2023 at 2:08 PM Matt Topol wrote: > > > > Welcome! > > > > On Tue, Jul 4, 2023, 11:06 AM Joris Van den Bossche < > > jorisvandenboss...@gmail.com> wrote: > > > > > Congrats Kevin! > > > > > >

Re: Do we need CODEOWNERS ?

2023-07-04 Thread Alenka Frim
I agree with what was said till now. I did agree to be added as a codeowner for the Python directory which didn't turn out to be the best idea. As Joris mentioned, the number of notifications is not small. There are lots of PRs that are not Python related, but maybe just have a test added in

Arrow community meeting July 5 at 16:00 UTC

2023-07-04 Thread Ian Cook
Our next biweekly Arrow community meeting is tomorrow at 16:00 UTC / 12:00 EDT. Zoom meeting URL: https://zoom.us/j/87649033008?pwd=SitsRHluQStlREM0TjJVYkRibVZsUT09 Meeting ID: 876 4903 3008 Passcode: 958092 Meeting notes will be captured in this Google Doc:

Re: Do we need CODEOWNERS ?

2023-07-04 Thread Will Jones
I haven't had as much time to review the Parquet PRs, so I'll remove myself from the CODEOWNERS for that. I've found that I have a much easier time keeping up with PR reviews in projects that are smaller, even if there are proportionally fewer maintainers. I think that's the piece that appealed

Re: [ANNOUNCE] New Arrow committer: Kevin Gurney

2023-07-04 Thread Dewey Dunnington
Congrats! On Tue, Jul 4, 2023 at 2:08 PM Matt Topol wrote: > > Welcome! > > On Tue, Jul 4, 2023, 11:06 AM Joris Van den Bossche < > jorisvandenboss...@gmail.com> wrote: > > > Congrats Kevin! > > > > On Tue, 4 Jul 2023 at 13:47, David Li wrote: > > > > > > Welcome Kevin! > > > > > > On Tue, Jul

Re: Do we need CODEOWNERS ?

2023-07-04 Thread Joris Van den Bossche
I think it can be useful in certain cases, where the selection is specific enough (for example if all Go related PRs is not too much for Matt, this features sounds useful for him. I can also imagine if you are working on flight, just getting notifications for changes to the flight-related files

Re: Do we need CODEOWNERS ?

2023-07-04 Thread Matt Topol
I've found it useful for me so far since it auto adds me on any Go related PRs so I don't need to sift through the notifications or active PRs, and instead can easily find them in my reviews on GitHub notifications. But if everyone else finds it more detrimental than helpful I can set up a custom

Re: [ANNOUNCE] New Arrow committer: Kevin Gurney

2023-07-04 Thread Matt Topol
Welcome! On Tue, Jul 4, 2023, 11:06 AM Joris Van den Bossche < jorisvandenboss...@gmail.com> wrote: > Congrats Kevin! > > On Tue, 4 Jul 2023 at 13:47, David Li wrote: > > > > Welcome Kevin! > > > > On Tue, Jul 4, 2023, at 05:55, Raúl Cumplido wrote: > > > Congratulations Kevin!!! > > > > > > El

Re: Do we need CODEOWNERS ?

2023-07-04 Thread Weston Pace
I agree the experiment isn't working very well. I've been meaning to change my listing from `compute` to `acero` for a while. I'd be +1 for just removing it though. On Tue, Jul 4, 2023, 6:44 AM Dewey Dunnington wrote: > Just a note that for me, the main problem is that I get automatic >

Re: Question about TypeHolder in arrow

2023-07-04 Thread Felipe Oliveira Carvalho
int8(), int16()… all return the same shared_ptr that gets inc-ref’d on every "creation". But any code taking type pointers shouldn't assume it comes from `static` storage. All uses of a non-owning TypeHolder should be based on something else ensuring the shared_ptr is alive while the TypeHolder

Re: [ANNOUNCE] New Arrow committer: Kevin Gurney

2023-07-04 Thread Joris Van den Bossche
Congrats Kevin! On Tue, 4 Jul 2023 at 13:47, David Li wrote: > > Welcome Kevin! > > On Tue, Jul 4, 2023, at 05:55, Raúl Cumplido wrote: > > Congratulations Kevin!!! > > > > El mar, 4 jul 2023 a las 3:32, Weston Pace () > > escribió: > >> > >> Congratulations Kevin! > >> > >> On Mon, Jul 3, 2023

Question about TypeHolder in arrow

2023-07-04 Thread wish maple
Hi, By looking into the code of arrow compute, I found there it uses `TypeHolder` [1], and expression might call `GetTypes` to get the input or output types. The document for `TypeHolder` says that it's a container for dynamically created `shared_ptr`. However, my view is: 1. It's widely used,

Re: Do we need CODEOWNERS ?

2023-07-04 Thread Dewey Dunnington
Just a note that for me, the main problem is that I get automatic review requests for PRs that have nothing to do with R (I think this happens when a rebase occurs that contained an R commit). Because that happens a lot, it means I miss actual review requests and sometimes mentions because they

Do we need CODEOWNERS ?

2023-07-04 Thread Antoine Pitrou
Hello, Some time ago we added a `.github/CODEOWNERS` file in the main Arrow repo. The idea is that, when specific files or directories are touched by a PR, specific people are asked for review. Unfortunately, it seems that, most of the time, this produces the following effects: 1) the

Re: [ANNOUNCE] New Arrow committer: Kevin Gurney

2023-07-04 Thread David Li
Welcome Kevin! On Tue, Jul 4, 2023, at 05:55, Raúl Cumplido wrote: > Congratulations Kevin!!! > > El mar, 4 jul 2023 a las 3:32, Weston Pace () escribió: >> >> Congratulations Kevin! >> >> On Mon, Jul 3, 2023 at 5:18 PM Sutou Kouhei wrote: >> >> > On behalf of the Arrow PMC, I'm happy to

Re: [ANNOUNCE] New Arrow committer: Kevin Gurney

2023-07-04 Thread Raúl Cumplido
Congratulations Kevin!!! El mar, 4 jul 2023 a las 3:32, Weston Pace () escribió: > > Congratulations Kevin! > > On Mon, Jul 3, 2023 at 5:18 PM Sutou Kouhei wrote: > > > On behalf of the Arrow PMC, I'm happy to announce that Kevin Gurney > > has accepted an invitation to become a committer on