[jira] [Commented] (ATLAS-2246) Define OMRS Connector interface

[ https://issues.apache.org/jira/browse/ATLAS-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247523#comment-16247523 ] Mandy Chessell commented on ATLAS-2246: --- Hello Cassio, I recreated the patch to incl

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/ --- (Updated Nov. 10, 2017, 1:43 p.m.) Review request for atlas, David Radley and M

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/ --- (Updated Nov. 10, 2017, 1:39 p.m.) Review request for atlas, David Radley and M

[jira] [Updated] (ATLAS-2246) Define OMRS Connector interface

[ https://issues.apache.org/jira/browse/ATLAS-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mandy Chessell updated ATLAS-2246: -- Attachment: 0002-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch Updated patch to inc

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 3, 2017, 9:02 a.m., Nigel Jones wrote: > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotDeletedException.java > > Lines 25 (patched) > > > > > > Minor/naming -- We have an exception TypeDefIn

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 3, 2017, 9:02 a.m., Nigel Jones wrote: > > omrs/pom.xml > > Lines 26 (patched) > > > > > > The parent pom doesn't specify this module. I presume this is due to > > the omrs code not being ready yet ie inten

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 3, 2017, 9:02 a.m., Nigel Jones wrote: > > om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/README.md > > Lines 19 (patched) > > > > > > I presume this is part of the changes not ready for review? (given a

[jira] [Updated] (ATLAS-1095) Open connector framework

[ https://issues.apache.org/jira/browse/ATLAS-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mandy Chessell updated ATLAS-1095: -- Attachment: 0001-ATLAS-1095-initial-code-drop-for-OCF-with-fixes-from.patch Updated patch based

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/ --- (Updated Nov. 10, 2017, 12:48 p.m.) Review request for atlas and Madhan Neethir

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/ --- (Updated Nov. 10, 2017, 12:45 p.m.) Review request for atlas and Madhan Neethir

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 3, 2017, 8:42 a.m., Nigel Jones wrote: > > * I was able to apply patch to master without any significant negative > > impact > > > > * * A few files do report whitespace errors when the patch is applied - > > minor > > > > 08:01 $ git am < > > ~/Downloads/0001-ATLAS-1095-initial-co

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 7, 2017, 1:27 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaAttribute.java > > Lines 67 (patched) > > > > > > is that necessary to check whether template.getAttribute

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 7, 2017, 1:27 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Schema.java > > Lines 88 (patched) > > > > > > schemaLinks is not initialized in the constructor. Thanks - fixe

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 7, 2017, 1:27 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Schema.java > > Lines 49 (patched) > > > > > > this is class is not included in the patch, I can't find it. Sch

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 7, 2017, 2:55 p.m., Yao Li wrote: > > based on your OCF document, Connector Instance Adapter and Connector > > Provider Adapter are not in the patch Agreed - With the base classes for connector and connector provider, I do not think we need this - Mandy --

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 7, 2017, 5:55 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedAssetProperties.java > > Lines 45 (patched) > > > > > > AssetUniverse extends AssetDetail which extends A

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 7, 2017, 5:55 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/OperationalStatus.java > > Lines 23 (patched) > > > > > > should here be the explanation of OperationalStatus?

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 7, 2017, 5:55 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/MapSchemaElement.java > > Lines 20 (patched) > > > > > > Would you mind adding an explanation for this Class? I

Review Request 63721: ATLAS-1964 :UI, Support to resize and order columns in Search table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63721/ --- Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues. B

[jira] [Updated] (ATLAS-1964) UI : Support to resize and order columns in Search table

[ https://issues.apache.org/jira/browse/ATLAS-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] pratik pandey updated ATLAS-1964: - Attachment: ATLAS-1964-branch0.8.patch > UI : Support to resize and order columns in Search table

[jira] [Updated] (ATLAS-1964) UI : Support to resize and order columns in Search table

[ https://issues.apache.org/jira/browse/ATLAS-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] pratik pandey updated ATLAS-1964: - Attachment: ATLAS-1964-master.patch > UI : Support to resize and order columns in Search table > -

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 6, 2017, 2:38 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java > > Lines 47 (patched) > > > > > > AssetUniverse extends AssetDetail which extends

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 6, 2017, 2:38 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java > > Lines 40 (patched) > > > > > > you mean below method? > > > > public void setConne

[jira] [Updated] (ATLAS-1964) UI : Support to resize and order columns in Search table

[ https://issues.apache.org/jira/browse/ATLAS-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] pratik pandey updated ATLAS-1964: - Fix Version/s: 1.0.0 > UI : Support to resize and order columns in Search table >

Re: Review Request 63706: [ATLAS-2256]: Make JanusGraph as the default graph-provider in atlas

> On Nov. 9, 2017, 9:10 p.m., Madhan Neethiraj wrote: > > Ship It! Looks great - thanks for making the change Sarath - Graham --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63706/#review1906

[jira] [Assigned] (ATLAS-1964) UI : Support to resize and order columns in Search table

[ https://issues.apache.org/jira/browse/ATLAS-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] pratik pandey reassigned ATLAS-1964: Assignee: pratik pandey (was: Keval Bhatt) > UI : Support to resize and order columns in S