Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

y we'd want the error JSON to have a details field which can capture more information if needed. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61502/#review1

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

ache.org/r/61502/diff/3/ Changes: https://reviews.apache.org/r/61502/diff/2-3/ Testing --- Validated the correctness of results using curl/postman calls, any invalid type name / classification throws 400 now. mvn clean package -Pdist,berkeley-elasticsearch executes successfully Thanks, Apoorv Naik

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

- Apoorv Naik On Aug. 9, 2017, 5:51 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61502/ > ---

Re: Review Request 61552: ATLAS-2038 : Unit Test cases for AtlasAuthentication and Authorization Filter

I believe, that would eliminate the need of starting the server. - Apoorv Naik On Aug. 10, 2017, 11:20 a.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 61541: ATLAS-2037: Unit Test Failure Resolution: testConsumersAreStoppedWhenInstanceBecomesPassive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61541/#review182606 --- Ship it! Ship It! - Apoorv Naik On Aug. 10, 2017, 4:18 p.m

Review Request 61667: ATLAS-2044: In-memory filtering after index query

edicateUtil.java PRE-CREATION Diff: https://reviews.apache.org/r/61667/diff/1/ Testing --- REST and UI testing no longer show the false positive matches. mvn clean package -Pdist (in progress) Thanks, Apoorv Naik

Re: [ANNOUNCE] New Committer: Mandy Chessell

Congratulations Mandy. On 8/15/17, 10:21 AM, "Ayub Khan Pathan" wrote: >Congratulations, Mandy. > >On 8/15/17, 8:51 PM, "Madhan Neethiraj" wrote: > >Atlas community, > > > >Apache Atlas PMC has asked Mandy Chessell to become a committer and we are > pleased to announce

Re: [ANNOUNCE] New Committer: Ashutosh Mestry

Congratulations Ashutosh. On 8/15/17, 10:21 AM, "Ayub Khan Pathan" wrote: >Congratulations, Ashutosh! > >On 8/13/17, 11:03 PM, "Madhan Neethiraj" wrote: > >Atlas community, > > > >Apache Atlas PMC has asked Ashutosh Mestry to become a committer and we > are pleased to

Re: [ANNOUNCE] New Committer: David Radley

Congratulations David. On 8/15/17, 10:20 AM, "Ayub Khan Pathan" wrote: >Congratulations, David. > >On 8/13/17, 11:07 PM, "Madhan Neethiraj" wrote: > >Atlas community, > > > >Apache Atlas PMC has asked David Radley to become a committer and we are > pleased to announce

Review Request 61670: ATLAS-1880: UTs

PRE-CREATION Diff: https://reviews.apache.org/r/61670/diff/1/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

Re: Review Request 61667: ATLAS-2044: In-memory filtering after index query

eviews.apache.org/r/61667/diff/1-2/ Testing --- REST and UI testing no longer show the false positive matches. mvn clean package -Pdist (in progress) Thanks, Apoorv Naik

Re: Review Request 61667: ATLAS-2044: In-memory filtering after index query

n clean package -Pdist (in progress) Thanks, Apoorv Naik

Re: Review Request 61667: ATLAS-2044: In-memory filtering after index query

ava b209ecb4 repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java PRE-CREATION Diff: https://reviews.apache.org/r/61667/diff/4/ Changes: https://reviews.apache.org/r/61667/diff/3-4/ Testing --- REST and UI testing no longer show the false positive matches. mvn clean p

Re: Review Request 61667: ATLAS-2044: In-memory filtering after index query

n clean package -Pdist (in progress) Thanks, Apoorv Naik

Re: Review Request 61721: [ATLAS-2054]: Add flag to exclude attribute mapping in FullTextMapper

/FullTextMapperV2.java Lines 251 (patched) <https://reviews.apache.org/r/61721/#comment259180> Is this needed ? The injected configuration object can be used instead. - Apoorv Naik On Aug. 17, 2017, 9:02 p.m., Sarath Subramanian

Re: Review Request 61747: [ATLAS-2059]: Update test-patch.sh script for PreCommit-ATLAS-Build jenkins job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61747/#review183254 --- Ship it! Ship It! - Apoorv Naik On Aug. 18, 2017, 6:11 p.m

Re: Review Request 61762: [ATLAS-2062]: Add flag to disable v1 gremlin search API using atlas-application property

/web/resources/MetadataDiscoveryResource.java Line 76 (original), 83 (patched) <https://reviews.apache.org/r/61762/#comment259287> Inject configuration here instead. - Apoorv Naik On Aug. 18, 2017, 11:01 p.m., Sarath Subramanian

Review Request 61764: ATLAS-2061: Entity, Tag filter fetches empty results when applied on an enum attribute.

://reviews.apache.org/r/61764/diff/1/ Testing --- UI and REST tests give correct results Thanks, Apoorv Naik

Re: Review Request 61794: ATLAS-2076: Add RELATIONSHIP type to search filters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61794/#review183391 --- Looks good to me - Apoorv Naik On Aug. 21, 2017, 8:37 p.m

Re: Review Request 61795: ATLAS-2060: Fix logger class name typos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61795/#review183392 --- Ship it! Ship It! - Apoorv Naik On Aug. 21, 2017, 8:40 p.m

Re: Review Request 61854: ATLAS-2082: basic-search fails when in-memory filters all results from index-query

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61854/#review183628 --- Ship it! Ship It! - Apoorv Naik On Aug. 23, 2017, 5:44 p.m

Re: Review Request 61891: ATLAS-2085: fix incorrect initialization in HA deployment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61891/#review183770 --- Ship it! Ship It! - Apoorv Naik On Aug. 24, 2017, 6:56 p.m

Re: Review Request 61887: ATLAS-2071 : UI : Minification of atlas code (js, css)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61887/#review183781 --- Ship it! Ship It! - Apoorv Naik On Aug. 24, 2017, 1:16 p.m

Re: [VOTE] Release Apache Atlas 0.8.1 - release candidate 1

- Verified signature & md5 - Build is ok with some random timeout failure (IT) - UT passing - Rat check is OK - Correct release tag - Basic search enhancement working fine - UI looks good, no issues Thanks for you time and effort in preparing this release + 1 for the release

Re: Emtity Resource v1 test failures

I think Sarath already made changes for this one don't know why this failed again. Perhaps we need to revisit the integration tests after all. One jira per test failure should be a great way to split work amongst the community. Sent from Nine __

Re: Review Request 61913: ATLAS-2012: Build docker image

tps://reviews.apache.org/r/61913/#comment259929> Just curious as to why we're logging into hbase shell - Apoorv Naik On Aug. 25, 2017, 1:14 p.m., Nigel Jones wrote: > > --- > This is an automatically generated e-m

Re: Review Request 62009: ATLAS-2101: Update Implementation to Eliminate Use of Stopwatch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62009/#review184296 --- Ship it! Ship It! - Apoorv Naik On Aug. 31, 2017, 5:02 a.m

Re: Review Request 62009: ATLAS-2101: Update Implementation to Eliminate Use of Stopwatch

> On Aug. 31, 2017, 5:48 p.m., Apoorv Naik wrote: > > Ship It! I'll commit once I review/test some scenarios. Code wise the changes look good. - Apoorv --- This is an automatically generated e-mail. To reply

Review Request 62110: ATLAS-2115: Fix Regression on Basic search

/1/ Testing --- Tested via scripts and network call timing in Chrome/Firefox. Thanks, Apoorv Naik

Review Request 62127: ATLAS-2118: Basic search contains issue

repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java d5e39236 Diff: https://reviews.apache.org/r/62127/diff/1/ Testing --- UI and REST calls work as expected now Thanks, Apoorv Naik

Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java fc973e6f Diff: https://reviews.apache.org/r/62129/diff/1/ Testing --- UI and REST calls working as expected now. Thanks, Apoorv Naik

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

Looks like the patch missed this change. Will update the patch shortly. - Apoorv ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62110/#review184744

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

d5e39236 repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java fc973e6f Diff: https://reviews.apache.org/r/62110/diff/2/ Changes: https://reviews.apache.org/r/62110/diff/1-2/ Testing --- Tested via scripts and network call timing in Chrome/Firefox. Thanks, Apoorv Naik

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

/SearchPredicateUtil.java Lines 329 (patched) <https://reviews.apache.org/r/62110/#comment260958> I think this should be return (value instanceof Collection) && ((Collection) value).contains(attrVal); - Apoorv Naik On Sept. 6, 2017, 11:11 p.m., Apo

Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

he.org/r/62129/#comment260962> Will do. - Apoorv Naik On Sept. 6, 2017, 11:38 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

and REST calls working as expected now. Thanks, Apoorv Naik

Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

https://reviews.apache.org/r/62129/#review184749 ------- On Sept. 6, 2017, 11:38 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-m

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

> On Sept. 6, 2017, 11:17 p.m., Apoorv Naik wrote: > > repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java > > Lines 329 (patched) > > <https://reviews.apache.org/r/62110/diff/2/?file=1816688#file1816688line329> > > > > I think

Re: [ANNOUNCE] New Committer: Sharmadha Sainath

Congratulations Sharmadha. On 9/8/17, 10:29 AM, "Sarath Subramanian" wrote: >Congratulations Sharmadha! > > >Regards, >Sarath Subramanian > >On Thu, Sep 7, 2017 at 4:49 PM, Madhan Neethiraj wrote: > >> Atlas community, >> >> >> >> Apache Atlas PMC has asked Sharmadha Sainath to become a com

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

ts unless it exceeds 10 - Apoorv Naik On Sept. 1, 2017, 9:50 a.m., David Radley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

Diff: https://reviews.apache.org/r/62110/diff/3/ Changes: https://reviews.apache.org/r/62110/diff/2-3/ Testing --- Tested via scripts and network call timing in Chrome/Firefox. Thanks, Apoorv Naik

Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

working as expected now. Thanks, Apoorv Naik

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

/v1/AtlasTypeDefGraphStoreV1.java Lines 385 (patched) <https://reviews.apache.org/r/61526/#comment261494> Sorry I misread the brackets. This is ok. - Apoorv Naik On Sept. 12, 2017, 12:09 p.m., David Radley wrote: > > ---

Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

/ClassificationSearchProcessor.java 0daab030 repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java d5e39236 Diff: https://reviews.apache.org/r/62129/diff/3/ Changes: https://reviews.apache.org/r/62129/diff/2-3/ Testing --- UI and REST calls working as expected now. Thanks, Apoorv Naik

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

/ Testing --- Tested via scripts and network call timing in Chrome/Firefox. Thanks, Apoorv Naik

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

in Chrome/Firefox. Thanks, Apoorv Naik

Re: Review Request 62127: ATLAS-2118: Basic search contains issue

/ Testing --- UI and REST calls work as expected now Thanks, Apoorv Naik

Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

: https://reviews.apache.org/r/62129/diff/3-4/ Testing --- UI and REST calls working as expected now. Thanks, Apoorv Naik

Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

nerated e-mail. To reply, visit: https://reviews.apache.org/r/62129/#review185363 ------- On Sept. 14, 2017, 2:32 a.m., Apoorv Naik wrote: > > --- > This is an automatic

Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

/SearchProcessor.java ddf117fa Diff: https://reviews.apache.org/r/62129/diff/5/ Changes: https://reviews.apache.org/r/62129/diff/4-5/ Testing --- UI and REST calls working as expected now. Thanks, Apoorv Naik

Re: Review Request 62127: ATLAS-2118: Basic search contains issue

) - repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 1cb2249d Diff: https://reviews.apache.org/r/62127/diff/3/ Changes: https://reviews.apache.org/r/62127/diff/2-3/ Testing --- UI and REST calls work as expected now Thanks, Apoorv Naik

Review Request 62337: ATLAS-2028: Search attribute validation

/SearchContext.java d42078a2 Diff: https://reviews.apache.org/r/62337/diff/1/ Testing --- REST calls return 400 Thanks, Apoorv Naik

Review Request 62338: ATLAS-2091: Special tokenizer character shouldn't be included in index query

logs indicate that the attribute will not be processed by index Thanks, Apoorv Naik

Re: Review Request 62338: ATLAS-2091: Special tokenizer character shouldn't be included in index query

operator should match the provided value as is (user will most likely enter a regex for LIKE) - Apoorv Naik On Sept. 14, 2017, 6:43 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 62338: ATLAS-2091: Special tokenizer character shouldn't be included in index query

> On Sept. 14, 2017, 7:34 p.m., Apoorv Naik wrote: > > This should be extended for suffix regex matches too. And LIKE operator > > should match the provided value as is (user will most likely enter a regex > > for LIKE) Oops, commented on wr

Re: Review Request 62127: ATLAS-2118: Basic search contains issue

operator should match the provided value as is (user will most likely enter a regex for LIKE) - Apoorv Naik On Sept. 14, 2017, 4:37 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Review Request 62359: Atlas client enhancement for import call

/java/org/apache/atlas/utils/TestResourceFileUtils.java PRE-CREATION Diff: https://reviews.apache.org/r/62359/diff/1/ Testing --- Performed an import against a local instance of Atlas from test code Thanks, Apoorv Naik

Review Request 62401: ATLAS-2138: Admin import calls in Atlas client

/AtlasBaseClient.java 602831a2 repository/src/test/java/org/apache/atlas/utils/TestResourceFileUtils.java PRE-CREATION Diff: https://reviews.apache.org/r/62401/diff/1/ Testing --- Successful import from test code Thanks, Apoorv Naik

Review Request 62416: ATLAS-2121: Case sensitivity for tag/type name search with index

/atlas/discovery/ClassificationSearchProcessor.java 1d4815df repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 970cd28e Diff: https://reviews.apache.org/r/62416/diff/1/ Testing --- UI and REST calls work as expected. Thanks, Apoorv Naik

Re: Review Request 62416: ATLAS-2121: Case sensitivity for tag/type name search with index

/1-2/ Testing --- UI and REST calls work as expected. Thanks, Apoorv Naik

Review Request 62455: ATLAS-2092: Upfront edgelabel creation to avoid concurrency issues

/62455/diff/1/ Testing --- mvn clean package -Dberkeley-elasticsearch went through fine Build was done 3-4 times to ensure that the concurrency tests passed every time Thanks, Apoorv Naik

Re: Review Request 62455: ATLAS-2092: Upfront edgelabel creation to avoid concurrency issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62455/#review185837 --- Will update the code per the review comments - Apoorv Naik On

Re: Review Request 62455: ATLAS-2092: Upfront edgelabel creation to avoid concurrency issues

details. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62455/#review185892 --- On Sept. 20, 2017, 9:

Re: Review Request 62455: ATLAS-2092: Upfront edgelabel creation to avoid concurrency issues

was done 3-4 times to ensure that the concurrency tests passed every time Thanks, Apoorv Naik

Review Request 62491: ATLAS-2151: Surrounding brace fix for multiple filters on same attribute

ntities": true, "classification" : "", "query": "", "limit": 10, "offset": 0, "entityFilters": { "attributeName": "createTime", "operator": "neq", "attributeValue": "1491248917103" }, "tagFilters": null, "attributes": ["createTime"] } ``` Verified from logs that the index query is enclosed within braces for multi-filter attribute query and not when there's only one attribute (single) filter Verified the results from REST calls (as UI doesn't support this use case) Thanks, Apoorv Naik

Re: Review Request 62455: ATLAS-2092: Upfront edgelabel creation to avoid concurrency issues

--- mvn clean package -Dberkeley-elasticsearch went through fine Build was done 3-4 times to ensure that the concurrency tests passed every time Thanks, Apoorv Naik

Re: Review Request 62455: ATLAS-2092: Upfront edgelabel creation to avoid concurrency issues

Thanks, Apoorv Naik

Re: Review Request 62491: ATLAS-2151: Surrounding brace fix for multiple filters on same attribute

teTime"] } { "typeName": "hive_table", "excludeDeletedEntities": true, "classification" : "", "query": "", "limit": 10, "offset": 0, "entityFilters": { "attributeName": "createTime", "operator": "neq", "attributeValue": "1491248917103" }, "tagFilters": null, "attributes": ["createTime"] } ``` Verified from logs that the index query is enclosed within braces for multi-filter attribute query and not when there's only one attribute (single) filter Verified the results from REST calls (as UI doesn't support this use case) Thanks, Apoorv Naik

Re: Review Request 62568: ATLAS-2174:- Code Improvement & Validations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62568/#review186270 --- Ship it! Ship It! - Apoorv Naik On Sept. 26, 2017, 12:01

Re: Review Request 62577: [ATLAS-2176] NegativeSSLAndKerberosTest failing due to error in initialization

good. repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java Line 121 (original), 122 (patched) <https://reviews.apache.org/r/62577/#comment262751> Spaces instead of tabs - Apoorv Naik On Sept. 26, 2017, 3:06 p.m., Gergo Barna

Review Request 62585: ATLAS-2179: Split Atlas client library to avoid unnecessary dependencies

/test.properties PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java ad88c1b3 Diff: https://reviews.apache.org/r/62585/diff/1/ Testing --- compile goes through fine mvn clean package also goes through fine Thanks, Apoorv Naik

Re: Review Request 62585: ATLAS-2179: Split Atlas client library to avoid unnecessary dependencies

, Apoorv Naik

Re: Review Request 62585: ATLAS-2179: Split Atlas client library to avoid unnecessary dependencies

--- compile goes through fine mvn clean package also goes through fine QuickStart ran successfully Thanks, Apoorv Naik

Review Request 62627: ATLAS-2155: Allow null value comparison for NEQ operation with String attributes

- repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 18d77ee7 Diff: https://reviews.apache.org/r/62627/diff/1/ Testing --- REST and curl validation mvn clean package was successful as well Thanks, Apoorv Naik

Review Request 62679: ATLAS-2184: IS_NULL and NOT_NULL operator support

/diff/1/ Testing --- Tested using various combinations of attributes and IS_NULL/NOT_NULL operator via REST client/ curl Thanks, Apoorv Naik

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

/KafkaConsumerTest.java Line 122 (original), 119 (patched) <https://reviews.apache.org/r/62681/#comment263373> Might be a good time to get rid of Gson as well and use Jackson ObjectMapper across Atlas codebase. - Apoorv Naik On Sept. 29, 2017, 12:26 a.m., Madhan Neethiraj

Re: Review Request 62679: ATLAS-2184: IS_NULL and NOT_NULL operator support

/NOT_NULL operator via REST client/ curl Thanks, Apoorv Naik

Re: Review Request 62679: ATLAS-2184: IS_NULL and NOT_NULL operator support

/SearchPredicateUtil.java Lines 558 (patched) <https://reviews.apache.org/r/62679/#comment263473> I think the names are really confusing here. Will update the patch with suggested changes and some variable name changes. - Apoorv Naik On Sept. 29, 2017, 2:05 p.m., Apoorv Naik

Re: Review Request 62679: ATLAS-2184: IS_NULL and NOT_NULL operator support

Diff: https://reviews.apache.org/r/62679/diff/3/ Changes: https://reviews.apache.org/r/62679/diff/2-3/ Testing --- Tested using various combinations of attributes and IS_NULL/NOT_NULL operator via REST client/ curl Thanks, Apoorv Naik

Re: Review Request 62679: ATLAS-2184: IS_NULL and NOT_NULL operator support

ache.org/r/62679/diff/4/ Changes: https://reviews.apache.org/r/62679/diff/3-4/ Testing --- Tested using various combinations of attributes and IS_NULL/NOT_NULL operator via REST client/ curl Thanks, Apoorv Naik

Re: Review Request 61670: ATLAS-1880: Integration tests for the search functionality

) --- mvn clean package executes successfully Test runs from IDE successfully Thanks, Apoorv Naik

Re: Review Request 61670: ATLAS-1880: Integration tests for the search functionality

://reviews.apache.org/r/61670/diff/2-3/ Testing --- mvn clean package executes successfully Test runs from IDE successfully Thanks, Apoorv Naik

Re: Review Request 62679: ATLAS-2184: IS_NULL and NOT_NULL operator support

https://reviews.apache.org/r/62679/#review186750 --- On Sept. 29, 2017, 4:49 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 62679: ATLAS-2184: IS_NULL and NOT_NULL operator support

18d77ee7 Diff: https://reviews.apache.org/r/62679/diff/5/ Changes: https://reviews.apache.org/r/62679/diff/4-5/ Testing --- Tested using various combinations of attributes and IS_NULL/NOT_NULL operator via REST client/ curl Thanks, Apoorv Naik

Re: Review Request 62679: ATLAS-2184: IS_NULL and NOT_NULL operator support

/apache/atlas/util/SearchPredicateUtil.java 18d77ee7 Diff: https://reviews.apache.org/r/62679/diff/6/ Changes: https://reviews.apache.org/r/62679/diff/5-6/ Testing --- Tested using various combinations of attributes and IS_NULL/NOT_NULL operator via REST client/ curl Thanks, Apoorv Naik

Re: Review Request 61670: ATLAS-1880: Integration tests for the search functionality

/61670/diff/4/ Changes: https://reviews.apache.org/r/61670/diff/3-4/ Testing --- mvn clean package executes successfully Test runs from IDE successfully Thanks, Apoorv Naik

Review Request 62758: ATLAS-2184: IsNull/NotNull bugfixes

/diff/1/ Testing --- UI/REST calls works as expected, no 500s encountered Thanks, Apoorv Naik

Review Request 62874: Hive hook OOM fix

/1/ Testing --- Fired reported command via beeline and verified "view" and it's col lineage shows up in Atlas UI. Thanks, Apoorv Naik

Review Request 62875: ATLAS-2201: Test consistency and dependency upgrade

package executes successfully with new changes Thanks, Apoorv Naik

Re: Review Request 62874: Hive hook OOM fix

Diff: https://reviews.apache.org/r/62874/diff/2/ Changes: https://reviews.apache.org/r/62874/diff/1-2/ Testing --- Fired reported command via beeline and verified "view" and it's col lineage shows up in Atlas UI. Thanks, Apoorv Naik

Re: Review Request 62889: ATLAS-1757 POM changes

tps://reviews.apache.org/r/62889/#comment264712> Any issues with Lucene 4.10.4 with TP2 ? - Apoorv Naik On Oct. 11, 2017, 1:43 p.m., Graham Wallis wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 62875: ATLAS-2201: Test consistency and dependency upgrade

Thanks, Apoorv Naik

Re: Review Request 62875: ATLAS-2201: Test consistency and dependency upgrade

/repository/store/graph/AtlasTypeDefGraphStoreTest.java 728d4180 Diff: https://reviews.apache.org/r/62875/diff/2/ Testing --- mvn clean package executes successfully with new changes Thanks, Apoorv Naik

Re: Question about PRs and workflow

Hey Andrew, Thanks for your interest in Atlas, the best way to contribute is to file JIRAs and then open a corresponding code review on Reviewboard. Currently we don’t follow the Github PR model for Atlas. > On Oct 13, 2017, at 8:52 AM, Andrew Hulbert wrote: > > Hi, > > I was playing around

Re: Review Request 62984: ATLAS-2210 Get and Delete Relationships in AtlasClientV2

"guid/", HttpMethod.DELETE, Response.Status.NO_CONTENT); public void deleteRelationshipByGuid(String guid) throws AtlasServiceException { callAPI(API_V2.DELETE_RELATIONSHIP_BY_GUID, AtlasRelationship.class, null, guid); } ``` - Apoorv Naik On Oct. 13

Re: Review Request 62984: ATLAS-2210 Get and Delete Relationships in AtlasClientV2

allAPI(API_V2.DELETE_RELATIONSHIP_BY_GUID, null, null, guid); } ``` This should work. - Apoorv Naik On Oct. 13, 2017, 6:48 p.m., Andrew Hulbert wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 62889: ATLAS-1757 POM changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62889/#review188191 --- Ship it! Ship It! - Apoorv Naik On Oct. 11, 2017, 1:43 p.m

Re: Review Request 62984: ATLAS-2210 Get and Delete Relationships in AtlasClientV2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62984/#review188378 --- Ship it! Ship It! - Apoorv Naik On Oct. 17, 2017, 7:36 p.m

Review Request 63090: ATLAS-2214: Issue with neq and notNull/ eq and isNull

sn't report 500 for the use case mentioned in the JIRA Thanks, Apoorv Naik

Review Request 63119: ATLAS-2218: Test stability across branches (ITs)

351e5ae7 webapp/src/test/resources/testng.xml PRE-CREATION Diff: https://reviews.apache.org/r/63119/diff/1/ Testing --- mvn clean package was successful mvn clean install was successful (some failures starting hive-bridge module, will be addressed in another review) Thanks, Apoorv Naik

<    1   2   3   4   5   6   7   >