Re: Review Request 62984: ATLAS-2210 Get and Delete Relationships in AtlasClientV2

2017-10-17 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62984/#review188378 --- Ship it! Ship It! - Apoorv Naik On Oct. 17, 2017, 7:36 p.m.,

Re: Review Request 62984: ATLAS-2210 Get and Delete Relationships in AtlasClientV2

2017-10-17 Thread Andrew Hulbert
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62984/ --- (Updated Oct. 17, 2017, 3:36 p.m.) Review request for atlas and Apoorv Naik.

Re: Review Request 62984: ATLAS-2210 Get and Delete Relationships in AtlasClientV2

2017-10-16 Thread Andrew Hulbert
> On Oct. 16, 2017, 2:44 p.m., Apoorv Naik wrote: > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > > Lines 387 (patched) > > > > > > Yes, the responseType param should be set to null for metho

Re: Review Request 62984: ATLAS-2210 Get and Delete Relationships in AtlasClientV2

2017-10-16 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62984/#review188186 --- client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.jav

Re: Review Request 62984: ATLAS-2210 Get and Delete Relationships in AtlasClientV2

2017-10-16 Thread Andrew Hulbert
> On Oct. 13, 2017, 4:52 p.m., Apoorv Naik wrote: > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > > Lines 387 (patched) > > > > > > formatPathParameters call is not needed here > > > >

Re: Review Request 62984: ATLAS-2210 Get and Delete Relationships in AtlasClientV2

2017-10-13 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62984/#review188019 --- client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.jav

Re: Review Request 62984: ATLAS-2210 Get and Delete Relationships in AtlasClientV2

2017-10-13 Thread Andrew Hulbert
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62984/ --- (Updated Oct. 13, 2017, 2:48 p.m.) Review request for atlas and Apoorv Naik.